Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108831/?format=api
{ "id": 108831, "url": "https://patches.dpdk.org/api/patches/108831/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220324030036.4761-3-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220324030036.4761-3-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220324030036.4761-3-humin29@huawei.com", "date": "2022-03-24T03:00:34", "name": "[V2,2/4] net/bonding: fix non-terminable while loop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2452dadcb533fdcb70b421796c706ea972e83250", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220324030036.4761-3-humin29@huawei.com/mbox/", "series": [ { "id": 22222, "url": "https://patches.dpdk.org/api/series/22222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22222", "date": "2022-03-24T03:00:32", "name": "bugfix for bonding", "version": 2, "mbox": "https://patches.dpdk.org/series/22222/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108831/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/108831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 57EF8A0507;\n\tThu, 24 Mar 2022 04:01:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B1CB42817;\n\tThu, 24 Mar 2022 04:01:34 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id AD64942816;\n Thu, 24 Mar 2022 04:01:32 +0100 (CET)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KP91n0JKNzfZYx;\n Thu, 24 Mar 2022 10:59:57 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.21; Thu, 24 Mar 2022 11:01:30 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "Huisong Li <lihuisong@huawei.com>, <stable@dpdk.org>, Min Hu\n <humin29@huawei.com>, Chas Williams <chas3@att.com>, Andrew Rybchenko\n <arybchenko@solarflare.com>, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>", "Subject": "[PATCH V2 2/4] net/bonding: fix non-terminable while loop", "Date": "Thu, 24 Mar 2022 11:00:34 +0800", "Message-ID": "<20220324030036.4761-3-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220324030036.4761-1-humin29@huawei.com>", "References": "<20211025063922.34066-1-humin29@huawei.com>\n <20220324030036.4761-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nAll slaves will be stopped and removed when closing a bonded port. But the\nwhile loop can not stop if both rte_eth_dev_stop and\nrte_eth_bond_slave_remove fail to run.\n\nFixes: fb0379bc5db3 (\"net/bonding: check stop call status\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 469dc71170..00d4deda44 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2149,13 +2149,14 @@ bond_ethdev_close(struct rte_eth_dev *dev)\n \t\treturn 0;\n \n \tRTE_BOND_LOG(INFO, \"Closing bonded device %s\", dev->device->name);\n-\twhile (internals->slave_count != skipped) {\n+\twhile (skipped < internals->slave_count) {\n \t\tuint16_t port_id = internals->slaves[skipped].port_id;\n \n \t\tif (rte_eth_dev_stop(port_id) != 0) {\n \t\t\tRTE_BOND_LOG(ERR, \"Failed to stop device on port %u\",\n \t\t\t\t port_id);\n \t\t\tskipped++;\n+\t\t\tcontinue;\n \t\t}\n \n \t\tif (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {\n", "prefixes": [ "V2", "2/4" ] }