Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108830/?format=api
{ "id": 108830, "url": "https://patches.dpdk.org/api/patches/108830/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220324030036.4761-2-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220324030036.4761-2-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220324030036.4761-2-humin29@huawei.com", "date": "2022-03-24T03:00:33", "name": "[V2,1/4] net/bonding: fix non-active slaves aren't stopped", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b481c8f2386a09edf6811ab11355c9c107aa93a9", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220324030036.4761-2-humin29@huawei.com/mbox/", "series": [ { "id": 22222, "url": "https://patches.dpdk.org/api/series/22222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22222", "date": "2022-03-24T03:00:32", "name": "bugfix for bonding", "version": 2, "mbox": "https://patches.dpdk.org/series/22222/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108830/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/108830/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2694DA0507;\n\tThu, 24 Mar 2022 04:01:26 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1367A4280E;\n\tThu, 24 Mar 2022 04:01:26 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 87B154280E;\n Thu, 24 Mar 2022 04:01:24 +0100 (CET)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.57])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KP93F3cVGz1GCyG;\n Thu, 24 Mar 2022 11:01:13 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.21; Thu, 24 Mar 2022 11:01:22 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "Huisong Li <lihuisong@huawei.com>, <stable@dpdk.org>, Min Hu\n <humin29@huawei.com>, Chas Williams <chas3@att.com>, Radu Nicolau\n <radu.nicolau@intel.com>", "Subject": "[PATCH V2 1/4] net/bonding: fix non-active slaves aren't stopped", "Date": "Thu, 24 Mar 2022 11:00:33 +0800", "Message-ID": "<20220324030036.4761-2-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220324030036.4761-1-humin29@huawei.com>", "References": "<20211025063922.34066-1-humin29@huawei.com>\n <20220324030036.4761-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen stopping a bonded port, all slaves should be deactivated. But only\nactive slaves are stopped. So fix it and do \"deactivae_slave()\" for active\nslaves.\n\nFixes: 0911d4ec0183 (\"net/bonding: fix crash when stopping mode 4 port\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex b305b6a35b..469dc71170 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2118,18 +2118,20 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)\n \tinternals->link_status_polling_enabled = 0;\n \tfor (i = 0; i < internals->slave_count; i++) {\n \t\tuint16_t slave_id = internals->slaves[i].port_id;\n+\n+\t\tinternals->slaves[i].last_link_status = 0;\n+\t\tret = rte_eth_dev_stop(slave_id);\n+\t\tif (ret != 0) {\n+\t\t\tRTE_BOND_LOG(ERR, \"Failed to stop device on port %u\",\n+\t\t\t\t slave_id);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\t/* active slaves need to deactivate. */\n \t\tif (find_slave_by_id(internals->active_slaves,\n \t\t\t\tinternals->active_slave_count, slave_id) !=\n-\t\t\t\t\t\tinternals->active_slave_count) {\n-\t\t\tinternals->slaves[i].last_link_status = 0;\n-\t\t\tret = rte_eth_dev_stop(slave_id);\n-\t\t\tif (ret != 0) {\n-\t\t\t\tRTE_BOND_LOG(ERR, \"Failed to stop device on port %u\",\n-\t\t\t\t\t slave_id);\n-\t\t\t\treturn ret;\n-\t\t\t}\n+\t\t\t\tinternals->active_slave_count)\n \t\t\tdeactivate_slave(eth_dev, slave_id);\n-\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [ "V2", "1/4" ] }