Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108469/?format=api
{ "id": 108469, "url": "https://patches.dpdk.org/api/patches/108469/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220302063052.347122-4-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220302063052.347122-4-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220302063052.347122-4-ke1x.zhang@intel.com", "date": "2022-03-02T06:30:51", "name": "[v6,3/4] net/ice: add support for add/remove mac addr by DCF", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ab764e04bd2b2118217e68d891df1bdf76756a79", "submitter": { "id": 2503, "url": "https://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220302063052.347122-4-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 21972, "url": "https://patches.dpdk.org/api/series/21972/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21972", "date": "2022-03-02T06:30:48", "name": "ice repr functions by DCF", "version": 6, "mbox": "https://patches.dpdk.org/series/21972/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108469/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/108469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFD81A04A4;\n\tWed, 2 Mar 2022 07:35:53 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 15E7D4270D;\n\tWed, 2 Mar 2022 07:35:48 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id CA05B4270D\n for <dev@dpdk.org>; Wed, 2 Mar 2022 07:35:45 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Mar 2022 22:35:45 -0800", "from intel-corei7-64.sh.intel.com (HELO localhost.localdomain)\n ([10.239.251.104])\n by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Mar 2022 22:35:43 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1646202945; x=1677738945;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=hcQi0nGUqTBc7KqsdUJtE3AlDAReleOQP4k0LZb8KTg=;\n b=EhE4tgxRZfCccXP2S0w/51sCU7O4Xe0Myhjt+Rb2AuMZrtsungDU0x71\n HlHbtDxYxWl4iybjYWVLb3jgBMO3P90LXuq074vddRxIq+sLDhSPfx8xa\n 15GStQXARLD62gktluNHOwQDWwmiJfwioXKfG1gSKeu8wJ7bvjhiVTMGP\n ojSIl8iJaj3MLWucS20FXbupX4Igau6aOp82kRW/MWEbNRwOxD3qlY7Aw\n FiHrsszvY5zq6bkBz6Xtm6AQZfWCFPt4kJ6Kbnd95j6OFkDvzPSfOmmSn\n LDWQugok+HgwfvKIyaCRPSHbsCtrmlDM7baDxQ8X+5INR58UcqC7YWSIB A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10273\"; a=\"236832531\"", "E=Sophos;i=\"5.90,148,1643702400\"; d=\"scan'208\";a=\"236832531\"", "E=Sophos;i=\"5.90,148,1643702400\"; d=\"scan'208\";a=\"641583290\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "dev@dpdk.org,\n\tqiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH v6 3/4] net/ice: add support for add/remove mac addr by DCF", "Date": "Wed, 2 Mar 2022 06:30:51 +0000", "Message-Id": "<20220302063052.347122-4-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220302063052.347122-1-ke1x.zhang@intel.com>", "References": "<ke1x.zhang@intel.com>\n <20220302063052.347122-1-ke1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "allow to add/remove VF's mac addr over VF0.\nthis feature need to update ice kernel driver (newer than v1.8.0)\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\n drivers/net/ice/ice_dcf_ethdev.h | 1 +\n drivers/net/ice/ice_dcf_vf_representor.c | 81 +++++++++++++++++++++++-\n 2 files changed, 81 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_dcf_ethdev.h b/drivers/net/ice/ice_dcf_ethdev.h\nindex 11a1305038..ea5c020d61 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.h\n+++ b/drivers/net/ice/ice_dcf_ethdev.h\n@@ -50,6 +50,7 @@ struct ice_dcf_vf_repr {\n \tstruct rte_ether_addr mac_addr;\n \tuint16_t switch_domain_id;\n \tuint16_t vf_id;\n+\tuint16_t mac_num;\t /* Number of MAC addresses */\n \n \tstruct ice_dcf_vlan outer_vlan_info; /* DCF always handle outer VLAN */\n };\ndiff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_representor.c\nindex 765f5d4c95..8a387461c4 100644\n--- a/drivers/net/ice/ice_dcf_vf_representor.c\n+++ b/drivers/net/ice/ice_dcf_vf_representor.c\n@@ -159,7 +159,7 @@ ice_dcf_vf_repr_dev_info_get(struct rte_eth_dev *dev,\n \t\treturn -EIO;\n \n \tdev_info->device = dev->device;\n-\tdev_info->max_mac_addrs = 1;\n+\tdev_info->max_mac_addrs = ICE_NUM_MACADDR_MAX;\n \tdev_info->max_rx_queues = dcf_hw->vsi_res->num_queue_pairs;\n \tdev_info->max_tx_queues = dcf_hw->vsi_res->num_queue_pairs;\n \tdev_info->min_rx_bufsize = ICE_BUF_SIZE_MIN;\n@@ -536,6 +536,82 @@ ice_dcf_vf_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t}\n \treturn ret;\n }\n+static int\n+ice_dcf_repr_add_del_eth_addr(struct ice_dcf_hw *hw,\n+\t\t\tuint16_t vf_id,\n+\t\t\tstruct rte_ether_addr *addr,\n+\t\t\tbool add, uint8_t type)\n+{\n+\tstruct virtchnl_ether_addr_list *list;\n+\tstruct dcf_virtchnl_cmd args;\n+\tuint8_t cmd_buffer[sizeof(struct virtchnl_ether_addr_list) +\n+\t\t\t sizeof(struct virtchnl_ether_addr)];\n+\tint err;\n+\n+\tlist = (struct virtchnl_ether_addr_list *)cmd_buffer;\n+\tlist->vsi_id = hw->vf_vsi_map[vf_id] & ~VIRTCHNL_DCF_VF_VSI_VALID;\n+\tlist->num_elements = 1;\n+\tlist->list[0].type = type;\n+\trte_memcpy(list->list[0].addr, addr->addr_bytes,\n+\t sizeof(addr->addr_bytes));\n+\n+\targs.v_op = add ? VIRTCHNL_OP_ADD_ETH_ADDR : VIRTCHNL_OP_DEL_ETH_ADDR;\n+\targs.req_msg = cmd_buffer;\n+\targs.req_msglen = sizeof(cmd_buffer);\n+\n+\terr = ice_dcf_execute_virtchnl_cmd(hw, &args);\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"Fail to execute command %s\",\n+\t\t\t add ? \"OP_ADD_ETH_ADDR\" : \"OP_DEL_ETH_ADDR\");\n+\t\treturn err;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+ice_dcf_vf_repr_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *addr,\n+\t\t __rte_unused uint32_t index,\n+\t\t __rte_unused uint32_t pool)\n+{\n+\tstruct ice_dcf_vf_repr *repr = dev->data->dev_private;\n+\tstruct ice_dcf_hw *hw = ice_dcf_vf_repr_hw(repr);\n+\tint err;\n+\n+\tif (rte_is_zero_ether_addr(addr)) {\n+\t\tPMD_DRV_LOG(ERR, \"Invalid Ethernet Address\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\terr = ice_dcf_repr_add_del_eth_addr(hw, repr->vf_id, addr, true, VIRTCHNL_ETHER_ADDR_EXTRA);\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"fail to add MAC address\");\n+\t\treturn -EIO;\n+\t}\n+\n+\trepr->mac_num++;\n+\n+\treturn 0;\n+}\n+\n+static void\n+ice_dcf_vf_repr_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)\n+{\n+\tstruct ice_dcf_vf_repr *repr = dev->data->dev_private;\n+\tstruct ice_dcf_hw *hw = ice_dcf_vf_repr_hw(repr);\n+\tstruct rte_ether_addr *addr;\n+\tint err;\n+\n+\taddr = &dev->data->mac_addrs[index];\n+\n+\terr = ice_dcf_repr_add_del_eth_addr(hw, repr->vf_id, addr,\n+\t\t\t\t\tfalse, VIRTCHNL_ETHER_ADDR_EXTRA);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"fail to del MAC address\");\n+\n+\trepr->mac_num--;\n+}\n+\n static const struct eth_dev_ops ice_dcf_vf_repr_dev_ops = {\n \t.dev_configure = ice_dcf_vf_repr_dev_configure,\n \t.dev_start = ice_dcf_vf_repr_dev_start,\n@@ -554,6 +630,8 @@ static const struct eth_dev_ops ice_dcf_vf_repr_dev_ops = {\n \t.vlan_tpid_set = ice_dcf_vf_repr_vlan_tpid_set,\n \t.stats_reset = ice_dcf_vf_repr_stats_reset,\n \t.stats_get = ice_dcf_vf_repr_stats_get,\n+\t.mac_addr_add = ice_dcf_vf_repr_add_mac_addr,\n+\t.mac_addr_remove = ice_dcf_vf_repr_del_mac_addr,\n };\n \n int\n@@ -568,6 +646,7 @@ ice_dcf_vf_repr_init(struct rte_eth_dev *vf_rep_eth_dev, void *init_param)\n \trepr->outer_vlan_info.port_vlan_ena = false;\n \trepr->outer_vlan_info.stripping_ena = false;\n \trepr->outer_vlan_info.tpid = RTE_ETHER_TYPE_VLAN;\n+\trepr->mac_num = 1;\n \n \tvf_rep_eth_dev->dev_ops = &ice_dcf_vf_repr_dev_ops;\n \n", "prefixes": [ "v6", "3/4" ] }