Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108451/?format=api
{ "id": 108451, "url": "https://patches.dpdk.org/api/patches/108451/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_434FD929498483CED177D5C8A008428C0006@qq.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_434FD929498483CED177D5C8A008428C0006@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_434FD929498483CED177D5C8A008428C0006@qq.com", "date": "2022-03-01T18:58:37", "name": "[v4] sched: remove useless malloc in pie data init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba303e7ba74a955bb79f8a84f94a8bc6b5ed6f04", "submitter": { "id": 2458, "url": "https://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_434FD929498483CED177D5C8A008428C0006@qq.com/mbox/", "series": [ { "id": 21963, "url": "https://patches.dpdk.org/api/series/21963/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21963", "date": "2022-03-01T18:58:37", "name": "[v4] sched: remove useless malloc in pie data init", "version": 4, "mbox": "https://patches.dpdk.org/series/21963/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108451/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/108451/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4AAA5A00C3;\n\tTue, 1 Mar 2022 19:59:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E74D640696;\n\tTue, 1 Mar 2022 19:59:26 +0100 (CET)", "from out203-205-251-82.mail.qq.com (out203-205-251-82.mail.qq.com\n [203.205.251.82])\n by mails.dpdk.org (Postfix) with ESMTP id 3D60F40040\n for <dev@dpdk.org>; Tue, 1 Mar 2022 19:59:22 +0100 (CET)", "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP\n id EA5B5E2C; Wed, 02 Mar 2022 02:58:37 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1646161159;\n bh=TzPqr1++iCrEtYrb/G3NtWtTct4WM5oL2TVlslw6xio=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=uPThBJ8OseYjSh/MnzB2cDZL/s8czigBThplO5TkxnitylkDJLPk3I5FbKgiJbo7u\n Sd2gCL00MSAmyykuKicMmItcQ/v61yfP3Y5UWUck9f5iY7WfeUKTa3qNmjlIVKqKfR\n wUmUtpb9jXFtAPMiyQf6HRpVHCCBvXpEe3iwgjo8=", "X-QQ-mid": "xmsmtpt1646161117twdi71zff", "Message-ID": "<tencent_434FD929498483CED177D5C8A008428C0006@qq.com>", "X-QQ-XMAILINFO": "NwFwz4tS/C+ePOW9oXMvYZ+xDJr5WwcT8Sve38VSnXHAciRJwOqOHsNQvIKQtk\n 9EOci1w8IkdCW1wu/y3wALEjdroaEdMxdUg4jykByfq5ADRlxUffdZ9xtm6U8gixVf/e2qAtimp1\n cRcf6AydfbWzCzjnZjpWxY9CHE7iFt4t7Id2bNmRTyZq8xdRD93FozG1JiGAHwuQWFOc238SNobg\n iMM2F43GvadR+vCOSycwZPVgkdJZlYvuYCIeA4kkGnsqhgJVxG8p4mU6rLptVEfd1iBA7K7RHaSQ\n 28O/4Kuvkvr5J/S47dKfrHo74CKr8NFphfkyKsFGE6A57mTnY2yF2XAkkPpBxnRCc0Sj/GZaNyAl\n dIzvIp9DkGocTPlZQDCMokyqkByjj3VosbikpeqBzZEThxlRhxxmeQeWq1jP6rTlTNYOCE8pEUVT\n ICzvVZFkIziPExJtf773wBDNl3XteqxNtnZTKIvRkQaozHW/O99Kw5uyYvf6nFmzMgo0puwa61WW\n 7AayH/h7oeZ/iFZRDGRPNlZ9dXgQtzHMgSUYOnoiR/bRNQ2aiwEInGm5sk2TeVc8T27Z9ZXiWiYt\n Gc2EFwFtFK7G6J/JdWvmUrWIoBn2FFVDP7Q4uSai+TM/LBbH0qRJGpWHm4j4f0mbno1vmX+wkkgM\n GB0F/PgQx1gvJScBulc30iDBeJgmFyVm7n9FZS0rtXkw4mibBidNn4/cCgmEIEBM7dZybbz6cMl2\n svCNF63mbwYjTxUhkFq3zeVq7gLv0fviDxzRMwq39QbBVEbFfJapCUV2TJ433Pq9/qPQCWT0BhHt\n /bxLsHcjEAvXPL6ZKu9NXwhMzQnn25E3E8CPGE2fHWr+dI5FXDAMmUcgY63nd1nZGbtZCtSc/6d4\n On9l35jgiYYwi2bahbZG5H706mYSYzL94ViaSuPaZIwyCy1UhIy0YapaulBPG+FQ==", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "jasvinder.singh@intel.com, wojciechx.liguzinski@intel.com, dev@dpdk.org,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v4] sched: remove useless malloc in pie data init", "Date": "Wed, 2 Mar 2022 02:58:37 +0800", "X-OQ-MSGID": "<20220301185837.502387-1-liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <DM8PR11MB567001E1EA7A38A4EB00F9F2EB029@DM8PR11MB5670.namprd11.prod.outlook.com>", "References": "\n <DM8PR11MB567001E1EA7A38A4EB00F9F2EB029@DM8PR11MB5670.namprd11.prod.outlook.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to\nfail when this happen. The malloc inside the function didn't work.\nSo remove the malloc otherwise will lead to a memory leak.\n\nFixes: 44c730b0e37971 (\"sched: add PIE based congestion management\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\nv4:\n* replace all assignments to zero by a memset.\nv3:\n* fix typo\nv2:\n* revise according to Stephen's suggestion.\n---\n lib/sched/rte_pie.c | 21 +++------------------\n 1 file changed, 3 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c\nindex cdb7bab697..05a456d7ac 100644\n--- a/lib/sched/rte_pie.c\n+++ b/lib/sched/rte_pie.c\n@@ -15,26 +15,11 @@ int\n rte_pie_rt_data_init(struct rte_pie *pie)\n {\n \tif (pie == NULL) {\n-\t\t/* Allocate memory to use the PIE data structure */\n-\t\tpie = rte_malloc(NULL, sizeof(struct rte_pie), 0);\n-\n-\t\tif (pie == NULL)\n-\t\t\tRTE_LOG(ERR, SCHED, \"%s: Memory allocation fails\\n\", __func__);\n-\n-\t\treturn -1;\n+\t\tRTE_LOG(ERR, SCHED, \"%s: Invalid addr for pie\\n\", __func__);\n+\t\treturn -EINVAL;\n \t}\n \n-\tpie->active = 0;\n-\tpie->in_measurement = 0;\n-\tpie->departed_bytes_count = 0;\n-\tpie->start_measurement = 0;\n-\tpie->last_measurement = 0;\n-\tpie->qlen = 0;\n-\tpie->avg_dq_time = 0;\n-\tpie->burst_allowance = 0;\n-\tpie->qdelay_old = 0;\n-\tpie->drop_prob = 0;\n-\tpie->accu_prob = 0;\n+\tmemset(pie, 0, sizeof(*pie));\n \n \treturn 0;\n }\n", "prefixes": [ "v4" ] }