Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108414/?format=api
{ "id": 108414, "url": "https://patches.dpdk.org/api/patches/108414/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_B83A1FDF6523FB228731E13C45A738119708@qq.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_B83A1FDF6523FB228731E13C45A738119708@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_B83A1FDF6523FB228731E13C45A738119708@qq.com", "date": "2022-03-01T06:07:56", "name": "[v3] sched: remove useless malloc in pie data init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5dd847f9390b1fde25b02737cad3ed0658b344e8", "submitter": { "id": 2458, "url": "https://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_B83A1FDF6523FB228731E13C45A738119708@qq.com/mbox/", "series": [ { "id": 21936, "url": "https://patches.dpdk.org/api/series/21936/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21936", "date": "2022-03-01T06:07:56", "name": "[v3] sched: remove useless malloc in pie data init", "version": 3, "mbox": "https://patches.dpdk.org/series/21936/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108414/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/108414/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE8D9A034F;\n\tTue, 1 Mar 2022 07:08:06 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE34040DF6;\n\tTue, 1 Mar 2022 07:08:06 +0100 (CET)", "from out203-205-251-66.mail.qq.com (out203-205-251-66.mail.qq.com\n [203.205.251.66])\n by mails.dpdk.org (Postfix) with ESMTP id 26177407FF\n for <dev@dpdk.org>; Tue, 1 Mar 2022 07:08:03 +0100 (CET)", "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP\n id 1F90F87E; Tue, 01 Mar 2022 14:07:57 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1646114880;\n bh=MQb7cJfYXQrQQzzlq2aBCh2nQ1uJWFQRUMrOiKRhf+c=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=mHgcFBRp6P682eZ7MLOFYI4l/xXs/p/xeHogcwWLZvyS+6NFP9I6kgqB1M+KkCqVa\n hbmaAIHqnFdLDKTVCb6L6zVNEtS3e+NPCSKAyfMFIyVOerCypWzwwwmOqy1XUEXS/q\n 60o2Tq970Z3b97txelk1ODYxtzVzdRFlDfd8Odgo=", "X-QQ-mid": "xmsmtpt1646114877tdcpfrxke", "Message-ID": "<tencent_B83A1FDF6523FB228731E13C45A738119708@qq.com>", "X-QQ-XMAILINFO": "MZmsIF9YmPJxYbJBXGZGWoHzdLHd/kwI1pBf6G5zxEyG+2R26FY6a+yP3LjN+G\n S1po0wRQtoWKMtET9druewWSCLOU15yq5NtMKFUdkWHHoG+tJAHnew94ZU9oUZmqplmzVRNttsPF\n Cu7AjaImxwsdyBNchTY0v/mwqE1zIE9yjmjEVjCEzmbrm7C8OnPnnOcQ40D7SSDz2/c40LPHHN4Y\n Eg3xGMnlenuibn5Tcey8V/Fq6geHHvIOL72cI5OhP2Wy7SZyRuTReU6oBLOMFwglgJT0KqiPK3q2\n i02wqpXvLJ8ZjxMWWwErDuhfkat+UjNGRIcZJBZAR9zF6gyOKZDAl19rEqWIbaz5iNKVSh5qhUNL\n HotuhVBVKKKJoap79VsEyJPZAOfQDoRJZwjKrsMlFjKTqEZ7lGDz52ZwVCPiVvs8zMWyjrl5LmJV\n INQ0iSWoaEfI4i+Ag6BYziT1SnD2nALzG4WXg+qyCwn6PRFRMy8lPs6kBIsoHe4IDsajEfql8JfF\n 8pajRm2B6hV9v4+5AAMlATBE9bH2d6un6zGRy2s2kSTs/82Yv067Tzs9UqzPdRS1+u2S/i8JSYRP\n CxNnVkOkWaEN4fIMbDtmKkqGqBkyUpHKYxoLfOz6lycSwnvawwUKFXfFBOzRRSC2IyN05414u7Oe\n aWgwOpVHbf8JwjEptiy5ajKbXEaSD4DEt95qS4gzQIO69PmJwQWEtegiMJjRs4UPrnq+hKrHEDNn\n VCk2liWvvS07xxy+S4Zk4+gW2d49hJ4KlPMNluQraBAbJ7MD/0QSZIlVPz4jtzK4YdZREM8bOj4r\n OogtCoO1k6U5CM0INJo52QM9S1/tB71E+RgLz107CNY6x7gBEwh0jTvnvPIEGMROyXFBjdpM5yzC\n GGaMQElToI", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "jasvinder.singh@intel.com,\n\twojciechx.liguzinski@intel.com,\n\tdev@dpdk.org", "Subject": "[PATCH v3] sched: remove useless malloc in pie data init", "Date": "Tue, 1 Mar 2022 14:07:56 +0800", "X-OQ-MSGID": "<20220301060756.480838-1-liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com>", "References": "<tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to\nfail when this happen. The malloc inside the function didn't work.\nSo remove the malloc otherwise will lead to a memory leak.\n\nFixes: 44c730b0e37971 (\"sched: add PIE based congestion management\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\nv3:\n* fix typo\nv2:\n* revise according to Stephen's suggestion.\n---\n lib/sched/rte_pie.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c\nindex cdb7bab697..eed5c12b54 100644\n--- a/lib/sched/rte_pie.c\n+++ b/lib/sched/rte_pie.c\n@@ -15,13 +15,8 @@ int\n rte_pie_rt_data_init(struct rte_pie *pie)\n {\n \tif (pie == NULL) {\n-\t\t/* Allocate memory to use the PIE data structure */\n-\t\tpie = rte_malloc(NULL, sizeof(struct rte_pie), 0);\n-\n-\t\tif (pie == NULL)\n-\t\t\tRTE_LOG(ERR, SCHED, \"%s: Memory allocation fails\\n\", __func__);\n-\n-\t\treturn -1;\n+\t\tRTE_LOG(ERR, SCHED, \"%s: Invalid addr for pie\\n\", __func__);\n+\t\treturn -EINVAL;\n \t}\n \n \tpie->active = 0;\n", "prefixes": [ "v3" ] }