Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108371/?format=api
{ "id": 108371, "url": "https://patches.dpdk.org/api/patches/108371/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com", "date": "2022-02-27T05:25:22", "name": "[v2] sched: remove useless malloc in pie data init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5dd847f9390b1fde25b02737cad3ed0658b344e8", "submitter": { "id": 2458, "url": "https://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com/mbox/", "series": [ { "id": 21907, "url": "https://patches.dpdk.org/api/series/21907/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21907", "date": "2022-02-27T05:25:22", "name": "[v2] sched: remove useless malloc in pie data init", "version": 2, "mbox": "https://patches.dpdk.org/series/21907/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108371/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/108371/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 19E7DA00C3;\n\tSun, 27 Feb 2022 06:25:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 03B174068F;\n\tSun, 27 Feb 2022 06:25:42 +0100 (CET)", "from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com\n [162.62.57.64]) by mails.dpdk.org (Postfix) with ESMTP id 4203A40683\n for <dev@dpdk.org>; Sun, 27 Feb 2022 06:25:40 +0100 (CET)", "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP\n id 656A1443; Sun, 27 Feb 2022 13:25:22 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645939538;\n bh=x2p2QFz99EdW4RXl2bQozvsXBbpcxtiFTw8BtDxbn6Q=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=Ll1o8eZKGzVhbiqkf6RO8C32JB6MNH3FSizO5FpCStqeHzukp8TKlkKgTMaHSS/02\n 3q9psyscGlBL81ecgDaOeWITzroXVnTOI0sQER8gmgLrfmv6Rdi1fSgas4hEvsmutF\n fBLCzDdy3poGU29PmrM52LbgSHuRwMFYGUg003Ms=", "X-QQ-mid": "xmsmtpt1645939522tyj2z0yjk", "Message-ID": "<tencent_78746EBF8D471A44BC62F079644EE5221209@qq.com>", "X-QQ-XMAILINFO": "Ne9q9v6AFM79Z0JiIuj2r6ZE815J7PQdiBEK4HNfAJnkRw/Pl67t3KlLxk1RmR\n 0FRcc9mmOteyX5ol575Fw2sBoZSvbkpaVHZ8OLoR+tbUOYxWwuT55EHhSIxRp3fhTbvQxn6YsoNR\n zAL8zg4XBD7CqCXEM/FfV6y4kusJB9hNGlykmStdZoEPj/Xi+j9zL6NlPkY/Tpm1VsDAH9O0W6aT\n DkYOkI2MpzjX1AWlnxgR3cLqfgkIXG+YCuxBG82vUySh6STegL1U60roPizOCs0cMFYhdBjN39vF\n WakDQjb87+Us7L3Z2HcfofXyqvUHagJEAUpyPkUA0DSdMdZs0rT/f4C+J9uoV9O5mkxUNgfDsyL4\n y6Btmco/B/hwon0BqnzvHLEe4t5R82CYRbCg5WtMA1tDe1dJhqSrWC+dROY54gaVZ/UEnKBdJIZz\n Fbtw2zm8CGnKd+mn8HBvQYkKo8ekAODt0riXonPYxo35Y7L1h8XzsiX/Ulwt+tMqnQ6rY5Mt9aR3\n vBZSpK6X/pLWi4VPkslPcq2XExesG/W7RxWmM3IfhFGkYca9/AJi0fNayXt+v95c3pbfvGJVo13E\n s08u1KxiksqZDLn9p3wqZ4H4p4Jfa1eTexKSXmOWGbkJtF8Ha4j5xRkiYHfOUE1aiYi5kIePIrMC\n dnaNgsHvl/c/9RGhc9SNnO0pXKB3LxN8DE+6BmPTMOrSy8AEcPAQRUE1aHRLshr8NW6xgtcoo7WD\n ZG5NbTI91ADOa/RrXQMAcl8S7+QrXUuKdEFeI/7ncE1WBUTgLODL4mYHFRnAFW3MRZMoocmqvkx2\n DQ5IR5zUJhzITBws3xpQ2Yp0H85xIsPMaZ0pTwLZYp4qe79rzP7gbmDOhY6QKZMTIQjdBu7rfJjd\n nfP3RrJsRsUxYR+1TACBDedBg2nt6fINWQ0/cNfAPGGSNf1+dMYvoFjBIxo+HOew1aRWobh4Mv", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "cristian.dumitrescu@intel.com", "Cc": "wojciechx.liguzinski@intel.com, stephen@networkplumber.org, dev@dpdk.org", "Subject": "[PATCH v2] sched: remove useless malloc in pie data init", "Date": "Sun, 27 Feb 2022 13:25:22 +0800", "X-OQ-MSGID": "<20220227052522.375708-1-liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<tencent_353E2247E7FA1B6FA44C8421A689C7ED7405@qq.com>", "References": "<tencent_353E2247E7FA1B6FA44C8421A689C7ED7405@qq.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to\nfail when this happen. The malloc inside this funtion didn't work.\nSo remove the malloc otherwise will lead to a memory leak.\n\nFixes: 44c730b0e37971 (\"sched: add PIE based congestion management\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\nv2:\n* revise according to Stephen's suggestion.\n---\n lib/sched/rte_pie.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c\nindex cdb7bab697..eed5c12b54 100644\n--- a/lib/sched/rte_pie.c\n+++ b/lib/sched/rte_pie.c\n@@ -15,13 +15,8 @@ int\n rte_pie_rt_data_init(struct rte_pie *pie)\n {\n \tif (pie == NULL) {\n-\t\t/* Allocate memory to use the PIE data structure */\n-\t\tpie = rte_malloc(NULL, sizeof(struct rte_pie), 0);\n-\n-\t\tif (pie == NULL)\n-\t\t\tRTE_LOG(ERR, SCHED, \"%s: Memory allocation fails\\n\", __func__);\n-\n-\t\treturn -1;\n+\t\tRTE_LOG(ERR, SCHED, \"%s: Invalid addr for pie\\n\", __func__);\n+\t\treturn -EINVAL;\n \t}\n \n \tpie->active = 0;\n", "prefixes": [ "v2" ] }