Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108069/?format=api
{ "id": 108069, "url": "https://patches.dpdk.org/api/patches/108069/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220222193512.19292-18-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222193512.19292-18-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222193512.19292-18-ndabilpuram@marvell.com", "date": "2022-02-22T19:35:09", "name": "[v2,18/21] net/cnxk: enable flow control by default on device configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8937edb08476dd2bc450fe03cdc1eaa267a59d34", "submitter": { "id": 1202, "url": "https://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220222193512.19292-18-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 21801, "url": "https://patches.dpdk.org/api/series/21801/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21801", "date": "2022-02-22T19:34:52", "name": "[v2,01/21] common/cnxk: increase SMQ resource count", "version": 2, "mbox": "https://patches.dpdk.org/series/21801/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108069/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/108069/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B28EA034C;\n\tTue, 22 Feb 2022 20:37:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 17BA0411DB;\n\tTue, 22 Feb 2022 20:36:16 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 2235F4114B\n for <dev@dpdk.org>; Tue, 22 Feb 2022 20:36:10 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 21MIavh3019942\n for <dev@dpdk.org>; Tue, 22 Feb 2022 11:36:10 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ecwaxar5e-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 22 Feb 2022 11:36:10 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 22 Feb 2022 11:36:08 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 22 Feb 2022 11:36:08 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 8B1333F7081;\n Tue, 22 Feb 2022 11:36:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=+W7gnLrY56dNbrK/QoTuDdzkuuWbjq5ybeuGTAYaRJM=;\n b=K0dbNR7k3kJFhV77zGVSuzJ29gfO4/EdZi3Xik6T+/3UhCQd2FunFvjsPW+OwEgnjx66\n AGSE4Gd6p/0ja4jhw89Anl8skrJZLPjV08Pi5DRC0a6b5l8oISxjhmdhvIwZoDRxPhNs\n L01+DbrwfD4PqStbt0WStK4AYFW6U5wwEJn2oFaw0s85VdzEtCk76FyFkvjoMbt3ebYB\n KwwPNL05/5AOvuTVMTX/oDhmFoDfFC9ju+K1ywaTdRgOd2k/CxmNyks0+9fyW2KjOWwX\n OAfypeDQlLLwFIYFgGRxR9e+de91ylDdkPGA/5ZKZ2PrezpcRvsfMFRf6bE5nI1Cbko3 TA==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "Subject": "[PATCH v2 18/21] net/cnxk: enable flow control by default on device\n configure", "Date": "Wed, 23 Feb 2022 01:05:09 +0530", "Message-ID": "<20220222193512.19292-18-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220222193512.19292-1-ndabilpuram@marvell.com>", "References": "<20220207072932.22409-1-ndabilpuram@marvell.com>\n <20220222193512.19292-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "kKheCkoJxkMNtxsE4Hh3p1mCOklg2xPu", "X-Proofpoint-ORIG-GUID": "kKheCkoJxkMNtxsE4Hh3p1mCOklg2xPu", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-22_06,2022-02-21_02,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enable flow control by default on device configuration\ninstead of basing it on Kernel behaviour.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/net/cnxk/cnxk_ethdev.c | 24 +++++++++++-------------\n 1 file changed, 11 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex ad1e63d..9481af9 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -306,24 +306,22 @@ static int\n nix_init_flow_ctrl_config(struct rte_eth_dev *eth_dev)\n {\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tenum roc_nix_fc_mode fc_mode = ROC_NIX_FC_FULL;\n \tstruct cnxk_fc_cfg *fc = &dev->fc_cfg;\n-\tstruct rte_eth_fc_conf fc_conf = {0};\n \tint rc;\n \n-\t/* Both Rx & Tx flow ctrl get enabled(RTE_ETH_FC_FULL) in HW\n-\t * by AF driver, update those info in PMD structure.\n-\t */\n-\trc = cnxk_nix_flow_ctrl_get(eth_dev, &fc_conf);\n+\t/* To avoid Link credit deadlock on Ax, disable Tx FC if it's enabled */\n+\tif (roc_model_is_cn96_ax() &&\n+\t dev->npc.switch_header_type != ROC_PRIV_FLAGS_HIGIG)\n+\t\tfc_mode = ROC_NIX_FC_TX;\n+\n+\t/* By default enable flow control */\n+\trc = roc_nix_fc_mode_set(&dev->nix, fc_mode);\n \tif (rc)\n-\t\tgoto exit;\n+\t\treturn rc;\n \n-\tfc->mode = fc_conf.mode;\n-\tfc->rx_pause = (fc_conf.mode == RTE_ETH_FC_FULL) ||\n-\t\t\t(fc_conf.mode == RTE_ETH_FC_RX_PAUSE);\n-\tfc->tx_pause = (fc_conf.mode == RTE_ETH_FC_FULL) ||\n-\t\t\t(fc_conf.mode == RTE_ETH_FC_TX_PAUSE);\n-\n-exit:\n+\tfc->mode = (fc_mode == ROC_NIX_FC_FULL) ? RTE_ETH_FC_FULL :\n+\t\t\t\t\t\t RTE_ETH_FC_TX_PAUSE;\n \treturn rc;\n }\n \n", "prefixes": [ "v2", "18/21" ] }