Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108066/?format=api
{ "id": 108066, "url": "https://patches.dpdk.org/api/patches/108066/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220222193512.19292-15-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222193512.19292-15-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222193512.19292-15-ndabilpuram@marvell.com", "date": "2022-02-22T19:35:06", "name": "[v2,15/21] net/cnxk: fix inline IPsec security error handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0b56ac554247fec7e49f04ada909e3bc5e4a1230", "submitter": { "id": 1202, "url": "https://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220222193512.19292-15-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 21801, "url": "https://patches.dpdk.org/api/series/21801/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21801", "date": "2022-02-22T19:34:52", "name": "[v2,01/21] common/cnxk: increase SMQ resource count", "version": 2, "mbox": "https://patches.dpdk.org/series/21801/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108066/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/108066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DF06A034C;\n\tTue, 22 Feb 2022 20:36:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 51D7740DF6;\n\tTue, 22 Feb 2022 20:36:06 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 3FA6B411DB;\n Tue, 22 Feb 2022 20:36:02 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 21MItcER019938;\n Tue, 22 Feb 2022 11:36:01 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ecwaxar4d-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 22 Feb 2022 11:36:01 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 22 Feb 2022 11:35:59 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 22 Feb 2022 11:35:59 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id ACEAB3F707B;\n Tue, 22 Feb 2022 11:35:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=7bD7Y8w+YEtJpL4JN/UwxqOPtXup81Wy7WAGt2ILB6k=;\n b=X7lIIZCBzwKls4PHL1Rzm5pX7nKG6eVTmAuF8dgzjik8n4aoVnqZkpBiLZlPn6SUkTox\n phjxQFssdAjyakmC8UdSU+rTx/2nUnzbR7B4rfF19ohLP0Q82mTbtv/jULFbWslh5rhC\n VxsWf6JCEVq5Y81ahbv2nRpx2HriCiRkx8M1F13mKSgYHbfGwSs7NpqILV/9FCxnIr6W\n vYuL66/4Sco4f8ZfgDAS1ES+pTtPxTIFCvfRTuJHXqtEekeHDHcfse9O4A49+0zuoWNl\n GYRxyDW3ouNuJHl2u6Sr7kYMvm65eU8TKNPJ0entptD63rSmYXjaHitXilyOEWBRiB+R /w==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH v2 15/21] net/cnxk: fix inline IPsec security error handling", "Date": "Wed, 23 Feb 2022 01:05:06 +0530", "Message-ID": "<20220222193512.19292-15-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220222193512.19292-1-ndabilpuram@marvell.com>", "References": "<20220207072932.22409-1-ndabilpuram@marvell.com>\n <20220222193512.19292-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "6DTC_Nys8G51OdbUZLx05t23M3epzPaj", "X-Proofpoint-ORIG-GUID": "6DTC_Nys8G51OdbUZLx05t23M3epzPaj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-02-22_06,2022-02-21_02,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use raw mbuf free on inline security error to simulate\nHW NPA free instead of doing rte_pktmbuf_free(). This\nis needed as the callback will not be called from\nDPDK lcore.\n\nFixes: 69daa9e5022b (\"net/cnxk: support inline security setup for cn10k\")\nCc: stable@dpdk.org\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/net/cnxk/cn10k_ethdev_sec.c | 37 ++++++++++++++++++++++++++++++++-----\n 1 file changed, 32 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_sec.c\nindex ac45056..044b20c 100644\n--- a/drivers/net/cnxk/cn10k_ethdev_sec.c\n+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c\n@@ -138,6 +138,20 @@ static const struct rte_security_capability cn10k_eth_sec_capabilities[] = {\n \t}\n };\n \n+static inline void\n+cnxk_pktmbuf_free_no_cache(struct rte_mbuf *mbuf)\n+{\n+\tstruct rte_mbuf *next;\n+\n+\tif (!mbuf)\n+\t\treturn;\n+\tdo {\n+\t\tnext = mbuf->next;\n+\t\troc_npa_aura_op_free(mbuf->pool->pool_id, 1, (rte_iova_t)mbuf);\n+\t\tmbuf = next;\n+\t} while (mbuf != NULL);\n+}\n+\n void\n cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)\n {\n@@ -148,6 +162,7 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)\n \tstruct cpt_cn10k_res_s *res;\n \tstruct rte_eth_dev *eth_dev;\n \tstruct cnxk_eth_dev *dev;\n+\tstatic uint64_t warn_cnt;\n \tuint16_t dlen_adj, rlen;\n \tstruct rte_mbuf *mbuf;\n \tuintptr_t sa_base;\n@@ -161,7 +176,7 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)\n \t\t/* Event from inbound inline dev due to IPSEC packet bad L4 */\n \t\tmbuf = (struct rte_mbuf *)(gw[1] - sizeof(struct rte_mbuf));\n \t\tplt_nix_dbg(\"Received mbuf %p from inline dev inbound\", mbuf);\n-\t\trte_pktmbuf_free(mbuf);\n+\t\tcnxk_pktmbuf_free_no_cache(mbuf);\n \t\treturn;\n \tcase RTE_EVENT_TYPE_CPU:\n \t\t/* Check for subtype */\n@@ -212,17 +227,29 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)\n \tcase ROC_IE_OT_UCC_ERR_SA_OVERFLOW:\n \t\tdesc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;\n \t\tbreak;\n+\tcase ROC_IE_OT_UCC_ERR_PKT_IP:\n+\t\twarn_cnt++;\n+\t\tif (warn_cnt % 10000 == 0)\n+\t\t\tplt_warn(\"Outbound error, bad ip pkt, mbuf %p,\"\n+\t\t\t\t \" sa_index %u (total warnings %\" PRIu64 \")\",\n+\t\t\t\t mbuf, sess_priv.sa_idx, warn_cnt);\n+\t\tdesc.subtype = RTE_ETH_EVENT_IPSEC_UNKNOWN;\n+\t\tbreak;\n \tdefault:\n-\t\tplt_warn(\"Outbound error, mbuf %p, sa_index %u, \"\n-\t\t\t \"compcode %x uc %x\", mbuf, sess_priv.sa_idx,\n-\t\t\t res->compcode, res->uc_compcode);\n+\t\twarn_cnt++;\n+\t\tif (warn_cnt % 10000 == 0)\n+\t\t\tplt_warn(\"Outbound error, mbuf %p, sa_index %u,\"\n+\t\t\t\t \" compcode %x uc %x,\"\n+\t\t\t\t \" (total warnings %\" PRIu64 \")\",\n+\t\t\t\t mbuf, sess_priv.sa_idx, res->compcode,\n+\t\t\t\t res->uc_compcode, warn_cnt);\n \t\tdesc.subtype = RTE_ETH_EVENT_IPSEC_UNKNOWN;\n \t\tbreak;\n \t}\n \n \tdesc.metadata = (uint64_t)priv->userdata;\n \trte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_IPSEC, &desc);\n-\trte_pktmbuf_free(mbuf);\n+\tcnxk_pktmbuf_free_no_cache(mbuf);\n }\n \n static int\n", "prefixes": [ "v2", "15/21" ] }