Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108047,
    "url": "https://patches.dpdk.org/api/patches/108047/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com",
    "date": "2022-02-22T18:18:14",
    "name": "[16/20] net/sfc: fix a memory leak in error handling",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "7d8bb333ae037285143ccbe034f4bd043c98546c",
    "submitter": {
        "id": 2458,
        "url": "https://patches.dpdk.org/api/people/2458/?format=api",
        "name": "Weiguo Li",
        "email": "liwg06@foxmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com/mbox/",
    "series": [
        {
            "id": 21799,
            "url": "https://patches.dpdk.org/api/series/21799/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799",
            "date": "2022-02-22T18:17:58",
            "name": "fix memory leaks in error handling",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/21799/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/108047/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/108047/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CCAE8A034E;\n\tTue, 22 Feb 2022 19:20:22 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2929941C27;\n\tTue, 22 Feb 2022 19:19:35 +0100 (CET)",
            "from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com\n [203.205.221.233])\n by mails.dpdk.org (Postfix) with ESMTP id E57BF40DF6\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:19:31 +0100 (CET)",
            "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553965;\n bh=Fct4t/z/07DfWsYeJvTHuJ9oWM8lG9O3VECwOFSzB5o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=W/Ayvq7J3Su76vAOAbvHFkBSX2HKDLhVsPZQt8FBCOBb4mfKizdkmuqjgWCL2aJNP\n 7wqhUQ+UvfWTKfDAaWQZLTcEEa8uC1mXeu5CuQv8Nhutyiix9hbb2ZfQuOuQlEijc2\n c/drbV9BaFyBQ+oPcPOdOL/P1X/ob09mXKj1422Y=",
        "X-QQ-mid": "xmsmtpt1645553961t7df7kpia",
        "Message-ID": "<tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com>",
        "X-QQ-XMAILINFO": "M1xqn9pGP6LNPjui4LppxAp/CE39U3eilBtkieK4+w4YlAwrUTEEhuTy8dJ/zG\n D+UbSD9othT0r+SafeUGmipvCi5KX9uh2hZW8rda57V8G+j6+7wsUq6H0M8Twq/dC9LLYi3H41Sb\n 8URGJyvqekj14tCZZtsoImsZ/77lj2X9LSNxwjDtOqlfFPBDZW46kjS5R6PUFXmtXrJaSFsmvJXx\n QYp4zKV8SmFcN0WvpQ8ovdWdpX6y+09Y9im1QT2KB8Qk4x+fqFrPGTqNZPUYfh/blXQ7ue2JhwyM\n MjG41++pNn+5hWN5ICvtupSqvuUstxCRj/7cWBMg2SaNJy+LJjqf8NmZ8Tp55gk4AEQQfcOw388Q\n U8M8DsdVid9UtfaITPBUUG/VwiH8LOwH82F7nsfU6Gw0H5yRPfbzOdtXBFpjWy2vAV3ii42QA7Xr\n mxoRMNS6kVrPQOrwfWdUnBXyyxwYsbsKPEE6qAN8oIycqXIATf2VIQXqvykDtVZMOA9smw46j9tO\n vIexFgvq8Ca3o9bDgI6OKjTFso+yn1JRyWHjttOx8sv3cVbIKWGILSWU+9p+eHx3bzJVo7geo0vX\n TCAqnKY5s1AmZFATRlOcZk2qHkRnyVAvTQQ9N/EZT7iEsdr9cf0n9fnEqRRmcYCUZmNHixqKGwLf\n BSFouny2pxAEJ/3gtoqS0OYb9beWgiDJgJJXlfXoGGhZmmvbPRdxkRKi2xonLPHw5ppGiy+no0Rk\n 8ljA02QKbZ/247u0aOggn+xlHY4eudwpwLVS9ae2HU2KdOvfxU36+eUXvEvRahtBLuf2yYJtSEY4\n auMNAHjbeJhl/ZJyO4hXfJSA4nWZ7nHLwSyopyQRewMKlDKJ0a+m9dmITDLyWZhBxoDQXNLoY+PE\n y6UXKyk6R9nmyJCn3D8qo=",
        "From": "Weiguo Li <liwg06@foxmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com",
        "Subject": "[PATCH 16/20] net/sfc: fix a memory leak in error handling",
        "Date": "Wed, 23 Feb 2022 02:18:14 +0800",
        "X-OQ-MSGID": "\n <f2049c21d9fe14ebe435c07ae0102195110aac11.1645551559.git.liwg06@foxmail.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>",
        "References": "<cover.1645551559.git.liwg06@foxmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When efx_nic_get_board_info() failed then function return, the\nmemory in 'id' is not released, this leads to a memory leak.\n\nFixes: e86b48aa46d4 (\"net/sfc: add HW switch ID helpers\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/net/sfc/sfc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c\nindex 51726d229b..ad1683a512 100644\n--- a/drivers/net/sfc/sfc.c\n+++ b/drivers/net/sfc/sfc.c\n@@ -1423,8 +1423,10 @@ sfc_hw_switch_id_init(struct sfc_adapter *sa,\n \t\treturn ENOMEM;\n \n \trc = efx_nic_get_board_info(sa->nic, &board_info);\n-\tif (rc != 0)\n+\tif (rc != 0) {\n+\t\trte_free(id);\n \t\treturn rc;\n+\t}\n \n \tmemcpy(id->board_sn, board_info.enbi_serial, sizeof(id->board_sn));\n \n",
    "prefixes": [
        "16/20"
    ]
}