Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108041/?format=api
{ "id": 108041, "url": "https://patches.dpdk.org/api/patches/108041/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_2D910911DF98291EA953A388461D9BEFFE07@qq.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_2D910911DF98291EA953A388461D9BEFFE07@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_2D910911DF98291EA953A388461D9BEFFE07@qq.com", "date": "2022-02-22T18:18:08", "name": "[10/20] net/failsafe: fix a memory leak in error handling", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "85143520d855d3c405dd58cb1ead17f3ad0ab197", "submitter": { "id": 2458, "url": "https://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_2D910911DF98291EA953A388461D9BEFFE07@qq.com/mbox/", "series": [ { "id": 21799, "url": "https://patches.dpdk.org/api/series/21799/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799", "date": "2022-02-22T18:17:58", "name": "fix memory leaks in error handling", "version": 1, "mbox": "https://patches.dpdk.org/series/21799/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108041/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/108041/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC8CBA034E;\n\tTue, 22 Feb 2022 19:19:44 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A29E5411DB;\n\tTue, 22 Feb 2022 19:19:12 +0100 (CET)", "from out203-205-251-82.mail.qq.com (out203-205-251-82.mail.qq.com\n [203.205.251.82])\n by mails.dpdk.org (Postfix) with ESMTP id DFC96411CB\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:19:10 +0100 (CET)", "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553944;\n bh=iQkeHM3yZV1xBLxhT3xXyuEjGvFRaoupb6q9Gs40vgI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=h3kg4kTUjFJAgXOdlJlOW+CSVV71ZXySgsaBoxFgxAR54ksMiyJW4A4Rjm/ctgh2B\n TWjrahvlIh/ocoEAnKlqnYftz3ytgd5iUb1S0jqYirLZ9CRBhVjWeuXw6zu6P1kT85\n FGxx1DZxDKT6/xE9sR8+MhGLgLVAtkAms+FOLg+g=", "X-QQ-mid": "xmsmtpt1645553940tx4dp7kae", "Message-ID": "<tencent_2D910911DF98291EA953A388461D9BEFFE07@qq.com>", "X-QQ-XMAILINFO": "Nwz8Cs33/LprsdqqqVMBtVZloJLxwJEstFF4ba7QnxdC6BJfSjFcLUc8NKF6tF\n ydYlOhzFoSf3g1tHX+E1538cf7APFE3BnxULrtB9C77g8r3UrluDuAXW/D55uO+y0sgP+Zzg13x8\n 7rLWJghFYxKlNyBu6h+qCql78fNOAIfYjO/SFFM6tT2U8JdhAfaJX1o8Z6xNr3bGRMCTcqxadiaK\n fMwsSDn8bb12nb75hgA+S1iPW6u6lDn/1tHrocp2ygsdh/cAyfCp28wFOmjfWQsBy53xGDzK6vRC\n 102PE8geXPkxpTLBLocrmBbmJ8x/kaBMpeZYph1RfZ2SyhviLNdJtbRTwLD3QkhPXLWlrQNcVw2f\n 0J5ew+mwuv6viL0RUWMhRSE204gTQ+A7r4ZwxwaSOA1z0yHoVyvRd/vGTrG3LZvK7cZ2HjrKYWEG\n X8f8rOsAD6yIRNGZltxb0m/4Prf/iYSJocoQkyKVXnd2q4pocIHroH0qi5lMiwgBDRWI+//StNgR\n Lnm8MavL90zlMxPFnzk5G6MSwJ4y+fFACUF2hy8mTkRaUjvqPNYdkIDv4IaJNOj+fmzgsF+2wgvm\n 2Ae0NpEORIa5wPE0K1X4XKTmoq0K8pHPZU/xVYqP5B4IJLipqcaqf5c+2lr1gwm3/+91BHa73IlR\n VS4+vYONI1amJGTuZaSwyGj7EMYiWUTC9Ig9DYNmUayesNc5MQMRx6rDGBV7/cyyLm54sCSf8CWF\n YdHENx+B1y4jf8rV7UVySCVaZfqoq3b1qYsA9mgDiG7QpZtuDwQEFl6nPx2687gnuH7MUlk9Ix93\n bshSAyKAGWNTEVvCPp7eC9APauVM9pyQdHMOiu0IJe1PpcTMd+k9spjUNEHVwQElOmpoUsFjikOC\n KiH0CJKxLuBL5hYJ2eBg+HFrrCHu5eCQ==", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "dev@dpdk.org", "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com", "Subject": "[PATCH 10/20] net/failsafe: fix a memory leak in error handling", "Date": "Wed, 23 Feb 2022 02:18:08 +0800", "X-OQ-MSGID": "\n <1667cbd78444bb38f61339fde94a6c995a34a467.1645551559.git.liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>", "References": "<cover.1645551559.git.liwg06@foxmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When failed at 'rte_intr_efd_enable()', function returned and 'rxq' is\nnot freed. So free 'rxq' in error handling to avoid a memory leak. We\ncan't not use 'goto free_rxq' instead since 'rxq' has not assigned to\n'dev->data->rx_queues[rx_queue_id]', thus 'fs_rx_queue_release(dev,...)'\nwill not work in this case.\n\nFixes: 9e0360aebf236d (\"net/failsafe: register as Rx interrupt mode\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/net/failsafe/failsafe_ops.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 55e21d635c..4d4e2b248f 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -444,6 +444,7 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,\n \trxq->sdev = PRIV(dev)->subs;\n \tret = rte_intr_efd_enable(intr_handle, 1);\n \tif (ret < 0) {\n+\t\trte_free(rxq);\n \t\tfs_unlock(dev, 0);\n \t\treturn ret;\n \t}\n", "prefixes": [ "10/20" ] }