Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108039,
    "url": "https://patches.dpdk.org/api/patches/108039/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_EBBE8747EE443C62B079A24E7922F674A609@qq.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_EBBE8747EE443C62B079A24E7922F674A609@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_EBBE8747EE443C62B079A24E7922F674A609@qq.com",
    "date": "2022-02-22T18:18:07",
    "name": "[09/20] net/dpaa: fix a memory leak when validation fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "e84537cb54193bcfc0011ffe93e91b99c4a830e3",
    "submitter": {
        "id": 2458,
        "url": "https://patches.dpdk.org/api/people/2458/?format=api",
        "name": "Weiguo Li",
        "email": "liwg06@foxmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_EBBE8747EE443C62B079A24E7922F674A609@qq.com/mbox/",
    "series": [
        {
            "id": 21799,
            "url": "https://patches.dpdk.org/api/series/21799/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799",
            "date": "2022-02-22T18:17:58",
            "name": "fix memory leaks in error handling",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/21799/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/108039/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/108039/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 518BEA034E;\n\tTue, 22 Feb 2022 19:19:31 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A089640E64;\n\tTue, 22 Feb 2022 19:19:05 +0100 (CET)",
            "from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com\n [203.205.221.192])\n by mails.dpdk.org (Postfix) with ESMTP id E403940DF4\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:19:02 +0100 (CET)",
            "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553940;\n bh=R5pjihnX2RnKoFmdFZEKF/Y8vJaUyHZVgzXPwYDz8Vk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=Lt4Fd/VKyt7aFS+y9XGGWIBs3V+1zuxd8g5DVg6QIiPbVBnWg+Yo5IJ7XMLMPkAMa\n BkAb+6Nsw3PBuWuvidhIML/7g4oBZtLxqcWu0KKznqxJzipWOPs0pYuWPkdItNqMed\n vTjo4o9M0dWwtaAvp2HIGKqlx10koLvo4yjnlz4s=",
        "X-QQ-mid": "xmsmtpt1645553936tkv0smi68",
        "Message-ID": "<tencent_EBBE8747EE443C62B079A24E7922F674A609@qq.com>",
        "X-QQ-XMAILINFO": "MX+1SEN3H+wA5JwU9mjAHdk9KvlWT6ujPrE44FvCuWgeCDA2W4MQRYJ+buJLVi\n zrqnBrFsUx5lnRB5LSyxw165i2KHAXrJqm58WtHDea4E75U4pqRR8uv7qqCicGl0T1/9SZRwQiue\n 03dlHHXkbfCK3iyLfjNpx5Jed3JPracufhxtAJtj1B/SPCc2DTY0bIsEfHHp8xZ+qPsqWoJfxSDs\n Gz0SjLyG7x3iSNQ69ZfHT3GCsYAw/3G9xB9klo80TT/PKQYht0ChrXUDpM4MwVc8+8RSsTmUGZRa\n Cx2fBFP9q6huyMC0J4LbnIqS0/tDM+SpM7MwJ9qCk4h/4/ZAZnik7TqXisvYJPBcWas7nDuXtqXp\n 2zJLwu8BAmZtBJHqf0cuW7IKy4iNOy9+KMn8XhNWNJ7/2lpqJ0Dwx2kk3dnCQFAauKEv3XmTU5D3\n rTP3Ztf1/g/tv1q4o91siVM/qQGQ++nFYq/SIIa26j+u5vT9O2/Bsn3qmiJPVPxwSRbRWcBbJOE4\n IwGtfjEuK+4qkzfQV4KCXUUZtvbmgJBwJRHdgaJVRKe+I6BaojiElbiHEkeE4INcecqpO58LiVDe\n r2cmPrTnU5QV7ivu3xjXL+k92jov9QqDAOyCKmdbjeed/4jo2pJ0m9QoUivblmu/T+MLquzs6Li+\n NUiR3E9abSg/j/et15hEOA2am6B1Q/ec+k3ntEkBbWZmGAqi2TmdYIqmOQRG98ZgeMYIm5OdIU+s\n ycYiYdjBFZDzENLz1EvBLKKObgIpoUfKZq36CuQmbqZgBypoJ7WUzn0rwvWDkUDMeBT84TxG8wS+\n lQrTdkZ3BzQ4FhJtDP7SOed/GlXh6QvrOXjsq0alswRgk2TCQW3xXueL72qIz3jRV+esdCR6FySi\n LklhwKV79I8CQpwYoHQoY=",
        "From": "Weiguo Li <liwg06@foxmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com",
        "Subject": "[PATCH 09/20] net/dpaa: fix a memory leak when validation fail",
        "Date": "Wed, 23 Feb 2022 02:18:07 +0800",
        "X-OQ-MSGID": "\n <d69b4cd0b75b115b8f4b41d462a848cf10e4ca0b.1645551559.git.liwg06@foxmail.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>",
        "References": "<cover.1645551559.git.liwg06@foxmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When buf_len validations fails and return, the mbuf is not freed\nwhich caused a memory leak.\n\nFixes: 8cffdcbe85aa (\"net/dpaa: support scattered Rx\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/net/dpaa/dpaa_rxtx.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 956fe946fa..f66d975969 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -810,6 +810,7 @@ dpaa_eth_mbuf_to_sg_fd(struct rte_mbuf *mbuf,\n \t}\n \tif (temp->buf_len < ((mbuf->nb_segs * sizeof(struct qm_sg_entry))\n \t\t\t\t+ temp->data_off)) {\n+\t\trte_pktmbuf_free(temp);\n \t\tDPAA_PMD_ERR(\"Insufficient space in mbuf for SG entries\");\n \t\treturn -1;\n \t}\n",
    "prefixes": [
        "09/20"
    ]
}