Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108035,
    "url": "https://patches.dpdk.org/api/patches/108035/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_C00C29CFCE294484B48EE1F7DB089F485106@qq.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_C00C29CFCE294484B48EE1F7DB089F485106@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_C00C29CFCE294484B48EE1F7DB089F485106@qq.com",
    "date": "2022-02-22T18:18:03",
    "name": "[05/20] net/bnxt: fix a memory leak in error handling",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "59a41319839e5ddec536c0c0ed9b11858cbe2626",
    "submitter": {
        "id": 2458,
        "url": "https://patches.dpdk.org/api/people/2458/?format=api",
        "name": "Weiguo Li",
        "email": "liwg06@foxmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_C00C29CFCE294484B48EE1F7DB089F485106@qq.com/mbox/",
    "series": [
        {
            "id": 21799,
            "url": "https://patches.dpdk.org/api/series/21799/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799",
            "date": "2022-02-22T18:17:58",
            "name": "fix memory leaks in error handling",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/21799/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/108035/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/108035/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04328A034E;\n\tTue, 22 Feb 2022 19:19:06 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F125C4116E;\n\tTue, 22 Feb 2022 19:18:49 +0100 (CET)",
            "from out203-205-221-191.mail.qq.com (out203-205-221-191.mail.qq.com\n [203.205.221.191])\n by mails.dpdk.org (Postfix) with ESMTP id 289FE4116D\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:18:47 +0100 (CET)",
            "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553926;\n bh=jMo7bxp26KKCY8jhxVwS9kR377l9jqJbp7bGJGORCgk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=aKLiV/Ux87hnpSk3cFV7lZa8/tkSD5V9w0ZfnCmOuO3tomwPYzAT6aEWpcjHpf9Jp\n FXSpBSt5IUOQITEjswyPc2sBth/SCOqYh9Mb/qQ0tnkH+/GIc20OWg1T8Pil/eHiGk\n ClNsBXPGw/bLA0jhjV2H59UUc27yqz/IZr5ka2GE=",
        "X-QQ-mid": "xmsmtpt1645553922to2fenu88",
        "Message-ID": "<tencent_C00C29CFCE294484B48EE1F7DB089F485106@qq.com>",
        "X-QQ-XMAILINFO": "OE2SNMSfMbmOQgxrkAJK7JbaZ4UGc0rBdMVPb4CefpsHrHtzCCgqMaxDf/pkP3\n Dr1ymtnuupywwtPUnitphuC83CY5e9hcF2UUkXWZc5k03xAnQwvh3TlJUusrdPiuxM1vkX0TcNv/\n 7VvOsRNWytCH1jwRCQR7AWUaawuHiA2n/lw5gfuJzanfWtDpg6eceCJkxUvPQ5oJ/Yg49FwMPPWi\n qL12k9R/FJPVcrwJks5gC5e43RkaOOH9u7sbQMuTNFVHbevPxOoWESMCWD7QGz9A7sBn0laWMPOA\n YN9ZtEeVE1IxN73tv4gvi6KzPn/3DA4JUDdzQmcJmL03Sn574JMA3IM4aiYxPf21kc2PJbZU4N8b\n r08U2AzcDeBNxRZoKpx44Fwg3k2NQKtYUP/XAvgYfxqIjwF/1RCYEZukZCJ5pDFgBBOIoib6IMy9\n nLu7m1Rb/qRTDkOoj7gV00BsztJ1PJDrrVtiKyQFkQnIDgyeZjKxjikPxbxOz+4E81qjAvRu4oiF\n oU15yJChBGZq+caknTTRWXKitl3PLhpglT9kiYeaQLtqd+gscBTD6KbDAVFr2N6s/9MYHjNCzRuz\n D9UfZ2PSdoQ1Q/e154v51o01Nt+wjYgb2jGb8pdiX44Cvt4Jcs5Yktpf05L73nTGj2r74aRrcPC0\n k5Abw9NCzo/tLZ3DFWIQfrwDBB5hj8BfSuODxM2KGFXY5Mt/L7gz5DI2mBMXBC+BxoLS+I5U6zZy\n /MJgu/Er0sPaMu3lzZMTU+XLeFe1FHA+I1K/e9COabyiXNmizJNeEQAQYjgZYr9+K9W0qJukr8F3\n CcNrDgwwIqpR8PFehJpN/oUe50ySXnbdks3TO3TTBz1KB/NW8srT1LRcnZWQWhliSZZpscIqFW9U\n 3XLXGSeetIaN5i4cVdh2nDMJ/7p5hRqA==",
        "From": "Weiguo Li <liwg06@foxmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com",
        "Subject": "[PATCH 05/20] net/bnxt: fix a memory leak in error handling",
        "Date": "Wed, 23 Feb 2022 02:18:03 +0800",
        "X-OQ-MSGID": "\n <a633cf8304cbf294f33e2f9f1b6f683721aa4119.1645551559.git.liwg06@foxmail.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>",
        "References": "<cover.1645551559.git.liwg06@foxmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When run goto from this branch, the 'ulp_fc_info' has not set into\nthe context yet, so ulp_fc_mgr_deinit(ctxt) in the error label can\nnot release 'ulp_fc_info' in this case which cause a memory leak.\n\nFixes: 9cf9c8385df7 (\"net/bnxt: add ULP flow counter manager\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\nindex 85c9cbb7f2..b055463ea4 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n@@ -86,6 +86,7 @@ ulp_fc_mgr_init(struct bnxt_ulp_context *ctxt)\n \n \trc = pthread_mutex_init(&ulp_fc_info->fc_lock, NULL);\n \tif (rc) {\n+\t\trte_free(ulp_fc_info);\n \t\tPMD_DRV_LOG(ERR, \"Failed to initialize fc mutex\\n\");\n \t\tgoto error;\n \t}\n",
    "prefixes": [
        "05/20"
    ]
}