Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108033,
    "url": "https://patches.dpdk.org/api/patches/108033/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_301A1EB7D3F9082E1DAC6F9B111091899807@qq.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_301A1EB7D3F9082E1DAC6F9B111091899807@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_301A1EB7D3F9082E1DAC6F9B111091899807@qq.com",
    "date": "2022-02-22T18:18:01",
    "name": "[03/20] crypto/dpaa2_sec: fix memory leaks in error handlings",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "899152cf17d4956046576098e42d76ede97c5502",
    "submitter": {
        "id": 2458,
        "url": "https://patches.dpdk.org/api/people/2458/?format=api",
        "name": "Weiguo Li",
        "email": "liwg06@foxmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_301A1EB7D3F9082E1DAC6F9B111091899807@qq.com/mbox/",
    "series": [
        {
            "id": 21799,
            "url": "https://patches.dpdk.org/api/series/21799/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799",
            "date": "2022-02-22T18:17:58",
            "name": "fix memory leaks in error handling",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/21799/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/108033/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/108033/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1938A034E;\n\tTue, 22 Feb 2022 19:18:52 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5472C4115D;\n\tTue, 22 Feb 2022 19:18:44 +0100 (CET)",
            "from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com\n [203.205.221.192])\n by mails.dpdk.org (Postfix) with ESMTP id 4491E41151\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:18:40 +0100 (CET)",
            "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553919;\n bh=SxTbALdmkFJJ5so20iB17BPhK/GAFWaxv5TFPABCRRY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=OfxN0utmt39DYwwzLXWM7vDOC04c8bQig5/B+Xum1RuQilueGjqAAYir+520ttDuz\n qkwurLf7K1Ty4Ra0EZE47s0onwjIWPez9eBKVZqiTBZWg4OBlS8+gb0K1qrb6nh+F2\n 2Te3IQWA2G00AUdFQP9tUfbLkaxKDd2Musb48Lpo=",
        "X-QQ-mid": "xmsmtpt1645553915tdmu863dm",
        "Message-ID": "<tencent_301A1EB7D3F9082E1DAC6F9B111091899807@qq.com>",
        "X-QQ-XMAILINFO": "NFNrK8KlcSCRbUxslsI/YyyJPNrZRnRRM6ACClCUtbnl94lUi4m/j916j7SPE2\n UC/vH+UOWfmDtbWdDR0fND8FNC2LfSSCT8wbSjECl0ZUDkoJrdT/h4UPpHIDroQPmKyuzMTbVr4E\n 7gE1H38YveQWrsRPoak6VJbpymScw0g8sjkqcFrsdXBDFfBgMkNL9w/ii79k2HYM52IC1EILrWkU\n fL+cA6xz2b6rPS/flAhzJMXarw99JPRt4XkWQ8ip4YreTIllaXomgdVAjUAmfms4biCaFNPVlcQe\n mYhUATZdlJbCkJ3WgZZIesSk1a/S+rkDzaLpYROtcpazDEdV7oTwxHIdTW67Rdbur1cBHPr7seOk\n foFcElDWb1frbEbb2eaDz71xd+SzgIAQKsbVsI1F1nGSjNzL+lVeSiwJnrmjMTOqpt8++m8KS73N\n ujgPOjQOBX0U1wuiJ7STZTUL9sKdEWuao25N8IFRzP3tTCG3XFia8ToBu3GqN0OfenjJhPihZS4C\n SfQLy14kWpPOI42y1XyZjSHWkL86x3tyq595mOFJq1uzUwCZb9tk6SsVDfGnEokzfUi9uJN9Awxq\n 7mTlMKMhKhmDHkCwj7pXGDAaVNeYE6+TwuUoEf2deCZGqI3SrJvv3egIdPpr3o2AGnOcKJejUzT6\n IKzztR6vV4XIKlzBDcuDCxEH0zJj1zHDRVFNfBooCc8gBCOlGMz3gPTwePMtXSVuQoe+EYpUyQMu\n xHUedaJovkggPaHh2ij1IIBHVcAd4JsGArlHkjWxJAzkhlTzY0T58zFI56RkNMQWuUO8YVZJn3Qh\n QoxY+i+AXegHtixcKyGpu0JEgRo4Z4+pa7sFXJ/VXy8VMNlL+3goeOjGWwSnVgwvMurli2eWEzVf\n PkK+eCVSVxqxEwTZrPg0U=",
        "From": "Weiguo Li <liwg06@foxmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com",
        "Subject": "[PATCH 03/20] crypto/dpaa2_sec: fix memory leaks in error handlings",
        "Date": "Wed, 23 Feb 2022 02:18:01 +0800",
        "X-OQ-MSGID": "\n <e1578dc3baeab9ace55c99896486c309e6fbfa8a.1645551559.git.liwg06@foxmail.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>",
        "References": "<cover.1645551559.git.liwg06@foxmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When function returned from error handling branches, the memories were\nnot freed which caused a memory leak.\n\nFixes: 8d1f3a5d751b (\"crypto/dpaa2_sec: support crypto operation\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex e62d04852b..3f8d4d213f 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -2037,12 +2037,15 @@ dpaa2_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t\tRTE_CACHE_LINE_SIZE);\n \tif (!qp->rx_vq.q_storage) {\n \t\tDPAA2_SEC_ERR(\"malloc failed for q_storage\");\n+\t\trte_free(qp);\n \t\treturn -ENOMEM;\n \t}\n \tmemset(qp->rx_vq.q_storage, 0, sizeof(struct queue_storage_info_t));\n \n \tif (dpaa2_alloc_dq_storage(qp->rx_vq.q_storage)) {\n \t\tDPAA2_SEC_ERR(\"Unable to allocate dequeue storage\");\n+\t\trte_free(qp->rx_vq.q_storage);\n+\t\trte_free(qp);\n \t\treturn -ENOMEM;\n \t}\n \n",
    "prefixes": [
        "03/20"
    ]
}