Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108032,
    "url": "https://patches.dpdk.org/api/patches/108032/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/tencent_AF91CA18349EF7D3F308719DA86F95915D07@qq.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_AF91CA18349EF7D3F308719DA86F95915D07@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_AF91CA18349EF7D3F308719DA86F95915D07@qq.com",
    "date": "2022-02-22T18:18:00",
    "name": "[02/20] common/dpaax: fix a memory leak in iterate dir",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "74f9dac5c6923c8f03ce7685c91b325f487b7737",
    "submitter": {
        "id": 2458,
        "url": "https://patches.dpdk.org/api/people/2458/?format=api",
        "name": "Weiguo Li",
        "email": "liwg06@foxmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/tencent_AF91CA18349EF7D3F308719DA86F95915D07@qq.com/mbox/",
    "series": [
        {
            "id": 21799,
            "url": "https://patches.dpdk.org/api/series/21799/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21799",
            "date": "2022-02-22T18:17:58",
            "name": "fix memory leaks in error handling",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/21799/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/108032/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/108032/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9865AA034E;\n\tTue, 22 Feb 2022 19:18:46 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 718B341151;\n\tTue, 22 Feb 2022 19:18:42 +0100 (CET)",
            "from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com\n [203.205.221.210])\n by mails.dpdk.org (Postfix) with ESMTP id CFFC741151\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:18:38 +0100 (CET)",
            "from localhost.localdomain ([111.193.130.237])\n by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP\n id 49223207; Wed, 23 Feb 2022 02:18:18 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1645553916;\n bh=DwAvKDADkVs7IE7mcF2IcClCGLFw4Vxp4OYIJLQm0ok=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=ETjQZWaJHAOAi+9b16GK8D4jEWSiofEHVZ1S5t6S+Ca3qI47G9OY0jh2ELo4IJ9rt\n OsgGX3+yZN/aLLtc4gIy5x0uASZ3gM6YuHcnd1iy3j4FpaC1USTj/GEkNBvxAPDKvL\n GQZSvCtgSoZuRMMYGs1jjNRN1eTsd34ON+yGOUDE=",
        "X-QQ-mid": "xmsmtpt1645553911t0ea8ce31",
        "Message-ID": "<tencent_AF91CA18349EF7D3F308719DA86F95915D07@qq.com>",
        "X-QQ-XMAILINFO": "N0opbxSOYLeWeBduHNMesvvziNPlPlQrGZXPoJHEFVsV5z5qKmUgf7FxBx8Xek\n zFC58AgK/moYF5cAE/5FXwyMWmbwUx9sGKycxJLBrZvXHjPdTT9z6nMXxJt94SsnUy7KEXWpr0UR\n PM0RozGvAs7ZXhfbjS8TlHJsLY93nvPKgyYk1gawnLnvcFyzx4D/6smGA6g+Bj+MMS88mc9E8tim\n DLjbEgNq77VvFzod9any9AULF3ZZw1ls4QsLGkq2uu/uI4L/VuK1nVunFXj+M2paCPW20Q8IHfwp\n +zq7ciiPl6IybDlc0qviTRSu2NYbSPlJBs/4FlDjmF7FFDrsE1sOf0ZkcVep3Olqdy2kNtq1E71V\n F3FqjH9+aIUZsoCbUa4AyWPd1ejaMhVgJYYpByEuXoYmX4ukRvb16d2BdASZGA7p6ik9xsvNkdzc\n yuNb/jRQ3fP/8qgjNNqAj1XUfMjzW+SM3gEp4/zQmzJIgWuPGT1QHedrehIMTNPrWOOkHiZY4J3o\n XCMhy66hgj4JPl3657b36ZfoONYZw3sEGKUirRe2f7OOqi78K+2e3lvvVW2GauWZ+jw55wmxacBt\n vklpDd/UoaLVdnKislZd9Bj+1hOqq1ZVfRikKty3ehxxwUnljsPKcwkLn0ygglbGUM0c7f4mYHpm\n YI/D06ro+hvhnzC2+5XRO0HggXxyMdrOQdObn6WFwsZRjvniFJRqR5I6HjfyvfOQLPkP5uYVqcUv\n SbLD4mvmHK34BPlxTbY7DKB1BUN9Ubq3Lc8vFC8yus0beYH92XninFNyCTmMEsmGDI+nGYOiXbVp\n Dv3VREW5CFPwpbEaa/UhTGV0TviEgZ86lefrH3TbwngDyFqGaAYY56Le0y/HZVgLR+1aux/fQg+Q\n ==",
        "From": "Weiguo Li <liwg06@foxmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,\n bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,\n hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,\n simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,\n shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,\n kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,\n declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com",
        "Subject": "[PATCH 02/20] common/dpaax: fix a memory leak in iterate dir",
        "Date": "Wed, 23 Feb 2022 02:18:00 +0800",
        "X-OQ-MSGID": "\n <8a17d8a3d16cf860a62a48782da19cb78fc27853.1645551559.git.liwg06@foxmail.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<cover.1645551559.git.liwg06@foxmail.com>",
        "References": "<cover.1645551559.git.liwg06@foxmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When process_dir() fails, the memory to 'subdir' was not freed which\ncaused a memory leak.\n\nFixes: 2183c6f69d7e (\"bus/dpaa: add OF parser for device scanning\")\n\nSigned-off-by: Weiguo Li <liwg06@foxmail.com>\n---\n drivers/common/dpaax/dpaa_of.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/common/dpaax/dpaa_of.c b/drivers/common/dpaax/dpaa_of.c\nindex bb2c8fc66b..a827b42efa 100644\n--- a/drivers/common/dpaax/dpaa_of.c\n+++ b/drivers/common/dpaax/dpaa_of.c\n@@ -126,8 +126,10 @@ iterate_dir(struct dirent **d, int num, struct dt_dir *dt)\n \t\t\t\t d[loop]->d_name);\n \t\t\tsubdir->parent = dt;\n \t\t\tret = process_dir(subdir->node.node.full_name, subdir);\n-\t\t\tif (ret)\n+\t\t\tif (ret) {\n+\t\t\t\tfree(subdir);\n \t\t\t\treturn ret;\n+\t\t\t}\n \t\t\tlist_add_tail(&subdir->node.list, &dt->subdirs);\n \t\t\tbreak;\n \t\tdefault:\n",
    "prefixes": [
        "02/20"
    ]
}