Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108021/?format=api
{ "id": 108021, "url": "https://patches.dpdk.org/api/patches/108021/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220222181146.28882-14-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222181146.28882-14-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222181146.28882-14-mk@semihalf.com", "date": "2022-02-22T18:11:38", "name": "[v2,13/21] net/ena: expose Tx cleanup function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4d6e45fc7529a78d76c883e7fa7156d1b4a4288c", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220222181146.28882-14-mk@semihalf.com/mbox/", "series": [ { "id": 21798, "url": "https://patches.dpdk.org/api/series/21798/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21798", "date": "2022-02-22T18:11:25", "name": "net/ena: v2.6.0 driver update", "version": 2, "mbox": "https://patches.dpdk.org/series/21798/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/108021/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/108021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 609A7A034E;\n\tTue, 22 Feb 2022 19:13:37 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E09141203;\n\tTue, 22 Feb 2022 19:12:32 +0100 (CET)", "from mail-ej1-f54.google.com (mail-ej1-f54.google.com\n [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id 5E389411DB\n for <dev@dpdk.org>; Tue, 22 Feb 2022 19:12:31 +0100 (CET)", "by mail-ej1-f54.google.com with SMTP id d10so45435279eje.10\n for <dev@dpdk.org>; Tue, 22 Feb 2022 10:12:31 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id y21sm10610153eda.38.2022.02.22.10.12.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 22 Feb 2022 10:12:30 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=mDhQnzFWHG4t0egd6mvppeslz6lKUKkj8/9ZbLux+YI=;\n b=KyMHbrZaQrg+XKMlrnGbM33TWVxzBqkar0NsAkmLX7/l0RH/2dcKx8+g2/5mzF8IWy\n pS4rUdjWiACdfcScr6lExK2WElxlwrlWqMYPrZ4RL+T7fmJGKcs0mmK1QoffsZBhI0hr\n vxnTQh7rDJDjQzs31csis0zp7t4MjDniw1ZL0KIkB73Q7oJ3KMVLdL5+D+PB/qLijsv2\n 9ayXsK0bRgPc1dItfIXX34Fgfbr2Ezq748deY0ZCbUYKs1iaHlCh3Jwlxoj9zbDkgxVR\n cqSFQekGdXztw6f233u6ie5A70fdYk0y2u84o4dlVCKxLq0iJ11U9YmVTBUln75T3RvR\n RzWA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=mDhQnzFWHG4t0egd6mvppeslz6lKUKkj8/9ZbLux+YI=;\n b=4Sj6R5GkeDk/Yh0oExKaNTbbd1wUWIEMcAm4PFCkFmkoM8ThAG/+I8Mrh70weqhURk\n 6xdonq+/5o2HUWCAAxntuB4IBl57c1p2OuAhrViCCpDlmH1x8GUgNvSDrKAthGSRrmTH\n +D6jCnct7n3Y4EjqLc8v1qQI1wf8I3hqCIvQGCJc11qSwE9fPc+MU8S+siULW6fMh+2I\n RRcuXFPu3IkyZEAVLe1QpiaPmBcaVDhgcnBXd2IfDPd0JvNxbB56OBTTEuVK48kZ3ZSO\n IGGODs8x4qVXLcqmcdsO37+t1hGZtbEaOCuGUyrAhSE1p94ZcJImq8grWKmEis8pV5cx\n egKA==", "X-Gm-Message-State": "AOAM533npfY6FiggY+FqJyjBRThliEqsK5pDIhGOmQzYM6sClLxE9upi\n /BXAkTzn8DnFlBfYC47qugQhBWU3F7XYlQ==", "X-Google-Smtp-Source": "\n ABdhPJzwQNxGIJ4uJlaJCcA5FNBly8OAvzQdKE6gMukRBgmtdvzFc7SPVr3dmoP36Pb/U4NnwjKfdg==", "X-Received": "by 2002:a17:906:cc8d:b0:6c9:6df1:7c55 with SMTP id\n oq13-20020a170906cc8d00b006c96df17c55mr20050979ejb.317.1645553550760;\n Tue, 22 Feb 2022 10:12:30 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "shaibran@amazon.com, upstream@semihalf.com,\n Dawid Gorecki <dgr@semihalf.com>, Michal Krawczyk <mk@semihalf.com>", "Subject": "[PATCH v2 13/21] net/ena: expose Tx cleanup function", "Date": "Tue, 22 Feb 2022 19:11:38 +0100", "Message-Id": "<20220222181146.28882-14-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220222181146.28882-1-mk@semihalf.com>", "References": "<20220222160634.24489-1-mk@semihalf.com>\n <20220222181146.28882-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Dawid Gorecki <dgr@semihalf.com>\n\nENA driver did not allow applications to call tx_cleanup. Freeing Tx\nmbufs was always done by the driver and it was not possible to manually\nrequest the driver to free mbufs.\n\nModify ena_tx_cleanup function to accept maximum number of packets to\nfree and return number of packets that was freed.\n\nSigned-off-by: Dawid Gorecki <dgr@semihalf.com>\nReviewed-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\n---\n doc/guides/nics/features/ena.ini | 1 +\n doc/guides/rel_notes/release_22_03.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 27 ++++++++++++++++++--------\n 3 files changed, 21 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/ena.ini b/doc/guides/nics/features/ena.ini\nindex 55690aaf5a..59c1ae85fa 100644\n--- a/doc/guides/nics/features/ena.ini\n+++ b/doc/guides/nics/features/ena.ini\n@@ -7,6 +7,7 @@\n Link status = Y\n Link status event = Y\n Rx interrupt = Y\n+Free Tx mbuf on demand = Y\n MTU update = Y\n Scattered Rx = Y\n TSO = Y\ndiff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst\nindex 92f36fa8ab..91324dae18 100644\n--- a/doc/guides/rel_notes/release_22_03.rst\n+++ b/doc/guides/rel_notes/release_22_03.rst\n@@ -114,6 +114,7 @@ New Features\n * Added support for the link status configuration.\n * Added optimized memcpy support for the ARM platforms.\n * Added ENA admin queue support for the MP applications.\n+ * Added free Tx mbuf on demand feature support.\n \n * **Updated Cisco enic driver.**\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 8f30718f2c..eecdd447dd 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -170,7 +170,7 @@ static void ena_tx_map_mbuf(struct ena_ring *tx_ring,\n \tvoid **push_header,\n \tuint16_t *header_len);\n static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf);\n-static void ena_tx_cleanup(struct ena_ring *tx_ring);\n+static int ena_tx_cleanup(void *txp, uint32_t free_pkt_cnt);\n static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n static uint16_t eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n@@ -276,6 +276,7 @@ static const struct eth_dev_ops ena_dev_ops = {\n \t.rx_queue_intr_disable = ena_rx_queue_intr_disable,\n \t.rss_hash_update = ena_rss_hash_update,\n \t.rss_hash_conf_get = ena_rss_hash_conf_get,\n+\t.tx_done_cleanup = ena_tx_cleanup,\n };\n \n /*********************************************************************\n@@ -2990,16 +2991,22 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)\n \treturn 0;\n }\n \n-static void ena_tx_cleanup(struct ena_ring *tx_ring)\n+static int ena_tx_cleanup(void *txp, uint32_t free_pkt_cnt)\n {\n+\tstruct ena_ring *tx_ring = (struct ena_ring *)txp;\n \tunsigned int total_tx_descs = 0;\n+\tunsigned int total_tx_pkts = 0;\n \tuint16_t cleanup_budget;\n \tuint16_t next_to_clean = tx_ring->next_to_clean;\n \n-\t/* Attempt to release all Tx descriptors (ring_size - 1 -> size_mask) */\n-\tcleanup_budget = tx_ring->size_mask;\n+\t/*\n+\t * If free_pkt_cnt is equal to 0, it means that the user requested\n+\t * full cleanup, so attempt to release all Tx descriptors\n+\t * (ring_size - 1 -> size_mask)\n+\t */\n+\tcleanup_budget = (free_pkt_cnt == 0) ? tx_ring->size_mask : free_pkt_cnt;\n \n-\twhile (likely(total_tx_descs < cleanup_budget)) {\n+\twhile (likely(total_tx_pkts < cleanup_budget)) {\n \t\tstruct rte_mbuf *mbuf;\n \t\tstruct ena_tx_buffer *tx_info;\n \t\tuint16_t req_id;\n@@ -3021,6 +3028,7 @@ static void ena_tx_cleanup(struct ena_ring *tx_ring)\n \t\ttx_ring->empty_tx_reqs[next_to_clean] = req_id;\n \n \t\ttotal_tx_descs += tx_info->tx_descs;\n+\t\ttotal_tx_pkts++;\n \n \t\t/* Put back descriptor to the ring for reuse */\n \t\tnext_to_clean = ENA_IDX_NEXT_MASKED(next_to_clean,\n@@ -3034,8 +3042,11 @@ static void ena_tx_cleanup(struct ena_ring *tx_ring)\n \t\tena_com_update_dev_comp_head(tx_ring->ena_com_io_cq);\n \t}\n \n-\t/* Notify completion handler that the cleanup was just called */\n-\ttx_ring->last_cleanup_ticks = rte_get_timer_cycles();\n+\t/* Notify completion handler that full cleanup was performed */\n+\tif (free_pkt_cnt == 0 || total_tx_pkts < cleanup_budget)\n+\t\ttx_ring->last_cleanup_ticks = rte_get_timer_cycles();\n+\n+\treturn total_tx_pkts;\n }\n \n static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n@@ -3056,7 +3067,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \tavailable_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq);\n \tif (available_desc < tx_ring->tx_free_thresh)\n-\t\tena_tx_cleanup(tx_ring);\n+\t\tena_tx_cleanup((void *)tx_ring, 0);\n \n \tfor (sent_idx = 0; sent_idx < nb_pkts; sent_idx++) {\n \t\tif (ena_xmit_mbuf(tx_ring, tx_pkts[sent_idx]))\n", "prefixes": [ "v2", "13/21" ] }