Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107952/?format=api
{ "id": 107952, "url": "https://patches.dpdk.org/api/patches/107952/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220222095451.731405-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220222095451.731405-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220222095451.731405-1-brian.dooley@intel.com", "date": "2022-02-22T09:54:51", "name": "[v2] crypto/virtio: fix out of bounds access bug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f4818c0313f074d28f33ddb2e7806d98b702c4e", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220222095451.731405-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 21786, "url": "https://patches.dpdk.org/api/series/21786/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21786", "date": "2022-02-22T09:54:51", "name": "[v2] crypto/virtio: fix out of bounds access bug", "version": 2, "mbox": "https://patches.dpdk.org/series/21786/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107952/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/107952/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C9D3A034E;\n\tTue, 22 Feb 2022 10:55:01 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E724840DF6;\n\tTue, 22 Feb 2022 10:55:00 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id C629640DF4;\n Tue, 22 Feb 2022 10:54:59 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Feb 2022 01:54:58 -0800", "from silpixa00400883.ir.intel.com ([10.243.23.143])\n by orsmga005.jf.intel.com with ESMTP; 22 Feb 2022 01:54:57 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1645523700; x=1677059700;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=xIevb3OmcwxE3SHK3MyO+yl7Ft1+H1yXNgyuepa7bsk=;\n b=YAmV3e+ywdf0nz7ZoMGwarredSg1vQXszgfhLnAuuVUb36HlQCt5ZqtF\n ECmRU0Psrb9ICAcaSyb5NrLqhoxklxXduWyt9IZQtQx1jBmUs9qFGRZtT\n yuQ4nHtmuURd2UTgUUUKjI7dOFMJJw5mpLsMO5kRsj90etwWKDzDaLjRK\n KeqpjX6rSjWDioNOASVBynXp1XClcl+ms2gehPppSzSzV5wEA6iFXzJEQ\n sxNGt2nD9fc3+3Hi9skp/P/qHfSlH+cos4SScjmUZdFrzBO/KAjKQWdCM\n pJJoi2JtUK0v+s08PbGzx/U7aeFIT0ZvnvjtVHV4WJeWVn/8o4GX6bsRZ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10265\"; a=\"338090247\"", "E=Sophos;i=\"5.88,387,1635231600\"; d=\"scan'208\";a=\"338090247\"", "E=Sophos;i=\"5.88,387,1635231600\"; d=\"scan'208\";a=\"706554276\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "dev@dpdk.org", "Cc": "Brian Dooley <brian.dooley@intel.com>, roy.fan.zhang@intel.com,\n stable@dpdk.org, Jay Zhou <jianjay.zhou@huawei.com>", "Subject": "[PATCH v2] crypto/virtio: fix out of bounds access bug", "Date": "Tue, 22 Feb 2022 09:54:51 +0000", "Message-Id": "<20220222095451.731405-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220221180542.439823-1-brian.dooley@intel.com>", "References": "<20220221180542.439823-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Coverity flags an untrusted loop bound. Check length of session iv.\n\nCoverity issue: 375802\n\nFixes: b063e843fa03 (\"crypto/virtio: fix IV physical address\")\nCc: roy.fan.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n\n---\nv2: Fix checkpatch warning\n---\n drivers/crypto/virtio/virtio_rxtx.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/crypto/virtio/virtio_rxtx.c b/drivers/crypto/virtio/virtio_rxtx.c\nindex a65524a306..08359b3a39 100644\n--- a/drivers/crypto/virtio/virtio_rxtx.c\n+++ b/drivers/crypto/virtio/virtio_rxtx.c\n@@ -264,6 +264,9 @@ virtqueue_crypto_sym_enqueue_xmit(\n \t\tif (cop->phys_addr)\n \t\t\tdesc[idx].addr = cop->phys_addr + session->iv.offset;\n \t\telse {\n+\t\t\tif (session->iv.length > VIRTIO_CRYPTO_MAX_IV_SIZE)\n+\t\t\t\treturn -ENOMEM;\n+\n \t\t\trte_memcpy(crypto_op_cookie->iv,\n \t\t\t\t\trte_crypto_op_ctod_offset(cop,\n \t\t\t\t\tuint8_t *, session->iv.offset),\n", "prefixes": [ "v2" ] }