Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107856/?format=api
{ "id": 107856, "url": "https://patches.dpdk.org/api/patches/107856/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220220005140.78713-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220220005140.78713-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220220005140.78713-8-stephen@networkplumber.org", "date": "2022-02-20T00:51:40", "name": "[v2,7/7] event/sw: remove unnecessary NULL check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63e531796f0b15482912d92c91ee9254c9944d4d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220220005140.78713-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 21749, "url": "https://patches.dpdk.org/api/series/21749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21749", "date": "2022-02-20T00:51:33", "name": "fix more unnecessary null checks", "version": 2, "mbox": "https://patches.dpdk.org/series/21749/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107856/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/107856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8468A00C2;\n\tSun, 20 Feb 2022 01:52:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 009EE4116E;\n\tSun, 20 Feb 2022 01:51:57 +0100 (CET)", "from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 0E29D41155\n for <dev@dpdk.org>; Sun, 20 Feb 2022 01:51:53 +0100 (CET)", "by mail-pj1-f52.google.com with SMTP id b8so11728033pjb.4\n for <dev@dpdk.org>; Sat, 19 Feb 2022 16:51:52 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n f7sm8129695pfc.0.2022.02.19.16.51.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 19 Feb 2022 16:51:51 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=JmXi31/r8tlV/948CXLr7AjGfC9uW5LXdCV6pMs+g48=;\n b=f1Jl3Sf3FJRgg1nVw+WcdyHTuTMgvaEXYRIWGTwIKhbjKpuOUb983z9pRRHXBbiR0K\n Y4vXGYDoTVy0Khhgs4LNnUtqtsiYfNa+nWgqlbNkDCKysoLsF3jGyiRBMIYg0DWIBhwk\n uWIlYEe6GesSiZO3xV2m55UZLxG4YN9P9hhrdi7VPAv68bo8AzNwr4qX2p2AGg6bNMTD\n B0lXRtRn8B1piKXRUVroVcsKmw6/54i0kHoGInrcDpVbyDQfcz6Az3P2mJfL2sYoJSrq\n ervq/mgfVaPQAancoq2YNlUtz/krd/KarP+77lt2XNxdrD8U4T8WfbaTw7vMBCFCS3f9\n Yk2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=JmXi31/r8tlV/948CXLr7AjGfC9uW5LXdCV6pMs+g48=;\n b=iT9ZLdoGqWq653QPufCGSoEiqGHtxfSZ7HFoA58eIlxutnedx9eWrqtXvM7qIvgS/E\n uJCjQ6Lcz8aieek8/OSUemI2604PZm3pavfzvLOKhK0D9rJeYptgTVDrQ7lwLBcOaSIB\n uF0x5061x/KP3HxcQPOZ4xhQ3RiEyzwf0tQQEF5RwDYv9LnBSt/C9jP0gSiiFAYlg5CL\n eUzsRibCEKDHISHc3WNkiGbvifrLiGAOt+HqgYYIdXJ427J1H8IQ/DIEbZx8LVptMNKu\n uwVUVjkWuhIoqZ7hp8n5/hubkivE4u7rTMAe2/Qn8KHFeJlLnJAn7h1h3+OtO7WiA4tb\n lhVw==", "X-Gm-Message-State": "AOAM533sba8PXi5VcpwEKgxSvKl4LM9UjSrJ91+L819e8HMizhaDROK7\n 1IeA4IXpm5dcr/9HkQda01EX04wxf6Reh6Gm", "X-Google-Smtp-Source": "\n ABdhPJx2OTGhvzTWcQGqlz4ugTkpnVGZSDgvqhv+RWHPnZGtXqdNnZOKWbhOKVPjn6Sq57H04v1fhQ==", "X-Received": "by 2002:a17:902:8ec7:b0:14a:c442:8ca2 with SMTP id\n x7-20020a1709028ec700b0014ac4428ca2mr13459832plo.12.1645318311989;\n Sat, 19 Feb 2022 16:51:51 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Harry van Haaren <harry.van.haaren@intel.com>", "Subject": "[PATCH v2 7/7] event/sw: remove unnecessary NULL check", "Date": "Sat, 19 Feb 2022 16:51:40 -0800", "Message-Id": "<20220220005140.78713-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220220005140.78713-1-stephen@networkplumber.org>", "References": "<20220219234322.61309-1-stephen@networkplumber.org>\n <20220220005140.78713-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_event_ring_free() function already handles NULL pointer.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/event/sw/sw_evdev.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nindex ba82a80385b6..f93313b31b5c 100644\n--- a/drivers/event/sw/sw_evdev.c\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -166,8 +166,7 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id,\n \tsnprintf(buf, sizeof(buf), \"sw%d_p%u_%s\", dev->data->dev_id,\n \t\t\tport_id, \"rx_worker_ring\");\n \tstruct rte_event_ring *existing_ring = rte_event_ring_lookup(buf);\n-\tif (existing_ring)\n-\t\trte_event_ring_free(existing_ring);\n+\trte_event_ring_free(existing_ring);\n \n \tp->rx_worker_ring = rte_event_ring_create(buf, MAX_SW_PROD_Q_DEPTH,\n \t\t\tdev->data->socket_id,\n@@ -186,8 +185,7 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id,\n \tsnprintf(buf, sizeof(buf), \"sw%d_p%u, %s\", dev->data->dev_id,\n \t\t\tport_id, \"cq_worker_ring\");\n \texisting_ring = rte_event_ring_lookup(buf);\n-\tif (existing_ring)\n-\t\trte_event_ring_free(existing_ring);\n+\trte_event_ring_free(existing_ring);\n \n \tp->cq_worker_ring = rte_event_ring_create(buf, conf->dequeue_depth,\n \t\t\tdev->data->socket_id,\n", "prefixes": [ "v2", "7/7" ] }