Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107848/?format=api
{ "id": 107848, "url": "https://patches.dpdk.org/api/patches/107848/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220219234322.61309-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220219234322.61309-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220219234322.61309-4-stephen@networkplumber.org", "date": "2022-02-19T23:43:22", "name": "[3/3] lpm: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f031f578de541f6d3d0338dfad72012a5eff3a56", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220219234322.61309-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 21748, "url": "https://patches.dpdk.org/api/series/21748/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21748", "date": "2022-02-19T23:43:19", "name": "more unnecessary null checks", "version": 1, "mbox": "https://patches.dpdk.org/series/21748/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107848/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/107848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECC4BA00C4;\n\tSun, 20 Feb 2022 00:43:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 23E4941151;\n\tSun, 20 Feb 2022 00:43:31 +0100 (CET)", "from mail-pj1-f54.google.com (mail-pj1-f54.google.com\n [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id F2C4E41147\n for <dev@dpdk.org>; Sun, 20 Feb 2022 00:43:28 +0100 (CET)", "by mail-pj1-f54.google.com with SMTP id qe15so11657871pjb.3\n for <dev@dpdk.org>; Sat, 19 Feb 2022 15:43:28 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n v17-20020a17090a459100b001b93ef45c13sm3057268pjg.55.2022.02.19.15.43.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 19 Feb 2022 15:43:27 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=qEihVze8WeNbSIYY6XPap8pQlRP+FFQ9kTtB3C+eCsI=;\n b=uTteZuv2quUSgiaJ8CG5T3nr5JhfFKM/keHCaKvKD8IOZ8K4t+EAw7vaySwgrClpSM\n d8c7paOTl/6OaKZDR0v2em92fQZeRXYQu8Ydm2/x6e+SxBmZD0xrkjoS+DO+tkgyS0ms\n NaAdSmFNVcimCHLn2GF06c3soSlyBIf8oXk6wS5uN40nN1i62J2wuYyGIyLJ9zhAXx+e\n EUdjFL1kJiwV8cJ+bcVrySpxzQ/JR0vlxwgaOl2CzrkIkyM3pFC69yzEK8SZG4woHZfS\n 6fXsUfkju34Twz9p5oCzrWADThyrMH8kD3YBcOtHIZ2UAOxH8SPAKdPNbUy3u35fSy29\n ow+Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=qEihVze8WeNbSIYY6XPap8pQlRP+FFQ9kTtB3C+eCsI=;\n b=muxv0WcPt0BNlRS2fyyS2bX+H/4/i0lIXHTV8kELWXZwMkMwfYIeXv7c6o2bljQmEy\n xIPxKcXhafI8U49H4HqART4OendEybeo5AAxtk3BsfdGMqb5qzyJFUXwoXWv3zC11ibr\n mU/zwWK9sX6kr1wSDjnEedeBxoWxCFg2Bk3ZqDE1wopXFXkfMsktUBzyfDYC3ofplj+7\n mGafTWyqc6lr95KtI4Ih8H0qQMROE/quervWNxGuGiCcqSB6QMeIPPiu+zv4joxkFRbk\n IZKpGu+kIS04vf+xFJ/RnNOSmmcFN/NEdqLW3PHtOz2KbNbXgVVdzd79OIisdSENxb/A\n yu5A==", "X-Gm-Message-State": "AOAM531ngfwvUlkmO4eNpecaL8mJN/gk959kLF0EI8bFdeBHsEkOPi9B\n OJlMnxXKuH5zTEe350kXz8vQTB1WYkRlW/6V", "X-Google-Smtp-Source": "\n ABdhPJz+5QsKKesuuV9G4x9GScjiqw76ITJ3NJEG/lwyLT0vddJi3W5i/BAMQ/QkaBZXZ/SwBDfTTw==", "X-Received": "by 2002:a17:902:8d87:b0:14f:7ad8:65c3 with SMTP id\n v7-20020a1709028d8700b0014f7ad865c3mr7926666plo.32.1645314207967;\n Sat, 19 Feb 2022 15:43:27 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Subject": "[PATCH 3/3] lpm: remove unnecessary NULL checks", "Date": "Sat, 19 Feb 2022 15:43:22 -0800", "Message-Id": "<20220219234322.61309-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220219234322.61309-1-stephen@networkplumber.org>", "References": "<20220219234322.61309-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The functions rte_lpm_free() and rte_lpm6_free() alread\nhandle NULL pointer case.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_func_reentrancy.c | 3 +--\n lib/lpm/rte_lpm.h | 1 +\n lib/lpm/rte_lpm6.h | 1 +\n 3 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c\nindex da00694daafd..67e69ad53588 100644\n--- a/app/test/test_func_reentrancy.c\n+++ b/app/test/test_func_reentrancy.c\n@@ -348,8 +348,7 @@ lpm_clean(unsigned int lcore_id)\n \tint i;\n \n \tlpm = rte_lpm_find_existing(\"fr_test_once\");\n-\tif (lpm != NULL)\n-\t\trte_lpm_free(lpm);\n+\trte_lpm_free(lpm);\n \n \tfor (i = 0; i < MAX_LPM_ITER_TIMES; i++) {\n \t\tsnprintf(lpm_name, sizeof(lpm_name), \"fr_test_%d_%d\", lcore_id, i);\ndiff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h\nindex 5eb14c1748e5..a50bf3339fee 100644\n--- a/lib/lpm/rte_lpm.h\n+++ b/lib/lpm/rte_lpm.h\n@@ -183,6 +183,7 @@ rte_lpm_find_existing(const char *name);\n *\n * @param lpm\n * LPM object handle\n+ * If NULL then, the function does nothing.\n * @return\n * None\n */\ndiff --git a/lib/lpm/rte_lpm6.h b/lib/lpm/rte_lpm6.h\nindex f96f3372e593..145fd4495a94 100644\n--- a/lib/lpm/rte_lpm6.h\n+++ b/lib/lpm/rte_lpm6.h\n@@ -73,6 +73,7 @@ rte_lpm6_find_existing(const char *name);\n *\n * @param lpm\n * LPM object handle\n+ * If NULL then, the function does nothing.\n * @return\n * None\n */\n", "prefixes": [ "3/3" ] }