Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107748/?format=api
{ "id": 107748, "url": "https://patches.dpdk.org/api/patches/107748/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220217160613.70161-12-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220217160613.70161-12-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220217160613.70161-12-srikanth.k@oneconvergence.com", "date": "2022-02-17T16:06:09", "name": "[v3,11/15] net/netvsc: moving hotplug retry to OS dir", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "76e3b9f8410d690a605f298bf78cc436361c6496", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220217160613.70161-12-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 21713, "url": "https://patches.dpdk.org/api/series/21713/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21713", "date": "2022-02-17T16:05:58", "name": "add FreeBSD support to VMBUS & NetVSC PMDs", "version": 3, "mbox": "https://patches.dpdk.org/series/21713/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107748/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/107748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2F35A034E;\n\tThu, 17 Feb 2022 17:12:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95EC7411B6;\n\tThu, 17 Feb 2022 17:11:02 +0100 (CET)", "from mail-pj1-f66.google.com (mail-pj1-f66.google.com\n [209.85.216.66]) by mails.dpdk.org (Postfix) with ESMTP id 027D640042\n for <dev@dpdk.org>; Thu, 17 Feb 2022 17:07:00 +0100 (CET)", "by mail-pj1-f66.google.com with SMTP id qe15so6003547pjb.3\n for <dev@dpdk.org>; Thu, 17 Feb 2022 08:06:59 -0800 (PST)", "from srikanth-ThinkPad-T450.. ([49.37.144.122])\n by smtp.gmail.com with ESMTPSA id z14sm47807pfh.173.2022.02.17.08.06.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 17 Feb 2022 08:06:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=BEpDKAeDbz1GNZlqcVjcUBf83yZNy9f8hz+YSThexrc=;\n b=PlkqOtJceHsjAwKny8WjUHGruDtw236/hHMbYAxgQezZ7GUXQmrFS43pTy6RDOCjMX\n X50vTJo7IIoFBMHbyfHA2Z1hrGehQZazoV5J70lJRFToAhb8kxl1DhK7YCsQtlySe/w5\n 031YyBJRMTWzPfgXsJB2EChGP/z0grNXhr/vE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=BEpDKAeDbz1GNZlqcVjcUBf83yZNy9f8hz+YSThexrc=;\n b=IuM1J1GWByuTd1s7EEA/IwpnCyiEV4GYzH7JPhnGX2f7uFiUkx0dKuQzmNUlU/oVsh\n 1lAAFrHJxozd3o+XkykZmmV8Ab8iieDKKGZHU8iyU1FDYk57JmjHBAwH/AfM/c0Y6uMl\n jNI+8eC81JOrFost4pbLYGzlqUiuSyohvRMZ15fqqenjU6YurWlEcRfEwAgaEbPfCuuh\n 4c0ZveSG6TXCKezeSP5KV4kV0FLdVPCusZDTE3avE5g6r+aAk+mF0mUt8+w0KpSo4o/g\n mMF/QUladcDXY8t4Ve1Y3objjQpuJinl8zWZmKf32I543DfJZmLj3xxUPUuaJEuVhDeg\n zWXg==", "X-Gm-Message-State": "AOAM533lMprf75loISBrAQn6PbB9I0OvSihEkRyDYxpH+kVFkn0eo/Wh\n PITJW38Tqc4O3TVC8MxnsXsunQ==", "X-Google-Smtp-Source": "\n ABdhPJxDlrTBJ2rNFW9fQvrBpV3VFtqmAksuZByZCGVBdIrzHrrkqnUdnX5NmLUqpG+vQYW5yCPirg==", "X-Received": "by 2002:a17:90b:3806:b0:1b8:e628:d88 with SMTP id\n mq6-20020a17090b380600b001b8e6280d88mr8048624pjb.32.1645114019174;\n Thu, 17 Feb 2022 08:06:59 -0800 (PST)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "sthemmin@microsoft.com,\n\tlongli@microsoft.com", "Cc": "dev@dpdk.org, vag.singh@oneconvergence.com, avelu@juniper.net,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Subject": "[PATCH v3 11/15] net/netvsc: moving hotplug retry to OS dir", "Date": "Thu, 17 Feb 2022 21:36:09 +0530", "Message-Id": "<20220217160613.70161-12-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220217160613.70161-1-srikanth.k@oneconvergence.com>", "References": "<20210927134231.11177-1-srikanth.k@oneconvergence.com>\n <20220217160613.70161-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 17 Feb 2022 17:10:51 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Moved netvsc_hotplug_retry to respective OS dir as it contains OS\ndependent code. For Linux, it is copied as is and for FreeBSD it\nis not supported yet.\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/net/netvsc/freebsd/hn_os.c | 6 ++\n drivers/net/netvsc/hn_ethdev.c | 84 ----------------------------\n drivers/net/netvsc/hn_os.h | 2 +\n drivers/net/netvsc/linux/hn_os.c | 90 ++++++++++++++++++++++++++++++\n 4 files changed, 98 insertions(+), 84 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/freebsd/hn_os.c b/drivers/net/netvsc/freebsd/hn_os.c\nindex 4c6a79872d..2ba4c32a76 100644\n--- a/drivers/net/netvsc/freebsd/hn_os.c\n+++ b/drivers/net/netvsc/freebsd/hn_os.c\n@@ -14,3 +14,9 @@ int eth_hn_os_dev_event(void)\n \tPMD_DRV_LOG(DEBUG, \"rte_dev_event_monitor_start not supported on FreeBSD\");\n \treturn 0;\n }\n+\n+void netvsc_hotplug_retry(void *args)\n+{\n+\tRTE_SET_USED(args);\n+\treturn;\n+}\ndiff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 104c7aebc5..dd4b872fed 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -57,9 +57,6 @@\n #define NETVSC_ARG_TXBREAK \"tx_copybreak\"\n #define NETVSC_ARG_RX_EXTMBUF_ENABLE \"rx_extmbuf_enable\"\n \n-/* The max number of retry when hot adding a VF device */\n-#define NETVSC_MAX_HOTADD_RETRY 10\n-\n struct hn_xstats_name_off {\n \tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n \tunsigned int offset;\n@@ -556,87 +553,6 @@ static int hn_subchan_configure(struct hn_data *hv,\n \treturn err;\n }\n \n-static void netvsc_hotplug_retry(void *args)\n-{\n-\tint ret;\n-\tstruct hn_data *hv = args;\n-\tstruct rte_eth_dev *dev = &rte_eth_devices[hv->port_id];\n-\tstruct rte_devargs *d = &hv->devargs;\n-\tchar buf[256];\n-\n-\tDIR *di;\n-\tstruct dirent *dir;\n-\tstruct ifreq req;\n-\tstruct rte_ether_addr eth_addr;\n-\tint s;\n-\n-\tPMD_DRV_LOG(DEBUG, \"%s: retry count %d\",\n-\t\t __func__, hv->eal_hot_plug_retry);\n-\n-\tif (hv->eal_hot_plug_retry++ > NETVSC_MAX_HOTADD_RETRY)\n-\t\treturn;\n-\n-\tsnprintf(buf, sizeof(buf), \"/sys/bus/pci/devices/%s/net\", d->name);\n-\tdi = opendir(buf);\n-\tif (!di) {\n-\t\tPMD_DRV_LOG(DEBUG, \"%s: can't open directory %s, \"\n-\t\t\t \"retrying in 1 second\", __func__, buf);\n-\t\tgoto retry;\n-\t}\n-\n-\twhile ((dir = readdir(di))) {\n-\t\t/* Skip . and .. directories */\n-\t\tif (!strcmp(dir->d_name, \".\") || !strcmp(dir->d_name, \"..\"))\n-\t\t\tcontinue;\n-\n-\t\t/* trying to get mac address if this is a network device*/\n-\t\ts = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);\n-\t\tif (s == -1) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Failed to create socket errno %d\",\n-\t\t\t\t errno);\n-\t\t\tbreak;\n-\t\t}\n-\t\tstrlcpy(req.ifr_name, dir->d_name, sizeof(req.ifr_name));\n-\t\tret = ioctl(s, SIOCGIFHWADDR, &req);\n-\t\tclose(s);\n-\t\tif (ret == -1) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t \"Failed to send SIOCGIFHWADDR for device %s\",\n-\t\t\t\t dir->d_name);\n-\t\t\tbreak;\n-\t\t}\n-\t\tif (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) {\n-\t\t\tclosedir(di);\n-\t\t\treturn;\n-\t\t}\n-\t\tmemcpy(eth_addr.addr_bytes, req.ifr_hwaddr.sa_data,\n-\t\t RTE_DIM(eth_addr.addr_bytes));\n-\n-\t\tif (rte_is_same_ether_addr(ð_addr, dev->data->mac_addrs)) {\n-\t\t\tPMD_DRV_LOG(NOTICE,\n-\t\t\t\t \"Found matching MAC address, adding device %s network name %s\",\n-\t\t\t\t d->name, dir->d_name);\n-\t\t\tret = rte_eal_hotplug_add(d->bus->name, d->name,\n-\t\t\t\t\t\t d->args);\n-\t\t\tif (ret) {\n-\t\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\t \"Failed to add PCI device %s\",\n-\t\t\t\t\t d->name);\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t}\n-\t\t/* When the code reaches here, we either have already added\n-\t\t * the device, or its MAC address did not match.\n-\t\t */\n-\t\tclosedir(di);\n-\t\treturn;\n-\t}\n-\tclosedir(di);\n-retry:\n-\t/* The device is still being initialized, retry after 1 second */\n-\trte_eal_alarm_set(1000000, netvsc_hotplug_retry, hv);\n-}\n-\n static void\n netvsc_hotadd_callback(const char *device_name, enum rte_dev_event_type type,\n \t\t void *arg)\ndiff --git a/drivers/net/netvsc/hn_os.h b/drivers/net/netvsc/hn_os.h\nindex 618c53cdcd..1fb7292b17 100644\n--- a/drivers/net/netvsc/hn_os.h\n+++ b/drivers/net/netvsc/hn_os.h\n@@ -4,3 +4,5 @@\n */\n \n int eth_hn_os_dev_event(void);\n+\n+void netvsc_hotplug_retry(void *args);\ndiff --git a/drivers/net/netvsc/linux/hn_os.c b/drivers/net/netvsc/linux/hn_os.c\nindex 1ea12ce928..9c2f4cd7a8 100644\n--- a/drivers/net/netvsc/linux/hn_os.c\n+++ b/drivers/net/netvsc/linux/hn_os.c\n@@ -3,12 +3,21 @@\n */\n \n #include <unistd.h>\n+#include <dirent.h>\n+#include <net/if.h>\n+#include <net/if_arp.h>\n+#include <sys/ioctl.h>\n \n #include <rte_ethdev.h>\n+#include <rte_alarm.h>\n \n #include \"hn_logs.h\"\n+#include \"hn_var.h\"\n #include \"hn_os.h\"\n \n+/* The max number of retry when hot adding a VF device */\n+#define NETVSC_MAX_HOTADD_RETRY 10\n+\n int eth_hn_os_dev_event(void)\n {\n \tint ret;\n@@ -19,3 +28,84 @@ int eth_hn_os_dev_event(void)\n \n \treturn ret;\n }\n+\n+void netvsc_hotplug_retry(void *args)\n+{\n+\tint ret;\n+\tstruct hn_data *hv = args;\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[hv->port_id];\n+\tstruct rte_devargs *d = &hv->devargs;\n+\tchar buf[256];\n+\n+\tDIR *di;\n+\tstruct dirent *dir;\n+\tstruct ifreq req;\n+\tstruct rte_ether_addr eth_addr;\n+\tint s;\n+\n+\tPMD_DRV_LOG(DEBUG, \"%s: retry count %d\",\n+\t\t __func__, hv->eal_hot_plug_retry);\n+\n+\tif (hv->eal_hot_plug_retry++ > NETVSC_MAX_HOTADD_RETRY)\n+\t\treturn;\n+\n+\tsnprintf(buf, sizeof(buf), \"/sys/bus/pci/devices/%s/net\", d->name);\n+\tdi = opendir(buf);\n+\tif (!di) {\n+\t\tPMD_DRV_LOG(DEBUG, \"%s: can't open directory %s, \"\n+\t\t\t \"retrying in 1 second\", __func__, buf);\n+\t\tgoto retry;\n+\t}\n+\n+\twhile ((dir = readdir(di))) {\n+\t\t/* Skip . and .. directories */\n+\t\tif (!strcmp(dir->d_name, \".\") || !strcmp(dir->d_name, \"..\"))\n+\t\t\tcontinue;\n+\n+\t\t/* trying to get mac address if this is a network device*/\n+\t\ts = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);\n+\t\tif (s == -1) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to create socket errno %d\",\n+\t\t\t\t errno);\n+\t\t\tbreak;\n+\t\t}\n+\t\tstrlcpy(req.ifr_name, dir->d_name, sizeof(req.ifr_name));\n+\t\tret = ioctl(s, SIOCGIFHWADDR, &req);\n+\t\tclose(s);\n+\t\tif (ret == -1) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Failed to send SIOCGIFHWADDR for device %s\",\n+\t\t\t\t dir->d_name);\n+\t\t\tbreak;\n+\t\t}\n+\t\tif (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) {\n+\t\t\tclosedir(di);\n+\t\t\treturn;\n+\t\t}\n+\t\tmemcpy(eth_addr.addr_bytes, req.ifr_hwaddr.sa_data,\n+\t\t RTE_DIM(eth_addr.addr_bytes));\n+\n+\t\tif (rte_is_same_ether_addr(ð_addr, dev->data->mac_addrs)) {\n+\t\t\tPMD_DRV_LOG(NOTICE,\n+\t\t\t\t \"Found matching MAC address, adding device %s network name %s\",\n+\t\t\t\t d->name, dir->d_name);\n+\t\t\tret = rte_eal_hotplug_add(d->bus->name, d->name,\n+\t\t\t\t\t\t d->args);\n+\t\t\tif (ret) {\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t \"Failed to add PCI device %s\",\n+\t\t\t\t\t d->name);\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\t\t/* When the code reaches here, we either have already added\n+\t\t * the device, or its MAC address did not match.\n+\t\t */\n+\t\tclosedir(di);\n+\t\treturn;\n+\t}\n+\tclosedir(di);\n+retry:\n+\t/* The device is still being initialized, retry after 1 second */\n+\trte_eal_alarm_set(1000000, netvsc_hotplug_retry, hv);\n+}\n", "prefixes": [ "v3", "11/15" ] }