Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107682/?format=api
{ "id": 107682, "url": "https://patches.dpdk.org/api/patches/107682/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220216151456.114242-2-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220216151456.114242-2-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220216151456.114242-2-brian.dooley@intel.com", "date": "2022-02-16T15:14:46", "name": "[v2,01/11] eal: fix missing C++ guards", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e458950565817eba4805bb571caa510d05cf78e0", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220216151456.114242-2-brian.dooley@intel.com/mbox/", "series": [ { "id": 21694, "url": "https://patches.dpdk.org/api/series/21694/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21694", "date": "2022-02-16T15:14:45", "name": "add missing C++ guards", "version": 2, "mbox": "https://patches.dpdk.org/series/21694/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107682/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/107682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3522A00C5;\n\tWed, 16 Feb 2022 16:15:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3ABD40150;\n\tWed, 16 Feb 2022 16:15:43 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 9EDF340150;\n Wed, 16 Feb 2022 16:15:41 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Feb 2022 07:15:18 -0800", "from unknown (HELO silpixa00400883.ir.intel.com) ([10.243.23.143])\n by orsmga003.jf.intel.com with ESMTP; 16 Feb 2022 07:15:13 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1645024542; x=1676560542;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=OlQUwApvIsZYAOVNqGhD9lmiEO1OJ8QL90xZPLjuyHc=;\n b=SqfCQ7mgYiyuG1QAzDCtM2SNSLRXpR8x8bM32AX4pMWSN4NhCJ5AUzPM\n EOF0LZJM2O/KSieQojHu8nMqg3bwsDorf6DggyK4+Xc8i94ykWmbuD6z9\n 35qTQXHtil0xGrvfFmrxYvwFpgCcUGHwTEXZMBfmiCwpRYGlA5k7cDR9L\n PesEMMcs2WkRUDBbl0onTVQr+y3GPqaRUrzIlp+4++t1VFAIeaCvfLJ2p\n q/snCrKmrTIW7glT8pbq9qE7ajeAfd+zt02mh+aJ9HvG/CVgK1J5rPZ+l\n uBTmJASkGblzFiSW3f+wBYbrcaMVf1G4juckmw/4THC+WeonZ/wa2PFBJ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10260\"; a=\"250824448\"", "E=Sophos;i=\"5.88,374,1635231600\"; d=\"scan'208\";a=\"250824448\"", "E=Sophos;i=\"5.88,374,1635231600\"; d=\"scan'208\";a=\"487084176\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "dev@dpdk.org", "Cc": "Brian Dooley <brian.dooley@intel.com>, joyce.kong@arm.com,\n nhorman@tuxdriver.com, thomas@monjalon.net, anatoly.burakov@intel.com,\n adrien.mazarguil@6wind.com, jerinj@marvell.com, anand.rawat@intel.com,\n stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n Ray Kinsella <mdr@ashroe.eu>, Sunil Kumar Kori <skori@marvell.com>,\n Phil Yang <phil.yang@arm.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Gavin Hu <gavin.hu@arm.com>,\n Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,\n Remy Horton <remy.horton@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>", "Subject": "[PATCH v2 01/11] eal: fix missing C++ guards", "Date": "Wed, 16 Feb 2022 15:14:46 +0000", "Message-Id": "<20220216151456.114242-2-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220216151456.114242-1-brian.dooley@intel.com>", "References": "<20220215170817.662136-1-brian.dooley@intel.com>\n <20220216151456.114242-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some public header files were missing 'extern \"C\"' C++ guards,\nand couldn't be used by C++ applications. Add the missing guards.\n\nFixes: af75078fece3 (\"first public release\")\nFixes: 7f3aa0863903 (\"eal: introduce bit operations API\")\nFixes: 166a743c53fa (\"compat: add infrastructure to support symbol versioning\")\nFixes: 8f40ee0734c8 (\"eal/x86: get hypervisor name\")\nFixes: 75583b0d1efd (\"eal: add keep alive monitoring\")\nFixes: 88701645c98c (\"eal: move interrupt type out of igb_uio\")\nFixes: f04519d8092e (\"lib: add missing include dependencies\")\nFixes: f58880682c81 (\"trace: implement register API\")\nFixes: 428eb983f5f7 (\"eal: add OS specific header file\")\nCc: joyce.kong@arm.com\nCc: nhorman@tuxdriver.com\nCc: thomas@monjalon.net\nCc: anatoly.burakov@intel.com\nCc: adrien.mazarguil@6wind.com\nCc: jerinj@marvell.com\nCc: anand.rawat@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n\n---\nv2: Added missing apostrophe to commit message.\n---\n lib/eal/include/rte_bitops.h | 8 ++++++++\n lib/eal/include/rte_branch_prediction.h | 8 ++++++++\n lib/eal/include/rte_compat.h | 8 ++++++++\n lib/eal/include/rte_hypervisor.h | 8 ++++++++\n lib/eal/include/rte_keepalive.h | 8 ++++++++\n lib/eal/include/rte_pci_dev_feature_defs.h | 8 ++++++++\n lib/eal/include/rte_pci_dev_features.h | 8 ++++++++\n lib/eal/include/rte_time.h | 8 ++++++++\n lib/eal/include/rte_trace_point_register.h | 8 ++++++++\n lib/eal/linux/include/rte_os.h | 8 ++++++++\n 10 files changed, 80 insertions(+)", "diff": "diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h\nindex 141e8ea730..f50dbe4388 100644\n--- a/lib/eal/include/rte_bitops.h\n+++ b/lib/eal/include/rte_bitops.h\n@@ -17,6 +17,10 @@\n #include <rte_debug.h>\n #include <rte_compat.h>\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /**\n * Get the uint64_t value for a specified bit set.\n *\n@@ -271,4 +275,8 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, volatile uint64_t *addr)\n \treturn val & mask;\n }\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_BITOPS_H_ */\ndiff --git a/lib/eal/include/rte_branch_prediction.h b/lib/eal/include/rte_branch_prediction.h\nindex 854ef9e5dd..0256a9de60 100644\n--- a/lib/eal/include/rte_branch_prediction.h\n+++ b/lib/eal/include/rte_branch_prediction.h\n@@ -10,6 +10,10 @@\n #ifndef _RTE_BRANCH_PREDICTION_H_\n #define _RTE_BRANCH_PREDICTION_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /**\n * Check if a branch is likely to be taken.\n *\n@@ -38,4 +42,8 @@\n #define unlikely(x)\t__builtin_expect(!!(x), 0)\n #endif /* unlikely */\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_BRANCH_PREDICTION_H_ */\ndiff --git a/lib/eal/include/rte_compat.h b/lib/eal/include/rte_compat.h\nindex 9556bbf4d0..fc9fbaaab2 100644\n--- a/lib/eal/include/rte_compat.h\n+++ b/lib/eal/include/rte_compat.h\n@@ -6,6 +6,10 @@\n #ifndef _RTE_COMPAT_H_\n #define _RTE_COMPAT_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #ifndef ALLOW_EXPERIMENTAL_API\n \n #define __rte_experimental \\\n@@ -46,4 +50,8 @@ __attribute__((section(\".text.internal\")))\n \n #endif\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_COMPAT_H_ */\ndiff --git a/lib/eal/include/rte_hypervisor.h b/lib/eal/include/rte_hypervisor.h\nindex 5fe719c1d4..1666431ce3 100644\n--- a/lib/eal/include/rte_hypervisor.h\n+++ b/lib/eal/include/rte_hypervisor.h\n@@ -5,6 +5,10 @@\n #ifndef RTE_HYPERVISOR_H\n #define RTE_HYPERVISOR_H\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /**\n * @file\n * Hypervisor awareness.\n@@ -30,4 +34,8 @@ rte_hypervisor_get(void);\n const char *\n rte_hypervisor_get_name(enum rte_hypervisor id);\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* RTE_HYPERVISOR_H */\ndiff --git a/lib/eal/include/rte_keepalive.h b/lib/eal/include/rte_keepalive.h\nindex bd25508da8..538fb09095 100644\n--- a/lib/eal/include/rte_keepalive.h\n+++ b/lib/eal/include/rte_keepalive.h\n@@ -11,6 +11,10 @@\n #ifndef _KEEPALIVE_H_\n #define _KEEPALIVE_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #include <rte_config.h>\n #include <rte_memory.h>\n \n@@ -139,4 +143,8 @@ rte_keepalive_register_relay_callback(struct rte_keepalive *keepcfg,\n \trte_keepalive_relay_callback_t callback,\n \tvoid *data);\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _KEEPALIVE_H_ */\ndiff --git a/lib/eal/include/rte_pci_dev_feature_defs.h b/lib/eal/include/rte_pci_dev_feature_defs.h\nindex e12c22081f..c5bb631286 100644\n--- a/lib/eal/include/rte_pci_dev_feature_defs.h\n+++ b/lib/eal/include/rte_pci_dev_feature_defs.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_PCI_DEV_DEFS_H_\n #define _RTE_PCI_DEV_DEFS_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /* interrupt mode */\n enum rte_intr_mode {\n \tRTE_INTR_MODE_NONE = 0,\n@@ -13,4 +17,8 @@ enum rte_intr_mode {\n \tRTE_INTR_MODE_MSIX\n };\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_PCI_DEV_DEFS_H_ */\ndiff --git a/lib/eal/include/rte_pci_dev_features.h b/lib/eal/include/rte_pci_dev_features.h\nindex 6104123d27..ee6e10590c 100644\n--- a/lib/eal/include/rte_pci_dev_features.h\n+++ b/lib/eal/include/rte_pci_dev_features.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_PCI_DEV_FEATURES_H\n #define _RTE_PCI_DEV_FEATURES_H\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #include <rte_pci_dev_feature_defs.h>\n \n #define RTE_INTR_MODE_NONE_NAME \"none\"\n@@ -12,4 +16,8 @@\n #define RTE_INTR_MODE_MSI_NAME \"msi\"\n #define RTE_INTR_MODE_MSIX_NAME \"msix\"\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif\ndiff --git a/lib/eal/include/rte_time.h b/lib/eal/include/rte_time.h\nindex 5ad7c8841a..ec25f7b93d 100644\n--- a/lib/eal/include/rte_time.h\n+++ b/lib/eal/include/rte_time.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_TIME_H_\n #define _RTE_TIME_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #include <stdint.h>\n #include <time.h>\n \n@@ -98,4 +102,8 @@ rte_ns_to_timespec(uint64_t nsec)\n \treturn ts;\n }\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_TIME_H_ */\ndiff --git a/lib/eal/include/rte_trace_point_register.h b/lib/eal/include/rte_trace_point_register.h\nindex 4f5c86552d..2e61439940 100644\n--- a/lib/eal/include/rte_trace_point_register.h\n+++ b/lib/eal/include/rte_trace_point_register.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_TRACE_POINT_REGISTER_H_\n #define _RTE_TRACE_POINT_REGISTER_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n #ifdef _RTE_TRACE_POINT_H_\n #error for registration, include this file first before <rte_trace_point.h>\n #endif\n@@ -42,4 +46,8 @@ do { \\\n \t\tRTE_STR(in)\"[32]\", \"string_bounded_t\"); \\\n } while (0)\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_TRACE_POINT_REGISTER_H_ */\ndiff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/include/rte_os.h\nindex 35c07c70cb..c72bf5b7e6 100644\n--- a/lib/eal/linux/include/rte_os.h\n+++ b/lib/eal/linux/include/rte_os.h\n@@ -5,6 +5,10 @@\n #ifndef _RTE_OS_H_\n #define _RTE_OS_H_\n \n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n /**\n * This header should contain any definition\n * which is not supported natively or named differently in Linux.\n@@ -42,4 +46,8 @@ typedef cpu_set_t rte_cpuset_t;\n } while (0)\n #endif\n \n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* _RTE_OS_H_ */\n", "prefixes": [ "v2", "01/11" ] }