Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 107524,
    "url": "https://patches.dpdk.org/api/patches/107524/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220214144406.4192233-18-sean.morrissey@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220214144406.4192233-18-sean.morrissey@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220214144406.4192233-18-sean.morrissey@intel.com",
    "date": "2022-02-14T14:43:33",
    "name": "[v8,17/50] power: remove unneeded header includes",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c6bc6ad329886d179be643f8f87611a5ca078d83",
    "submitter": {
        "id": 1359,
        "url": "https://patches.dpdk.org/api/people/1359/?format=api",
        "name": "Sean Morrissey",
        "email": "sean.morrissey@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220214144406.4192233-18-sean.morrissey@intel.com/mbox/",
    "series": [
        {
            "id": 21662,
            "url": "https://patches.dpdk.org/api/series/21662/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21662",
            "date": "2022-02-14T14:43:16",
            "name": "introduce IWYU",
            "version": 8,
            "mbox": "https://patches.dpdk.org/series/21662/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/107524/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/107524/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92EF8A034E;\n\tMon, 14 Feb 2022 15:47:18 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 348E041C26;\n\tMon, 14 Feb 2022 15:46:02 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id C269441184\n for <dev@dpdk.org>; Mon, 14 Feb 2022 15:45:52 +0100 (CET)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Feb 2022 06:45:47 -0800",
            "from silpixa00401215.ir.intel.com ([10.55.128.96])\n by orsmga003.jf.intel.com with ESMTP; 14 Feb 2022 06:45:45 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644849953; x=1676385953;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=efAlmhJXnh7VUu2HKp4OH8akOK47eUiZRTF03S+jBL8=;\n b=iUR2J9yM/xTOwFhCu1xzmETIWBXOSzFRoYjVTkYwf0lJx7Kw8vSpb/wL\n 5n//+ZpYJyRtWA+N9VH11gyls8rztfUUrVy7q++FGUa1UKFFuX6PXy8+b\n pNeWdDyu/qhqYZM0AJMdS1o/Y1hO0LGWCzI+mfBYWhNSH8X2NUUp0Hnme\n ny6uwfoANK2igCr5Xu8Udbhi87x/tVWllhkxZXO7GupzRICNl4ecresTJ\n 2wstk/qaWgll9vsNJGIZqDG0HDlEhyNRAcQZnUc+7tkqDp1NgUs6ba0GT\n Hy33Qqrtvl6rnajr0YHHFS/fjIw0/8JttZ+VXXWQIj4pdc4SjV1QfDyJM A==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10257\"; a=\"274673438\"",
            "E=Sophos;i=\"5.88,368,1635231600\"; d=\"scan'208\";a=\"274673438\"",
            "E=Sophos;i=\"5.88,368,1635231600\"; d=\"scan'208\";a=\"485505117\""
        ],
        "X-ExtLoop1": "1",
        "From": "Sean Morrissey <sean.morrissey@intel.com>",
        "To": "David Hunt <david.hunt@intel.com>",
        "Cc": "dev@dpdk.org,\n\tSean Morrissey <sean.morrissey@intel.com>",
        "Subject": "[PATCH v8 17/50] power: remove unneeded header includes",
        "Date": "Mon, 14 Feb 2022 14:43:33 +0000",
        "Message-Id": "<20220214144406.4192233-18-sean.morrissey@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220214144406.4192233-1-sean.morrissey@intel.com>",
        "References": "<20220214113632.3184921-1-sean.morrissey@intel.com>\n <20220214144406.4192233-1-sean.morrissey@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "These header includes have been flagged by the iwyu_tool\nand removed. Also added rte_string_fns.h to example app\nvm_power_manager for users without libbsd.\n\nSigned-off-by: Sean Morrissey <sean.morrissey@intel.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n examples/vm_power_manager/guest_cli/main.c | 1 +\n lib/power/guest_channel.c                  | 2 --\n lib/power/power_acpi_cpufreq.c             | 7 -------\n lib/power/power_acpi_cpufreq.h             | 4 ----\n lib/power/power_common.h                   | 1 -\n lib/power/power_cppc_cpufreq.c             | 1 -\n lib/power/power_cppc_cpufreq.h             | 4 ----\n lib/power/power_kvm_vm.c                   | 1 -\n lib/power/power_kvm_vm.h                   | 4 ----\n lib/power/power_pstate_cpufreq.c           | 6 ------\n lib/power/power_pstate_cpufreq.h           | 4 ----\n lib/power/rte_power.c                      | 1 -\n lib/power/rte_power.h                      | 2 --\n lib/power/rte_power_empty_poll.c           | 2 --\n 14 files changed, 1 insertion(+), 39 deletions(-)",
    "diff": "diff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c\nindex b8fa65ef15..9da50020ac 100644\n--- a/examples/vm_power_manager/guest_cli/main.c\n+++ b/examples/vm_power_manager/guest_cli/main.c\n@@ -13,6 +13,7 @@\n #include <rte_debug.h>\n #include <rte_eal.h>\n #include <rte_log.h>\n+#include <rte_string_fns.h>\n \n #include \"vm_power_cli_guest.h\"\n #include \"parse.h\"\ndiff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c\nindex 474dd92998..969a9e5aaa 100644\n--- a/lib/power/guest_channel.c\n+++ b/lib/power/guest_channel.c\n@@ -4,9 +4,7 @@\n \n #include <glob.h>\n #include <stdio.h>\n-#include <stdlib.h>\n #include <unistd.h>\n-#include <signal.h>\n #include <limits.h>\n #include <fcntl.h>\n #include <string.h>\ndiff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c\nindex 402ed8c99b..6e57aca535 100644\n--- a/lib/power/power_acpi_cpufreq.c\n+++ b/lib/power/power_acpi_cpufreq.c\n@@ -3,17 +3,10 @@\n  */\n \n #include <stdio.h>\n-#include <sys/types.h>\n-#include <sys/stat.h>\n #include <fcntl.h>\n #include <stdlib.h>\n-#include <string.h>\n-#include <unistd.h>\n-#include <signal.h>\n-#include <limits.h>\n \n #include <rte_memcpy.h>\n-#include <rte_memory.h>\n #include <rte_string_fns.h>\n \n #include \"power_acpi_cpufreq.h\"\ndiff --git a/lib/power/power_acpi_cpufreq.h b/lib/power/power_acpi_cpufreq.h\nindex 41675b9cd9..682fd9278c 100644\n--- a/lib/power/power_acpi_cpufreq.h\n+++ b/lib/power/power_acpi_cpufreq.h\n@@ -10,10 +10,6 @@\n  * RTE Power Management via userspace ACPI cpufreq\n  */\n \n-#include <rte_common.h>\n-#include <rte_byteorder.h>\n-#include <rte_log.h>\n-#include <rte_string_fns.h>\n #include \"rte_power.h\"\n \n /**\ndiff --git a/lib/power/power_common.h b/lib/power/power_common.h\nindex 0b264edfa5..c1c7139276 100644\n--- a/lib/power/power_common.h\n+++ b/lib/power/power_common.h\n@@ -5,7 +5,6 @@\n #ifndef _POWER_COMMON_H_\n #define _POWER_COMMON_H_\n \n-#include <inttypes.h>\n \n #include <rte_common.h>\n \ndiff --git a/lib/power/power_cppc_cpufreq.c b/lib/power/power_cppc_cpufreq.c\nindex 25185a791c..ef06fbcd9e 100644\n--- a/lib/power/power_cppc_cpufreq.c\n+++ b/lib/power/power_cppc_cpufreq.c\n@@ -4,7 +4,6 @@\n  */\n \n #include <rte_memcpy.h>\n-#include <rte_memory.h>\n \n #include \"power_cppc_cpufreq.h\"\n #include \"power_common.h\"\ndiff --git a/lib/power/power_cppc_cpufreq.h b/lib/power/power_cppc_cpufreq.h\nindex 4e73c91b05..f4121b237e 100644\n--- a/lib/power/power_cppc_cpufreq.h\n+++ b/lib/power/power_cppc_cpufreq.h\n@@ -11,10 +11,6 @@\n  * RTE Power Management via userspace CPPC cpufreq\n  */\n \n-#include <rte_common.h>\n-#include <rte_byteorder.h>\n-#include <rte_log.h>\n-#include <rte_string_fns.h>\n #include \"rte_power.h\"\n \n /**\ndiff --git a/lib/power/power_kvm_vm.c b/lib/power/power_kvm_vm.c\nindex ab7d4b8cee..6a8109d449 100644\n--- a/lib/power/power_kvm_vm.c\n+++ b/lib/power/power_kvm_vm.c\n@@ -9,7 +9,6 @@\n #include \"rte_power_guest_channel.h\"\n #include \"guest_channel.h\"\n #include \"power_kvm_vm.h\"\n-#include \"power_common.h\"\n \n #define FD_PATH \"/dev/virtio-ports/virtio.serial.port.poweragent\"\n \ndiff --git a/lib/power/power_kvm_vm.h b/lib/power/power_kvm_vm.h\nindex 9a309a300f..303fcc041b 100644\n--- a/lib/power/power_kvm_vm.h\n+++ b/lib/power/power_kvm_vm.h\n@@ -10,10 +10,6 @@\n  * RTE Power Management KVM VM\n  */\n \n-#include <rte_common.h>\n-#include <rte_byteorder.h>\n-#include <rte_log.h>\n-#include <rte_string_fns.h>\n #include \"rte_power.h\"\n \n /**\ndiff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c\nindex 86f8a76e46..f4c36179ec 100644\n--- a/lib/power/power_pstate_cpufreq.c\n+++ b/lib/power/power_pstate_cpufreq.c\n@@ -3,20 +3,14 @@\n  */\n \n #include <stdio.h>\n-#include <sys/types.h>\n-#include <sys/stat.h>\n #include <fcntl.h>\n-#include <stdlib.h>\n #include <string.h>\n #include <unistd.h>\n-#include <signal.h>\n #include <limits.h>\n #include <errno.h>\n #include <inttypes.h>\n \n #include <rte_memcpy.h>\n-#include <rte_memory.h>\n-#include <rte_string_fns.h>\n \n #include \"power_pstate_cpufreq.h\"\n #include \"power_common.h\"\ndiff --git a/lib/power/power_pstate_cpufreq.h b/lib/power/power_pstate_cpufreq.h\nindex 3260b32494..7bf64a518c 100644\n--- a/lib/power/power_pstate_cpufreq.h\n+++ b/lib/power/power_pstate_cpufreq.h\n@@ -10,10 +10,6 @@\n  * RTE Power Management via Intel Pstate driver\n  */\n \n-#include <rte_common.h>\n-#include <rte_byteorder.h>\n-#include <rte_log.h>\n-#include <rte_string_fns.h>\n #include \"rte_power.h\"\n \n /**\ndiff --git a/lib/power/rte_power.c b/lib/power/rte_power.c\nindex 3cba56bac9..0a6614be77 100644\n--- a/lib/power/rte_power.c\n+++ b/lib/power/rte_power.c\n@@ -10,7 +10,6 @@\n #include \"power_cppc_cpufreq.h\"\n #include \"power_kvm_vm.h\"\n #include \"power_pstate_cpufreq.h\"\n-#include \"power_common.h\"\n \n enum power_management_env global_default_env = PM_ENV_NOT_SET;\n \ndiff --git a/lib/power/rte_power.h b/lib/power/rte_power.h\nindex c5759afa39..47345e26df 100644\n--- a/lib/power/rte_power.h\n+++ b/lib/power/rte_power.h\n@@ -11,9 +11,7 @@\n  */\n \n #include <rte_common.h>\n-#include <rte_byteorder.h>\n #include <rte_log.h>\n-#include <rte_string_fns.h>\n #include <rte_power_guest_channel.h>\n \n #ifdef __cplusplus\ndiff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c\nindex 2261ce7820..4a4db51247 100644\n--- a/lib/power/rte_power_empty_poll.c\n+++ b/lib/power/rte_power_empty_poll.c\n@@ -5,8 +5,6 @@\n #include <string.h>\n \n #include <rte_lcore.h>\n-#include <rte_cycles.h>\n-#include <rte_atomic.h>\n #include <rte_malloc.h>\n #include <inttypes.h>\n \n",
    "prefixes": [
        "v8",
        "17/50"
    ]
}