Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107308/?format=api
{ "id": 107308, "url": "https://patches.dpdk.org/api/patches/107308/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220210230906.833163-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210230906.833163-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210230906.833163-4-stephen@networkplumber.org", "date": "2022-02-10T23:09:06", "name": "[3/3] app/dumpcap: check for failure to set promiscious", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1c3a6c09c02bef172a6496c62fc144241cbb5eae", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220210230906.833163-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 21615, "url": "https://patches.dpdk.org/api/series/21615/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21615", "date": "2022-02-10T23:09:03", "name": "small fixes suggested by Coverity scan", "version": 1, "mbox": "https://patches.dpdk.org/series/21615/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107308/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/107308/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4693A00BE;\n\tFri, 11 Feb 2022 00:09:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B7CD3411B6;\n\tFri, 11 Feb 2022 00:09:16 +0100 (CET)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 461D84118A\n for <dev@dpdk.org>; Fri, 11 Feb 2022 00:09:14 +0100 (CET)", "by mail-pj1-f44.google.com with SMTP id\n d9-20020a17090a498900b001b8bb1d00e7so7086106pjh.3\n for <dev@dpdk.org>; Thu, 10 Feb 2022 15:09:14 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n y191sm24924970pfb.114.2022.02.10.15.09.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 10 Feb 2022 15:09:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Fi69yJP2LkZgVtyLqlVcHS9KZ69M6S03JlecoZzEoK8=;\n b=NBfWlDUt0VL4rhFHaMpwFd7PLLFFVYGUL7k3wD05Vah7g8ICbZIJUatbHptjcyFTjf\n Q9ifBOA/MjM1NSQOn64cLsvfOKNH0WXhT6vqAZmjj9GuIVAfY05HSVBMOD3biNr1qK4m\n hHr6p0yIYKARMrI8FODriftO2WRHTGJo3ZM/iM6DUIYqaYMCZwivQxHy+cpHzKKxa6s+\n 9eos1f2ASzOvnKhzIGXk4D3N/TKHuwu0zSY7Hd3hjNA5LbhRn2bRy7rwDMS5vGuIWvhx\n 0G0Wn3mwb/lIvvJet9PwnWhRfbnNdd7SeV0faYQrQG8QwfiEoBZA3O23yPKSinqb6ibt\n SM8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Fi69yJP2LkZgVtyLqlVcHS9KZ69M6S03JlecoZzEoK8=;\n b=Jlgc6ndOqk+Q9uBH584z8Nh2H5UCUSNc8W5IeTO0DfWuUX606+IFWMAmaOS5nSEqDi\n xgCRbexOpvPTXXaeh0kqhjqJ+SM3IhBtikXnzsrsGc6uT9Op8tEPKajBPh+LE0baEq86\n zwf5MGb5Xc6r6SK31tf2It/txpwLYpzZVwmB1FHjrGSrI0JRJEUIDK5sRZaCKfe3Iarq\n djP7QcmlmbY6+6Fg0eLxAyNtXWTYTR5nY3nNcS7OTC7HalzllJFmU+IRVWnnTl0SYWFI\n ohryxWuklmUUaeQLB7gi4PoVFBeiU9u3hIL1+79ZGK7V3s89F3WTriO6wrhs+HXTlgKl\n aNxQ==", "X-Gm-Message-State": "AOAM531Bl4Y4gMfQJPUMERFbGzPUNhx9PpM3QccSNxpfsjtY4Atws4o4\n vXTmCzhVDvg40MP0GWXyYER7OPbRCjR1t5mW", "X-Google-Smtp-Source": "\n ABdhPJx09TK+ALAMus+ZX3j87UgJ4fRWkDd+o8ek0mcGdz40I8JuysElXq+cZFle79OhQp7RFM+edg==", "X-Received": "by 2002:a17:903:24f:: with SMTP id\n j15mr9668901plh.16.1644534553139;\n Thu, 10 Feb 2022 15:09:13 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 3/3] app/dumpcap: check for failure to set promiscious", "Date": "Thu, 10 Feb 2022 15:09:06 -0800", "Message-Id": "<20220210230906.833163-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220210230906.833163-1-stephen@networkplumber.org>", "References": "<20220210230906.833163-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If the rte_eth_promiscious_enable() fails, then log the error\nand continue.\n\nCoverity issue: 373662\nFixes: cbb44143be74 (\"app/dumpcap: add new packet capture application\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex c5fe4403028a..21cb2810a48f 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -679,8 +679,13 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)\n \t\tflags |= RTE_PDUMP_FLAG_PCAPNG;\n \n \tTAILQ_FOREACH(intf, &interfaces, next) {\n-\t\tif (promiscuous_mode)\n-\t\t\trte_eth_promiscuous_enable(intf->port);\n+\t\tif (promiscuous_mode) {\n+\t\t\tret = rte_eth_promiscuous_enable(intf->port);\n+\t\t\tif (ret != 0)\n+\t\t\t\tfprintf(stderr,\n+\t\t\t\t\t\"port %u set promicious enable faile: %d\\n\",\n+\t\t\t\t\tintf->port, ret);\n+\t\t}\n \n \t\tret = rte_pdump_enable_bpf(intf->port, RTE_PDUMP_ALL_QUEUES,\n \t\t\t\t\t flags, snaplen,\n", "prefixes": [ "3/3" ] }