Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107151/?format=api
{ "id": 107151, "url": "https://patches.dpdk.org/api/patches/107151/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220209191748.377729-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220209191748.377729-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220209191748.377729-7-stephen@networkplumber.org", "date": "2022-02-09T19:17:18", "name": "[v3,06/36] vhost: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "85b8a4cd8f05b9dba4dc985ff2868772a14b81ce", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220209191748.377729-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 21575, "url": "https://patches.dpdk.org/api/series/21575/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21575", "date": "2022-02-09T19:17:12", "name": "remove unnecessary null checks", "version": 3, "mbox": "https://patches.dpdk.org/series/21575/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/107151/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/107151/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E9CEA034E;\n\tWed, 9 Feb 2022 20:18:35 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6BD0F41180;\n\tWed, 9 Feb 2022 20:18:01 +0100 (CET)", "from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 7874B4116A\n for <dev@dpdk.org>; Wed, 9 Feb 2022 20:17:59 +0100 (CET)", "by mail-pj1-f52.google.com with SMTP id y9so3015235pjf.1\n for <dev@dpdk.org>; Wed, 09 Feb 2022 11:17:59 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n u16sm14378401pgh.54.2022.02.09.11.17.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Feb 2022 11:17:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=dx0GDNS1IEnXCXXkXwkqFDbtlTWkh5y6TU4A4vrKqHs=;\n b=zA91HEtSvp6wtfyoNwB5Co9IrhsAgfeVfcwErNK1r087MYfnvcDkQhy1/aCijsFpd8\n MjC77KbC75dQA7w+mGC0rm8P9J36wGO6WHAgeB0fCqFYE4HwGxcECtOWK5L0Rba80F8g\n vNO5ppJFuB4PJzDBs3bI21dTIKQxeRDbCpFluiTUyxPB9FOyNlDh33FeZZWEDiAPFd3a\n Udi93qw5PdVHlZDovy7kL5lZxtWW2FmhLE1hJiJtVEA/2/tVW24aEnNUiXO+P52HVDQm\n JwwBKl4HSF2H2MIuutXdgIjatdRkNwU4awRkLeblVASLPI2ebkS9sIz0rbZT+fU/Td7G\n YlsQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=dx0GDNS1IEnXCXXkXwkqFDbtlTWkh5y6TU4A4vrKqHs=;\n b=RKxHnIZ9pFadaqjOlNyjLBp221baLPndgk9nyQyDtl6Wgkp0nBpev/ltwPiBj9XMsB\n rIe/cnDt5tRdTKQxVSwSVRQgm2JD8B3Etg1ai6ULVhJ5Gj56KzReJDH8CPdVnS3dFxlf\n 8ihzG2lszOvVBfDs3nzTOxKgJst1gkvCH2bi5OvEsig+xc34H24QTinLadWfzo41lh4D\n 1lKGXvImJUHy8IuZbUW1m+PvaXFOrPtYBnYDUbnjLnT+V3ciyGaEP1G3JbK9WOclR2Bw\n CgOdOGk/Zy63cSoo5LWmkKojYRV09m+2Q9QAJhbaNpL2x4rl2piVTe+hDb8HyHDzc3yP\n naDg==", "X-Gm-Message-State": "AOAM530LaUH6XnKu5c7Bx5rpBUoVohu6CnnlbSr2Iqu29Ebs+/pFCVSU\n e1KSOmHFaWSfbrE0zMpqwGg/8nLL15+Hq2rq", "X-Google-Smtp-Source": "\n ABdhPJyDUv56ydk6dVfFcqAtrWg5UlRsqyeNeepHHzR/5Aq5m24YDSiHqrpvFzEg8R16t/fpfcomyw==", "X-Received": "by 2002:a17:90a:1de:: with SMTP id\n 30mr4211764pjd.177.1644434278463;\n Wed, 09 Feb 2022 11:17:58 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Chenbo Xia <chenbo.xia@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v3 06/36] vhost: remove unnecessary NULL checks", "Date": "Wed, 9 Feb 2022 11:17:18 -0800", "Message-Id": "<20220209191748.377729-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220209191748.377729-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>\n <20220209191748.377729-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/iotlb.c | 3 +--\n lib/vhost/vhost_crypto.c | 6 ++----\n lib/vhost/vhost_user.c | 9 +++------\n 3 files changed, 6 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c\nindex b24202a7eba3..5a5ba8b82a61 100644\n--- a/lib/vhost/iotlb.c\n+++ b/lib/vhost/iotlb.c\n@@ -324,8 +324,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index)\n \n \t/* If already created, free it and recreate */\n \tvq->iotlb_pool = rte_mempool_lookup(pool_name);\n-\tif (vq->iotlb_pool)\n-\t\trte_mempool_free(vq->iotlb_pool);\n+\trte_mempool_free(vq->iotlb_pool);\n \n \tvq->iotlb_pool = rte_mempool_create(pool_name,\n \t\t\tIOTLB_CACHE_SIZE, sizeof(struct vhost_iotlb_entry), 0,\ndiff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c\nindex 926b5c0bd94a..012e0cefdeba 100644\n--- a/lib/vhost/vhost_crypto.c\n+++ b/lib/vhost/vhost_crypto.c\n@@ -1498,10 +1498,8 @@ rte_vhost_crypto_create(int vid, uint8_t cryptodev_id,\n \treturn 0;\n \n error_exit:\n-\tif (vcrypto->session_map)\n-\t\trte_hash_free(vcrypto->session_map);\n-\tif (vcrypto->mbuf_pool)\n-\t\trte_mempool_free(vcrypto->mbuf_pool);\n+\trte_hash_free(vcrypto->session_map);\n+\trte_mempool_free(vcrypto->mbuf_pool);\n \n \trte_free(vcrypto);\n \ndiff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex e8297a09eb73..b50e5ab5a9c4 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -488,8 +488,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev,\n \t}\n \n \tif (vq_is_packed(dev)) {\n-\t\tif (vq->shadow_used_packed)\n-\t\t\trte_free(vq->shadow_used_packed);\n+\t\trte_free(vq->shadow_used_packed);\n \t\tvq->shadow_used_packed = rte_malloc_socket(NULL,\n \t\t\t\tvq->size *\n \t\t\t\tsizeof(struct vring_used_elem_packed),\n@@ -502,8 +501,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev,\n \t\t}\n \n \t} else {\n-\t\tif (vq->shadow_used_split)\n-\t\t\trte_free(vq->shadow_used_split);\n+\t\trte_free(vq->shadow_used_split);\n \n \t\tvq->shadow_used_split = rte_malloc_socket(NULL,\n \t\t\t\tvq->size * sizeof(struct vring_used_elem),\n@@ -517,8 +515,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev,\n \t\t}\n \t}\n \n-\tif (vq->batch_copy_elems)\n-\t\trte_free(vq->batch_copy_elems);\n+\trte_free(vq->batch_copy_elems);\n \tvq->batch_copy_elems = rte_malloc_socket(NULL,\n \t\t\t\tvq->size * sizeof(struct batch_copy_elem),\n \t\t\t\tRTE_CACHE_LINE_SIZE, vq->numa_node);\n", "prefixes": [ "v3", "06/36" ] }