Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10695/?format=api
{ "id": 10695, "url": "https://patches.dpdk.org/api/patches/10695/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1455880025-6912-17-git-send-email-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1455880025-6912-17-git-send-email-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1455880025-6912-17-git-send-email-xiao.w.wang@intel.com", "date": "2016-02-19T11:07:03", "name": "[dpdk-dev,v3,16/18] fm10k/base: move constants to the right of binary operators", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ec42fce3892d32dc0d0d24f518f2936b00e4399f", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1455880025-6912-17-git-send-email-xiao.w.wang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10695/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 745C5C596;\n\tFri, 19 Feb 2016 12:08:52 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 6DB4BC55A\n\tfor <dev@dpdk.org>; Fri, 19 Feb 2016 12:08:50 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP; 19 Feb 2016 03:07:48 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 19 Feb 2016 03:07:47 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u1JB7j6u028279;\n\tFri, 19 Feb 2016 19:07:45 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u1JB7g6F007059; Fri, 19 Feb 2016 19:07:44 +0800", "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u1JB7g7p007055; \n\tFri, 19 Feb 2016 19:07:42 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,470,1449561600\"; d=\"scan'208\";a=\"50811139\"", "From": "Wang Xiao W <xiao.w.wang@intel.com>", "To": "jing.d.chen@intel.com", "Date": "Fri, 19 Feb 2016 19:07:03 +0800", "Message-Id": "<1455880025-6912-17-git-send-email-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1455880025-6912-1-git-send-email-xiao.w.wang@intel.com>", "References": "<1453866647-16215-2-git-send-email-xiao.w.wang@intel.com>\n\t<1455880025-6912-1-git-send-email-xiao.w.wang@intel.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v3 16/18] fm10k/base: move constants to the right\n\tof binary operators", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The upstream Linux kernel community prefers constants are to the right of\nbinary operators.\n\nSigned-off-by: Wang Xiao W <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_pf.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c\nindex 456fe64..105babf 100644\n--- a/drivers/net/fm10k/base/fm10k_pf.c\n+++ b/drivers/net/fm10k/base/fm10k_pf.c\n@@ -759,8 +759,8 @@ STATIC s32 fm10k_iov_assign_resources_pf(struct fm10k_hw *hw, u16 num_vfs,\n \t\t\t\t\tFM10K_RXDCTL_WRITE_BACK_MIN_DELAY |\n \t\t\t\t\tFM10K_RXDCTL_DROP_ON_EMPTY);\n \t\t\tFM10K_WRITE_REG(hw, FM10K_RXQCTL(vf_q_idx),\n-\t\t\t\t\tFM10K_RXQCTL_VF |\n-\t\t\t\t\t(i << FM10K_RXQCTL_VF_SHIFT));\n+\t\t\t\t\t(i << FM10K_RXQCTL_VF_SHIFT) |\n+\t\t\t\t\tFM10K_RXQCTL_VF);\n \n \t\t\t/* map queue pair to VF */\n \t\t\tFM10K_WRITE_REG(hw, FM10K_TQMAP(qmap_idx), vf_q_idx);\n@@ -1035,7 +1035,7 @@ STATIC s32 fm10k_iov_reset_resources_pf(struct fm10k_hw *hw,\n \ttxqctl = ((u32)vf_vid << FM10K_TXQCTL_VID_SHIFT) |\n \t\t (vf_idx << FM10K_TXQCTL_TC_SHIFT) |\n \t\t FM10K_TXQCTL_VF | vf_idx;\n-\trxqctl = FM10K_RXQCTL_VF | (vf_idx << FM10K_RXQCTL_VF_SHIFT);\n+\trxqctl = (vf_idx << FM10K_RXQCTL_VF_SHIFT) | FM10K_RXQCTL_VF;\n \n \t/* stop further DMA and reset queue ownership back to VF */\n \tfor (i = vf_q_idx; i < (queues_per_pool + vf_q_idx); i++) {\n", "prefixes": [ "dpdk-dev", "v3", "16/18" ] }