Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106727/?format=api
{ "id": 106727, "url": "https://patches.dpdk.org/api/patches/106727/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220131000516.76727-1-mikeb01@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220131000516.76727-1-mikeb01@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220131000516.76727-1-mikeb01@gmail.com", "date": "2022-01-31T00:05:16", "name": "[v5] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1bbd55180b356f8ace33e4057ce4a95da5ea41c", "submitter": { "id": 2484, "url": "https://patches.dpdk.org/api/people/2484/?format=api", "name": "Michael Barker", "email": "mikeb01@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220131000516.76727-1-mikeb01@gmail.com/mbox/", "series": [ { "id": 21430, "url": "https://patches.dpdk.org/api/series/21430/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21430", "date": "2022-01-31T00:05:16", "name": "[v5] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.", "version": 5, "mbox": "https://patches.dpdk.org/series/21430/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/106727/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/106727/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70452A0352;\n\tMon, 31 Jan 2022 01:05:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0056410E1;\n\tMon, 31 Jan 2022 01:05:37 +0100 (CET)", "from mail-pj1-f50.google.com (mail-pj1-f50.google.com\n [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 9236640E25\n for <dev@dpdk.org>; Mon, 31 Jan 2022 01:05:36 +0100 (CET)", "by mail-pj1-f50.google.com with SMTP id d5so12253057pjk.5\n for <dev@dpdk.org>; Sun, 30 Jan 2022 16:05:36 -0800 (PST)", "from plinth.fritz.box ([151.210.134.32])\n by smtp.googlemail.com with ESMTPSA id ga21sm5283252pjb.2.2022.01.30.16.05.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 30 Jan 2022 16:05:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=xWY1zfdhYcyLrtiHRYazzUb24f0ZwWlEHNuvgHHPfz4=;\n b=L6X6Vrr2GYaDVlQyXCvCKFXO0v8keIfKklweqE7Olw2hA3oHSBLzBGLajfw/jJEdvu\n lH6OdMmo2CQ83PlAGkoma6evflz842DqfiRveCVpKTyqhZ01sK3NIPUsfe4zKMBrGFKO\n hMD/RO9DpCX+IcJUlrj12P3gowIKqSYpJf7A+9hiRbK0opzRG4pVPE7eFxFBwtjEdk9I\n Wk9HHYayVevQM0FiNsEEcdUf3CpdnqjwxnyBdl7bFCis6bp5q2h0jMeYA73EXT37cI9/\n gh11r/mSMUwAfgOnp99MeamXM95lYLRd0CC8GQJvD/J/2k0MOuVHAiCn3Jhr4ixoWiNw\n oskg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=xWY1zfdhYcyLrtiHRYazzUb24f0ZwWlEHNuvgHHPfz4=;\n b=jd9ovg3SVjOtBSsS2cfRgZufxZs3vzz0zD26SM3ZtqMBOuoEh4r/I0+XCWg1UV6Osx\n imyWtVscdX+CTYU+pV58f9FzCE3qzxgWYrUv6ekMiTBEYMBQ2VVvcW07Q83GiAtDX8LK\n /nLvrGwd92HUmR3QixxinDZuVY5i+ja7ilqB/YgesnNuAUgpJevAmGQwnoRo7ZPNIPyz\n sFbuLR1kiL/Lbc7e06DdEg1Ch1vpZP7Fh3N22Y3o+Qm5GQdFYffXDn1+jpNrjJx8ejtj\n JtSXbarrBzmvrYGqPPBKkZ87ZpLYVJC/wY1JNN0GT8XVyrIjB8Lhec8eax4TG+1xsKOq\n zbOA==", "X-Gm-Message-State": "AOAM531cy1IUQwktkmiZQbWbHLVz3GC3M1+GDccHitcDGONeJ0ILkZEn\n 4F21aJZNYKHIhX6lmJGFNo5zU5cgll4KFg==", "X-Google-Smtp-Source": "\n ABdhPJzvAhT14v+6DN863IWhJ4OpsGYuFpfPvWV7nVOvjkF3BYfFGClhPZTnmZyb5eG3dfOs9IHYIw==", "X-Received": "by 2002:a17:902:d2d2:: with SMTP id\n n18mr18584113plc.0.1643587535522;\n Sun, 30 Jan 2022 16:05:35 -0800 (PST)", "From": "Michael Barker <mikeb01@gmail.com>", "To": "dev@dpdk.org", "Cc": "Michael Barker <mikeb01@gmail.com>,\n\tRay Kinsella <mdr@ashroe.eu>", "Subject": "[PATCH v5] Add pragma to ignore gcc-compat warnings in clang when\n used with diagnose_if.", "Date": "Mon, 31 Jan 2022 13:05:16 +1300", "Message-Id": "<20220131000516.76727-1-mikeb01@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220123212024.19747-1-mikeb01@gmail.com>", "References": "<20220123212024.19747-1-mikeb01@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When compiling with clang using -Wpedantic (or -Wgcc-compat) the use of\ndiagnose_if kicks up a warning:\n\n.../include/rte_interrupts.h:623:1: error: 'diagnose_if' is a clang\nextension [-Werror,-Wgcc-compat]\n__rte_internal\n^\n.../include/rte_compat.h:36:16: note: expanded from macro '__rte_internal'\n__attribute__((diagnose_if(1, \"Symbol is not public ABI\", \"error\"), \\\n\nThis change ignores the '-Wgcc-compat' warning in the specific location\nwhere the warning occurs. It is safe to do in this circumstance as the\nspecific macro is only defined when using the clang compiler.\n\nSigned-off-by: Michael Barker <mikeb01@gmail.com>\n---\n lib/eal/include/rte_compat.h | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/include/rte_compat.h b/lib/eal/include/rte_compat.h\nindex 2718612cce..9556bbf4d0 100644\n--- a/lib/eal/include/rte_compat.h\n+++ b/lib/eal/include/rte_compat.h\n@@ -33,8 +33,11 @@ section(\".text.internal\")))\n #elif !defined ALLOW_INTERNAL_API && __has_attribute(diagnose_if) /* For clang */\n \n #define __rte_internal \\\n+_Pragma(\"GCC diagnostic push\") \\\n+_Pragma(\"GCC diagnostic ignored \\\"-Wgcc-compat\\\"\") \\\n __attribute__((diagnose_if(1, \"Symbol is not public ABI\", \"error\"), \\\n-section(\".text.internal\")))\n+section(\".text.internal\"))) \\\n+_Pragma(\"GCC diagnostic pop\")\n \n #else\n \n", "prefixes": [ "v5" ] }