Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106241/?format=api
{ "id": 106241, "url": "https://patches.dpdk.org/api/patches/106241/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-3-stephen@networkplumber.org", "date": "2022-01-24T00:03:58", "name": "[02/82] eal: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16a54c64d4a7f2be218e6592d33559a42647f3fb", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "https://patches.dpdk.org/api/series/21315/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "https://patches.dpdk.org/series/21315/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/106241/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/106241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4D2CA04A6;\n\tMon, 24 Jan 2022 01:05:35 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7C2D2427B8;\n\tMon, 24 Jan 2022 01:05:26 +0100 (CET)", "from mail-pj1-f43.google.com (mail-pj1-f43.google.com\n [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 75A8740040\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:05:24 +0100 (CET)", "by mail-pj1-f43.google.com with SMTP id\n s61-20020a17090a69c300b001b4d0427ea2so18757874pjj.4\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:05:24 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.05.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:05:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=;\n b=WCno3oN6jWVoA2MTmqLEMukEXE/TbbB+rSIzazHhasoToTBO+cVeau8PLm8ZwVF/dQ\n 99atH59YaiF7PL1ojgNuQXrLndIRYz/c8CrV+SmAafYdle03IIxAhbQVXAgSsp7WO3V2\n nh6rSR1ELr9ruQOHNm+FYX28UHKb6QUqEjOF30vvyS/WxnYi39LlWfNH7A1Sqn6V/vD6\n /xayUxoVeBG78/FWN3MEy5Qbbb32NLGfb/6KxwPmrMb4TOqLxbu+4LIhpbNZiJSLGaWb\n sz72CBsfvPmuANl9M6AG17jDg9y86G3NAs8ziA/r3WXDLwUwOCRhyzefncCRW3+urrWo\n CnnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=;\n b=aFIaK+eTAAPYpq6IiWezj3W2oEEG8n55NOab3bVdmhOzIPl1Ec60nn2jcefN+XV3tF\n 73XqACXmzU2bmtaXuFHfHgXVUPRNsxZnp5GgnSF7GD6wDj2+IEshvgq/3qLyX9YjLQAv\n eE2t9aw4Fs2ZU47AZpwA6ucMvUJ38lKHOiZ9tDe8Oq57Q51GRLdj9iNhU/Kddq+5Rcqy\n 1K4sEJFN66UBbUcVMfNcuJEF0vdEa0ZnqYLMkXcSDo9+SyVfHDg5V38RP0vo07TA68I+\n U6QmnN2NA9UnEHlyPyNObDsaTvXGu2zCtzFZtb/7FhrqrWRRBzEJwMPxXSw08XNMmx+O\n emVg==", "X-Gm-Message-State": "AOAM531MLot5fZ3sBjIKtaZ09h+N83Y49+4Ds+49O0PnABVr2yL63bD+\n mW0FXDq48di1pHPWXIquhny9Yclz5cau5A==", "X-Google-Smtp-Source": "\n ABdhPJw1cLLJ/PRgXz8Hzd2Lvr+nMIklXUWA7f+HOBXbh3dzLy647wSxoe57wUKd9mPnVHbmzeAh4A==", "X-Received": "by 2002:a17:90a:d596:: with SMTP id\n v22mr10723297pju.87.1642982723439;\n Sun, 23 Jan 2022 16:05:23 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 02/82] eal: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:03:58 -0800", "Message-Id": "<20220124000518.319850-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Functions like free() already handle NULL pointer so\nthe checks here are not necessary.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_devargs.c | 6 ++----\n lib/eal/common/eal_common_memzone.c | 3 +--\n lib/eal/common/eal_common_options.c | 9 +++------\n lib/eal/common/eal_common_trace_ctf.c | 6 ++----\n lib/eal/freebsd/eal.c | 4 +---\n lib/eal/linux/eal.c | 10 +++-------\n 6 files changed, 12 insertions(+), 26 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c\nindex 8c7650cf6c27..69004b0a2d2f 100644\n--- a/lib/eal/common/eal_common_devargs.c\n+++ b/lib/eal/common/eal_common_devargs.c\n@@ -161,8 +161,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \n get_out:\n \tfor (i = 0; i < RTE_DIM(layers); i++) {\n-\t\tif (layers[i].kvlist)\n-\t\t\trte_kvargs_free(layers[i].kvlist);\n+\t\trte_kvargs_free(layers[i].kvlist);\n \t}\n \tif (ret != 0) {\n \t\tif (allocated_data) {\n@@ -285,8 +284,7 @@ rte_devargs_reset(struct rte_devargs *da)\n {\n \tif (da == NULL)\n \t\treturn;\n-\tif (da->data)\n-\t\tfree(da->data);\n+\tfree(da->data);\n \tda->data = NULL;\n }\n \ndiff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c\nindex ecde9441ee90..9a0c5309ac7e 100644\n--- a/lib/eal/common/eal_common_memzone.c\n+++ b/lib/eal/common/eal_common_memzone.c\n@@ -300,8 +300,7 @@ rte_memzone_free(const struct rte_memzone *mz)\n \n \trte_rwlock_write_unlock(&mcfg->mlock);\n \n-\tif (addr != NULL)\n-\t\trte_free(addr);\n+\trte_free(addr);\n \n \trte_eal_trace_memzone_free(name, addr, ret);\n \treturn ret;\ndiff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex 1cfdd75f3b79..09b7b17ffa06 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -1962,12 +1962,9 @@ compute_ctrl_threads_cpuset(struct internal_config *internal_cfg)\n int\n eal_cleanup_config(struct internal_config *internal_cfg)\n {\n-\tif (internal_cfg->hugefile_prefix != NULL)\n-\t\tfree(internal_cfg->hugefile_prefix);\n-\tif (internal_cfg->hugepage_dir != NULL)\n-\t\tfree(internal_cfg->hugepage_dir);\n-\tif (internal_cfg->user_mbuf_pool_ops_name != NULL)\n-\t\tfree(internal_cfg->user_mbuf_pool_ops_name);\n+\tfree(internal_cfg->hugefile_prefix);\n+\tfree(internal_cfg->hugepage_dir);\n+\tfree(internal_cfg->user_mbuf_pool_ops_name);\n \n \treturn 0;\n }\ndiff --git a/lib/eal/common/eal_common_trace_ctf.c b/lib/eal/common/eal_common_trace_ctf.c\nindex 33e419aac7fb..3b83bcdf57fd 100644\n--- a/lib/eal/common/eal_common_trace_ctf.c\n+++ b/lib/eal/common/eal_common_trace_ctf.c\n@@ -52,8 +52,7 @@ meta_copy(char **meta, int *offset, char *str, int rc)\n \treturn rc;\n \n free_str:\n-\tif (str)\n-\t\tfree(str);\n+\tfree(str);\n \treturn -ENOMEM;\n }\n \n@@ -291,8 +290,7 @@ trace_metadata_create(void)\n \treturn 0;\n \n fail:\n-\tif (meta)\n-\t\tfree(meta);\n+\tfree(meta);\n \treturn -EBADF;\n }\n \ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex a1cd2462db1b..00ba32f1d664 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -544,9 +544,7 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not store mbuf pool ops name\\n\");\n \t\t\telse {\n \t\t\t\t/* free old ops name */\n-\t\t\t\tif (internal_conf->user_mbuf_pool_ops_name !=\n-\t\t\t\t\t\tNULL)\n-\t\t\t\t\tfree(internal_conf->user_mbuf_pool_ops_name);\n+\t\t\t\tfree(internal_conf->user_mbuf_pool_ops_name);\n \n \t\t\t\tinternal_conf->user_mbuf_pool_ops_name =\n \t\t\t\t\t\tops_name;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 60b49248388e..f8e39b7e4277 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -730,8 +730,7 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not store hugepage directory\\n\");\n \t\t\telse {\n \t\t\t\t/* free old hugepage dir */\n-\t\t\t\tif (internal_conf->hugepage_dir != NULL)\n-\t\t\t\t\tfree(internal_conf->hugepage_dir);\n+\t\t\t\tfree(internal_conf->hugepage_dir);\n \t\t\t\tinternal_conf->hugepage_dir = hdir;\n \t\t\t}\n \t\t\tbreak;\n@@ -743,8 +742,7 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not store file prefix\\n\");\n \t\t\telse {\n \t\t\t\t/* free old prefix */\n-\t\t\t\tif (internal_conf->hugefile_prefix != NULL)\n-\t\t\t\t\tfree(internal_conf->hugefile_prefix);\n+\t\t\t\tfree(internal_conf->hugefile_prefix);\n \t\t\t\tinternal_conf->hugefile_prefix = prefix;\n \t\t\t}\n \t\t\tbreak;\n@@ -804,9 +802,7 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not store mbuf pool ops name\\n\");\n \t\t\telse {\n \t\t\t\t/* free old ops name */\n-\t\t\t\tif (internal_conf->user_mbuf_pool_ops_name !=\n-\t\t\t\t\t\tNULL)\n-\t\t\t\t\tfree(internal_conf->user_mbuf_pool_ops_name);\n+\t\t\t\tfree(internal_conf->user_mbuf_pool_ops_name);\n \n \t\t\t\tinternal_conf->user_mbuf_pool_ops_name =\n \t\t\t\t\t\tops_name;\n", "prefixes": [ "02/82" ] }