Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106240/?format=api
{ "id": 106240, "url": "https://patches.dpdk.org/api/patches/106240/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-2-stephen@networkplumber.org", "date": "2022-01-24T00:03:57", "name": "[01/82] devtools/cocci: add script to fix unnecessary null checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3bc62994b1e0c2f1cc8bd78296a3059a8bee916d", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "https://patches.dpdk.org/api/series/21315/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "https://patches.dpdk.org/series/21315/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/106240/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/106240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4CF3AA04A6;\n\tMon, 24 Jan 2022 01:05:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A1417427AF;\n\tMon, 24 Jan 2022 01:05:25 +0100 (CET)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 62FDB40040\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:05:23 +0100 (CET)", "by mail-pl1-f179.google.com with SMTP id c9so13905876plg.11\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:05:23 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.05.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:05:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=lITO3Kqqs+aJDmQXmNqdZndLVIM4kiX6U7jq5x2Qwgc=;\n b=EOHdMVYMsbn6ap0AslbU8ne2uWLq+K9Nb2W5sd3sQOVeARbRrK6iRTfvFmUyMFi6NM\n 6qLz10IFNDQiBjl42E1SgFLPaEGZ8Ts9VshIQgehxz7NEHNjqMBbsAZi1OhMAtP/jpxx\n HVn/QfG2L4ENz1GXTTgRlvRtB55UzQxxbWNVVux41jDD3zdsrUtnGoinu6VOq+F8Y8qi\n ytpuMkUC+0ON8Ty6ae8n6DPfKy30TMMtsyuZvL4NxIjhBG3IEpP2lJ9wnHKQE/h7tfQ1\n NqAQfSmxcJmGJkN6Kc8hf6w357VZYklOXrzyzbGc5/dAPKlWzciSP6qv7AOm8pwRs11F\n ETKw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=lITO3Kqqs+aJDmQXmNqdZndLVIM4kiX6U7jq5x2Qwgc=;\n b=5bvYg7HxnmqWByql+NY8PGZEQMg/hE1S+DIG6WuyhB8U6eGgSrlhg8KD5HB7WHB/4N\n 4Sl8fVjAts4TticgTDjyr7HH1RKv9S+EROxuC+hZ3DaBzmn1Xa9WsKo6NdrKqliC6xpU\n 6kcWSWrDAlWgJWWGjxGH+JeTDByxvWOEImDBpiu20/YPtoOrpLGGP/r7RcNGaYjj8WOy\n Fc71g1+ff+DPN1URYq5ELFoVFrufAnu0ogBnLSCVCruEC4OAdN8UVN53DcqWe15o9d8q\n nZLl3JayIO5untKVkfpPSPX7YXXGGHTXCGry2btOJrgUZBZ75NeXcJQtJmeMejQRtxa0\n SXWA==", "X-Gm-Message-State": "AOAM532c9ZLBrGr5xTnmw+TxXoBAyVA4JRhvl1RuMpq3mi5YnZVZvzey\n mJa+FMrxb6kcjLIVrGhxrwQTTEkRQ/ZJ1Q==", "X-Google-Smtp-Source": "\n ABdhPJySqdU4whKgC/pqWH93q0F12el9SXaDti4Jh1sUaN5LbE9t/nwqwQ/svp9ojzB/Tz+D1VaaAg==", "X-Received": "by 2002:a17:90b:1909:: with SMTP id\n mp9mr6802970pjb.53.1642982722356;\n Sun, 23 Jan 2022 16:05:22 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 01/82] devtools/cocci: add script to fix unnecessary null\n checks", "Date": "Sun, 23 Jan 2022 16:03:57 -0800", "Message-Id": "<20220124000518.319850-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This script is based on the idea of the nullfree script\nin the Linux kernel. It finds cases where a check for null\npointer is done, but is unneccessary because the function\nalready handles NULL pointer.\n\nBasic example:\n if (x->buf)\n rte_free(x->buf);\ncan be reduced to:\n rte_free(x->buf);\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n devtools/cocci/nullfree.cocci | 33 +++++++++++++++++++++++++++++++++\n 1 file changed, 33 insertions(+)\n create mode 100644 devtools/cocci/nullfree.cocci", "diff": "diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci\nnew file mode 100644\nindex 000000000000..363b6149ac28\n--- /dev/null\n+++ b/devtools/cocci/nullfree.cocci\n@@ -0,0 +1,33 @@\n+//\n+// Remove unnecessary NULL pointer checks before free functions\n+// All these functions work like libc free which allows\n+// free(NULL) as a no-op.\n+//\n+@@\n+expression E;\n+@@\n+(\n+- if (E != NULL) free(E);\n++ free(E);\n+|\n+- if (E != NULL) rte_bitmap_free(E);\n++ rte_bitmap_free(E);\n+|\n+- if (E != NULL) rte_free(E);\n++ rte_free(E);\n+|\n+- if (E != NULL) rte_hash_free(E);\n++ rte_hash_free(E);\n+|\n+- if (E != NULL) rte_ring_free(E);\n++ rte_ring_free(E);\n+|\n+- if (E != NULL) rte_pktmbuf_free(E);\n++ rte_pktmbuf_free(E);\n+|\n+- if (E != NULL) rte_mempool_free(E);\n++ rte_mempool_free(E);\n+|\n+- if (E != NULL) rte_kvargs_free(E);\n++ rte_kvargs_free(E);\n+)\n", "prefixes": [ "01/82" ] }