Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105427/?format=api
{ "id": 105427, "url": "https://patches.dpdk.org/api/patches/105427/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/cd154330e9781fec333b976b2b1da2d36c4b4b51.1640426040.git.songyl@ramaxel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cd154330e9781fec333b976b2b1da2d36c4b4b51.1640426040.git.songyl@ramaxel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cd154330e9781fec333b976b2b1da2d36c4b4b51.1640426040.git.songyl@ramaxel.com", "date": "2021-12-25T11:29:06", "name": "[v4,18/25] net/spnic: support VLAN filtering and offloading", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "31998246890b70a8fcdad9f6699c2df361d5ee79", "submitter": { "id": 2455, "url": "https://patches.dpdk.org/api/people/2455/?format=api", "name": "Yanling Song", "email": "songyl@ramaxel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/cd154330e9781fec333b976b2b1da2d36c4b4b51.1640426040.git.songyl@ramaxel.com/mbox/", "series": [ { "id": 21028, "url": "https://patches.dpdk.org/api/series/21028/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=21028", "date": "2021-12-25T11:28:48", "name": "Net/SPNIC: support SPNIC into DPDK 22.03", "version": 4, "mbox": "https://patches.dpdk.org/series/21028/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/105427/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/105427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB5E6A04A2;\n\tSat, 25 Dec 2021 12:32:02 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 62DED426E9;\n\tSat, 25 Dec 2021 12:30:19 +0100 (CET)", "from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id 712FF411FB\n for <dev@dpdk.org>; Sat, 25 Dec 2021 12:30:17 +0100 (CET)", "from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local\n [172.26.18.31])\n by VLXDG1SPAM1.ramaxel.com with ESMTPS id 1BPBTbRQ059971\n (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);\n Sat, 25 Dec 2021 19:29:37 +0800 (GMT-8)\n (envelope-from songyl@ramaxel.com)", "from localhost.localdomain (10.64.9.47) by V12DG1MBS01.ramaxel.local\n (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sat, 25\n Dec 2021 19:29:36 +0800" ], "From": "Yanling Song <songyl@ramaxel.com>", "To": "<dev@dpdk.org>", "CC": "<songyl@ramaxel.com>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,\n <xuyun@ramaxel.com>, <ferruh.yigit@intel.com>", "Subject": "[PATCH v4 18/25] net/spnic: support VLAN filtering and offloading", "Date": "Sat, 25 Dec 2021 19:29:06 +0800", "Message-ID": "\n <cd154330e9781fec333b976b2b1da2d36c4b4b51.1640426040.git.songyl@ramaxel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<cover.1640426040.git.songyl@ramaxel.com>", "References": "<cover.1640426040.git.songyl@ramaxel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.9.47]", "X-ClientProxiedBy": "V12DG1MBS03.ramaxel.local (172.26.18.33) To\n V12DG1MBS01.ramaxel.local (172.26.18.31)", "X-DNSRBL": "", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 1BPBTbRQ059971", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit implements vlan_filter_set() and vlan_offload_set()\nto support VLAN filtering and offloading.\n\nSigned-off-by: Yanling Song <songyl@ramaxel.com>\n---\n drivers/net/spnic/base/spnic_nic_cfg.c | 8 ++\n drivers/net/spnic/spnic_ethdev.c | 121 +++++++++++++++++++++++++\n 2 files changed, 129 insertions(+)", "diff": "diff --git a/drivers/net/spnic/base/spnic_nic_cfg.c b/drivers/net/spnic/base/spnic_nic_cfg.c\nindex ddaecba95d..d54b017434 100644\n--- a/drivers/net/spnic/base/spnic_nic_cfg.c\n+++ b/drivers/net/spnic/base/spnic_nic_cfg.c\n@@ -294,6 +294,14 @@ static int spnic_config_vlan(void *hwdev, u8 opcode, u16 vlan_id, u16 func_id)\n \treturn 0;\n }\n \n+int spnic_add_vlan(void *hwdev, u16 vlan_id, u16 func_id)\n+{\n+\tif (!hwdev)\n+\t\treturn -EINVAL;\n+\n+\treturn spnic_config_vlan(hwdev, SPNIC_CMD_OP_ADD, vlan_id, func_id);\n+}\n+\n int spnic_del_vlan(void *hwdev, u16 vlan_id, u16 func_id)\n {\n \tif (!hwdev)\ndiff --git a/drivers/net/spnic/spnic_ethdev.c b/drivers/net/spnic/spnic_ethdev.c\nindex cca03b5115..5b1c67c90f 100644\n--- a/drivers/net/spnic/spnic_ethdev.c\n+++ b/drivers/net/spnic/spnic_ethdev.c\n@@ -1258,6 +1258,123 @@ static int spnic_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n \treturn err;\n }\n \n+/**\n+ * Add or delete vlan id.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[in] vlan_id\n+ * Vlan id is used to filter vlan packets\n+ * @param[in] enable\n+ * Disable or enable vlan filter function\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id,\n+\t\t\t\t int enable)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tint err = 0;\n+\tu16 func_id;\n+\n+\tif (vlan_id >= RTE_ETHER_MAX_VLAN_ID)\n+\t\treturn -EINVAL;\n+\n+\tif (vlan_id == 0)\n+\t\treturn 0;\n+\n+\tfunc_id = spnic_global_func_id(nic_dev->hwdev);\n+\n+\tif (enable) {\n+\t\t/* If vlanid is already set, just return */\n+\t\tif (spnic_find_vlan_filter(nic_dev, vlan_id)) {\n+\t\t\tPMD_DRV_LOG(INFO, \"Vlan %u has been added, device: %s\",\n+\t\t\t\t vlan_id, nic_dev->dev_name);\n+\t\t\treturn 0;\n+\t\t}\n+\n+\t\terr = spnic_add_vlan(nic_dev->hwdev, vlan_id, func_id);\n+\t} else {\n+\t\t/* If vlanid can't be found, just return */\n+\t\tif (!spnic_find_vlan_filter(nic_dev, vlan_id)) {\n+\t\t\tPMD_DRV_LOG(INFO, \"Vlan %u is not in the vlan filter list, device: %s\",\n+\t\t\t\t vlan_id, nic_dev->dev_name);\n+\t\t\treturn 0;\n+\t\t}\n+\n+\t\terr = spnic_del_vlan(nic_dev->hwdev, vlan_id, func_id);\n+\t}\n+\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"%s vlan failed, func_id: %d, vlan_id: %d, err: %d\",\n+\t\t\t enable ? \"Add\" : \"Remove\", func_id, vlan_id, err);\n+\t\treturn err;\n+\t}\n+\n+\tspnic_store_vlan_filter(nic_dev, vlan_id, enable);\n+\n+\tPMD_DRV_LOG(INFO, \"%s vlan %u succeed, device: %s\",\n+\t\t enable ? \"Add\" : \"Remove\", vlan_id, nic_dev->dev_name);\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Enable or disable vlan offload.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[in] mask\n+ * Definitions used for VLAN setting, vlan filter of vlan strip\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tstruct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;\n+\tbool on;\n+\tint err;\n+\n+\t/* Enable or disable VLAN filter */\n+\tif (mask & ETH_VLAN_FILTER_MASK) {\n+\t\ton = (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) ?\n+\t\t true : false;\n+\t\terr = spnic_set_vlan_fliter(nic_dev->hwdev, on);\n+\t\tif (err) {\n+\t\t\tPMD_DRV_LOG(ERR, \"%s vlan filter failed, device: %s, port_id: %d, err: %d\",\n+\t\t\t\t on ? \"Enable\" : \"Disable\",\n+\t\t\t\t nic_dev->dev_name, dev->data->port_id, err);\n+\t\t\treturn err;\n+\t\t}\n+\n+\t\tPMD_DRV_LOG(INFO, \"%s vlan filter succeed, device: %s, port_id: %d\",\n+\t\t\t on ? \"Enable\" : \"Disable\",\n+\t\t\t nic_dev->dev_name, dev->data->port_id);\n+\t}\n+\n+\t/* Enable or disable VLAN stripping */\n+\tif (mask & ETH_VLAN_STRIP_MASK) {\n+\t\ton = (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) ?\n+\t\t true : false;\n+\t\terr = spnic_set_rx_vlan_offload(nic_dev->hwdev, on);\n+\t\tif (err) {\n+\t\t\tPMD_DRV_LOG(ERR, \"%s vlan strip failed, device: %s, port_id: %d, err: %d\",\n+\t\t\t\t on ? \"Enable\" : \"Disable\",\n+\t\t\t\t nic_dev->dev_name, dev->data->port_id, err);\n+\t\t\treturn err;\n+\t\t}\n+\n+\t\tPMD_DRV_LOG(INFO, \"%s vlan strip succeed, device: %s, port_id: %d\",\n+\t\t\t on ? \"Enable\" : \"Disable\",\n+\t\t\t nic_dev->dev_name, dev->data->port_id);\n+\t}\n+\n+\treturn 0;\n+}\n+\n \n /**\n * Update the RSS hash key and RSS hash type.\n@@ -1692,6 +1809,8 @@ static const struct eth_dev_ops spnic_pmd_ops = {\n \t.dev_stop = spnic_dev_stop,\n \t.dev_close = spnic_dev_close,\n \t.mtu_set = spnic_dev_set_mtu,\n+\t.vlan_filter_set = spnic_vlan_filter_set,\n+\t.vlan_offload_set = spnic_vlan_offload_set,\n \t.rss_hash_update = spnic_rss_hash_update,\n \t.rss_hash_conf_get = spnic_rss_conf_get,\n \t.reta_update = spnic_rss_reta_update,\n@@ -1715,6 +1834,8 @@ static const struct eth_dev_ops spnic_pmd_vf_ops = {\n \t.dev_stop = spnic_dev_stop,\n \t.dev_close = spnic_dev_close,\n \t.mtu_set = spnic_dev_set_mtu,\n+\t.vlan_filter_set = spnic_vlan_filter_set,\n+\t.vlan_offload_set = spnic_vlan_offload_set,\n \t.rss_hash_update = spnic_rss_hash_update,\n \t.rss_hash_conf_get = spnic_rss_conf_get,\n \t.reta_update = spnic_rss_reta_update,\n", "prefixes": [ "v4", "18/25" ] }