Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10444/?format=api
{ "id": 10444, "url": "https://patches.dpdk.org/api/patches/10444/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1455034146-24036-1-git-send-email-woz@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1455034146-24036-1-git-send-email-woz@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1455034146-24036-1-git-send-email-woz@semihalf.com", "date": "2016-02-09T16:09:06", "name": "[dpdk-dev,v2] af_packet: make the device detachable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "86960d7571eb5dd0004a84f1993403e0bb03c49f", "submitter": { "id": 260, "url": "https://patches.dpdk.org/api/people/260/?format=api", "name": "Wojciech Zmuda", "email": "woz@semihalf.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1455034146-24036-1-git-send-email-woz@semihalf.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10444/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 554589A88;\n\tTue, 9 Feb 2016 17:09:20 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 82DB92E83\n\tfor <dev@dpdk.org>; Tue, 9 Feb 2016 17:09:18 +0100 (CET)", "by mail-wm0-f52.google.com with SMTP id g62so180843542wme.0\n\tfor <dev@dpdk.org>; Tue, 09 Feb 2016 08:09:18 -0800 (PST)", "from woz.semihalf.local ([80.82.22.190])\n\tby smtp.gmail.com with ESMTPSA id\n\tgg7sm35422659wjd.10.2016.02.09.08.09.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 09 Feb 2016 08:09:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=siLmFUxdJFZFPcG8+1yD20/jE2N5R/8YcmGC6ztbQWQ=;\n\tb=xyf19tH9tjxrxOGBCtPkAuZWD9zljzs0e9NCGmt59CsH9AGBlEF3c+/jmCx2cp9Sj7\n\tz3Ktqb7QQz+PVISVw5TFrH7l1GN5EbT21L+SyQCik8Bxf7Dlz77LxYARwx0vqSb1ursT\n\t811nG6ocNRGBb+eJmzv6+qMWfbsHurYbIn7Q0CwrS801jI/z7EbZJyJCorzUbGjOyXzY\n\tmAQb4NQCJgxGmf3WrxvMS+Qo6PTkaaOur/s1OHcfnnzg040cp4vqPDB8Ky8QChNMzpDo\n\tcMRCWAB7HXaxZkeO3U+J32h9wtdnDIQBCF3ocfLTbx74isGhNCKHutJ33Xo0GcTPziDD\n\tOGiA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=siLmFUxdJFZFPcG8+1yD20/jE2N5R/8YcmGC6ztbQWQ=;\n\tb=eV4qOJf3qOdnxPkYj48g1X1+GpEprSzWDJpj5xPvNHuL/wcOu6boxlYamhAZ9K6zSo\n\ty37iyHCdO2st4Xa3qJWLjS78VXw5Q5xPrDs+AlByG3WcNEh4xUNmAHnQFCR6j1nFgyPS\n\t4sAfbmB/888x2czwP0joycjPbN5Qx19GunXVB2GWJj6Veu0IQEnLY4Mma01oD3LFtTf3\n\tB93bY/bvAyvm01JWxBQwo0uHb0Yin2fgXM3arleR9e4ho6rBaLMgD4J3YLgz2RTpFARy\n\tpGRgMIWoI6zkMV14QUQ7MzYapL1tQbsr/rArTAKW29lOWYLhMd+aDJFe9r/F7yRoHjNl\n\tPxCQ==", "X-Gm-Message-State": "AG10YOSzPDlR/xVG9mAlAauZJfwO+qZ5qif3lKdLUXFf7P85hhLmkRRv1dpszYQEj6r/wg==", "X-Received": "by 10.28.211.141 with SMTP id k135mr5468229wmg.51.1455034158345; \n\tTue, 09 Feb 2016 08:09:18 -0800 (PST)", "From": "Wojciech Zmuda <woz@semihalf.com>", "To": "bernard.iremonger@intel.com,\n\tdev@dpdk.org", "Date": "Tue, 9 Feb 2016 17:09:06 +0100", "Message-Id": "<1455034146-24036-1-git-send-email-woz@semihalf.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1452002675-8919-1-git-send-email-woz@semihalf.com>", "References": "<1452002675-8919-1-git-send-email-woz@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v2] af_packet: make the device detachable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implement rte_pmd_af_packet_devuninit() exposed through struct\nrte_driver.uninit() and set dev_flags to RTE_ETH_DEV_DETACHABLE,\nto allow af_packet device deinitialization with API function\nrte_eth_dev_detach(). This fixes memory leak by freeing memory\nallocated during initialization.\nDuring device initialization copy device name to ethdev->data to make\nit compatible with rte_eth_dev_allocated().\n\nSigned-off-by: Wojciech Zmuda <woz@semihalf.com>\n---\nv2:\n* Fixed typo and a comment.\n* Added feature to the 2.3 release notes.\n* Free memory allocated for rx and tx queues.\n\n doc/guides/rel_notes/release_2_3.rst | 4 ++++\n drivers/net/af_packet/rte_eth_af_packet.c | 37 ++++++++++++++++++++++++++++++-\n 2 files changed, 40 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst\nindex 7945694..4694646 100644\n--- a/doc/guides/rel_notes/release_2_3.rst\n+++ b/doc/guides/rel_notes/release_2_3.rst\n@@ -39,6 +39,10 @@ This section should contain new features added in this release. Sample format:\n \n Enabled virtio 1.0 support for virtio pmd driver.\n \n+* **Added af_packet driver deinitialization function.**\n+\n+ Implemented rte_pmd_af_packet_devuninit() exposed through struct\n+ rte_driver.uninit() to allow af_packet device deinitialization with API function.\n \n Resolved Issues\n ---------------\ndiff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 767f36b..eaed916 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -667,11 +667,13 @@ rte_pmd_init_internals(const char *name,\n \tdata->nb_tx_queues = (uint16_t)nb_queues;\n \tdata->dev_link = pmd_link;\n \tdata->mac_addrs = &(*internals)->eth_addr;\n+\tstrncpy(data->name,\n+\t\t(*eth_dev)->data->name, strlen((*eth_dev)->data->name));\n \n \t(*eth_dev)->data = data;\n \t(*eth_dev)->dev_ops = &ops;\n \t(*eth_dev)->driver = NULL;\n-\t(*eth_dev)->data->dev_flags = 0;\n+\t(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \t(*eth_dev)->data->drv_name = drivername;\n \t(*eth_dev)->data->kdrv = RTE_KDRV_NONE;\n \t(*eth_dev)->data->numa_node = numa_node;\n@@ -836,10 +838,43 @@ exit:\n \treturn ret;\n }\n \n+static int\n+rte_pmd_af_packet_devuninit(const char *name)\n+{\n+\tstruct rte_eth_dev *eth_dev = NULL;\n+\tstruct pmd_internals *internals;\n+\tunsigned q;\n+\n+\tRTE_LOG(INFO, PMD, \"Closing AF_PACKET ethdev on numa socket %u\\n\",\n+\t\t\trte_socket_id());\n+\n+\tif (name == NULL)\n+\t\treturn -1;\n+\n+\t/* find the ethdev entry */\n+\teth_dev = rte_eth_dev_allocated(name);\n+\tif (eth_dev == NULL)\n+\t\treturn -1;\n+\n+\tinternals = eth_dev->data->dev_private;\n+\tfor (q = 0; q < internals->nb_queues; q++) {\n+\t\trte_free(internals->rx_queue[q].rd);\n+\t\trte_free(internals->tx_queue[q].rd);\n+\t}\n+\n+\trte_free(eth_dev->data->dev_private);\n+\trte_free(eth_dev->data);\n+\n+\trte_eth_dev_release_port(eth_dev);\n+\n+\treturn 0;\n+}\n+\n static struct rte_driver pmd_af_packet_drv = {\n \t.name = \"eth_af_packet\",\n \t.type = PMD_VDEV,\n \t.init = rte_pmd_af_packet_devinit,\n+\t.uninit = rte_pmd_af_packet_devuninit,\n };\n \n PMD_REGISTER_DRIVER(pmd_af_packet_drv);\n", "prefixes": [ "dpdk-dev", "v2" ] }