Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104257/?format=api
{ "id": 104257, "url": "https://patches.dpdk.org/api/patches/104257/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211112214826.333853-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211112214826.333853-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211112214826.333853-2-dmitry.kozliuk@gmail.com", "date": "2021-11-12T21:48:24", "name": "[1/3] config/x86: skip GNU binutils bug check for LLVM", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5c959ac7704e6f3c748b37eaed37196e7f182e91", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211112214826.333853-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 20531, "url": "https://patches.dpdk.org/api/series/20531/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20531", "date": "2021-11-12T21:48:23", "name": "config/x86: improve AVX512 availability check", "version": 1, "mbox": "https://patches.dpdk.org/series/20531/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/104257/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/104257/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE95BA0032;\n\tFri, 12 Nov 2021 22:48:45 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1720C4113E;\n\tFri, 12 Nov 2021 22:48:40 +0100 (CET)", "from mail-lj1-f174.google.com (mail-lj1-f174.google.com\n [209.85.208.174])\n by mails.dpdk.org (Postfix) with ESMTP id A2CEC40692;\n Fri, 12 Nov 2021 22:48:38 +0100 (CET)", "by mail-lj1-f174.google.com with SMTP id v15so21216410ljc.0;\n Fri, 12 Nov 2021 13:48:38 -0800 (PST)", "from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id l5sm647917ljh.66.2021.11.12.13.48.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 12 Nov 2021 13:48:37 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=X8gVx2IHG5AOAvkwCD85HSCXNw60KEsgMx+g4CRtPrM=;\n b=mbGMlmY9OpptK2GVZVUJhPXVX0ZsV5rHCPzpYjhm0iMZTFGUs3QApAdO9AlogmPQB5\n yRMKDHK33kk9WB6okzXgUB8T3LDTLLwo5lnCkG6rBz6KPGQVCo6lkKHZOY4bJPDQ5KL+\n HsXrSzrfQQ0WjjRF/wP1mAcZT8ihXy+DJi7/vSlh8lgiibWXLcEfMvhQAKh69jfxvHPo\n ZeTSoisQNkog/qEhdVfwfVRumLYNuSgEyuPiMWk1hsXXap1okzlr1McAUj0DWiaRJJOh\n TzG0/SoOVsiQ9ZSbdkJYxjJ4wy7eVfnDYzZALUvIS/LuozgAMH0b8lHJnCzQXnXczrqO\n XI5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=X8gVx2IHG5AOAvkwCD85HSCXNw60KEsgMx+g4CRtPrM=;\n b=tqMGKbMsOFT4f8lYEgeJlna6VdaDBWJ+DXQv/nekdrmFvs23Dq4PHYxTxnH/bNXEZe\n /cDWqk3+yL9B0CdW/xha69jT0IzGTUY/P/g8f7PjzlXGebZsTryw5COmPHYJmH0uhxFM\n pLCKNdC6xEDJsiKqWbQ3pattocsdZ16ySkV27M7sYVxG8BHDRbWIoOS57cTKBgGORvSN\n 2ETv9Uz5xxarvj05BTGDB7lFMuKDsrYQxUjaFABOwRVgXlg7viuDJm94Q13kfgVWi2zB\n 96ocIl5jV1VBKM5q9E59kWbctVI0HKVczHrcyFp001opFVHqfg7qmJFSqyGSDtrAtd6y\n 60WQ==", "X-Gm-Message-State": "AOAM533X9+EEZWk8l5TQ90cn6PGUAlhYEwvV45X3aR8WS8IKazkKLQyA\n Ok7L5D/vJg4CnX4YLqgxP9+9dhZPSPI=", "X-Google-Smtp-Source": "\n ABdhPJyt0f82BSrzD3aYVYbZlyRtaF+O/yvrf3EaA+NNWXyYNydkAkpBOd5xLm2qOVoz46/Tez8aZg==", "X-Received": "by 2002:a05:651c:a0f:: with SMTP id\n k15mr19005913ljq.298.1636753718148;\n Fri, 12 Nov 2021 13:48:38 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, stable@dpdk.org,\n bruce.richardson@intel.com,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH 1/3] config/x86: skip GNU binutils bug check for LLVM", "Date": "Sat, 13 Nov 2021 00:48:24 +0300", "Message-Id": "<20211112214826.333853-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20211112214826.333853-1-dmitry.kozliuk@gmail.com>", "References": "<20211112214826.333853-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "AVX512 was disabled when GNU binutils were missing or had a known bug,\neven if LLVM binutils were used for the build,\nbecause binutils-avx512-check.sh was invoked regardless and failed.\nIn particular, this was the case for FreeBSD with clang (default).\nRun the check only when GNU binutils are used.\n\nFixes: 68b1f1cda5b4 (\"build: check AVX512 rather than binutils version\")\nCc: stable@dpdk.org\nCc: bruce.richardson@intel.com\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n config/x86/meson.build | 7 ++++---\n lib/acl/meson.build | 2 +-\n lib/fib/meson.build | 2 +-\n 3 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 29f3dea181..603359e55a 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -2,9 +2,10 @@\n # Copyright(c) 2017-2020 Intel Corporation\n \n # get binutils version for the workaround of Bug 97\n-if not is_windows\n- binutils_ok = run_command(binutils_avx512_check)\n- if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f')\n+binutils_ok = true\n+if not is_windows and (is_linux or cc.get_id() == 'gcc')\n+ binutils_ok = run_command(binutils_avx512_check).returncode() == 0\n+ if not binutils_ok and cc.has_argument('-mno-avx512f')\n machine_args += '-mno-avx512f'\n warning('Binutils error with AVX512 assembly, disabling AVX512 support')\n endif\ndiff --git a/lib/acl/meson.build b/lib/acl/meson.build\nindex f3dc513846..fbe17f9454 100644\n--- a/lib/acl/meson.build\n+++ b/lib/acl/meson.build\n@@ -36,7 +36,7 @@ if dpdk_conf.has('RTE_ARCH_X86')\n # compile AVX512 version if:\n # we are building 64-bit binary AND binutils can generate proper code\n \n- if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0\n+ if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok\n \n # compile AVX512 version if either:\n # a. we have AVX512 supported in minimum instruction set\ndiff --git a/lib/fib/meson.build b/lib/fib/meson.build\nindex 593c8c47c8..9b848d0841 100644\n--- a/lib/fib/meson.build\n+++ b/lib/fib/meson.build\n@@ -14,7 +14,7 @@ deps += ['rib']\n \n # compile AVX512 version if:\n # we are building 64-bit binary AND binutils can generate proper code\n-if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0\n+if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok\n # compile AVX512 version if either:\n # a. we have AVX512F supported in minimum instruction set baseline\n # b. it's not minimum instruction set, but supported by compiler\n", "prefixes": [ "1/3" ] }