Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104242/?format=api
{ "id": 104242, "url": "https://patches.dpdk.org/api/patches/104242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211112140111.922171-2-conor.walsh@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211112140111.922171-2-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211112140111.922171-2-conor.walsh@intel.com", "date": "2021-11-12T14:01:05", "name": "[1/7] app/test: fix unused but set variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1bfe21a6192345a2629696c33ccd7b4b733af6fe", "submitter": { "id": 1935, "url": "https://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211112140111.922171-2-conor.walsh@intel.com/mbox/", "series": [ { "id": 20523, "url": "https://patches.dpdk.org/api/series/20523/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20523", "date": "2021-11-12T14:01:04", "name": "fix unused but set variables", "version": 1, "mbox": "https://patches.dpdk.org/series/20523/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/104242/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/104242/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6C13A034F;\n\tFri, 12 Nov 2021 15:01:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95B50410EA;\n\tFri, 12 Nov 2021 15:01:38 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 3D03740692\n for <dev@dpdk.org>; Fri, 12 Nov 2021 15:01:37 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Nov 2021 06:01:36 -0800", "from silpixa00401160.ir.intel.com ([10.55.129.96])\n by orsmga007.jf.intel.com with ESMTP; 12 Nov 2021 06:01:26 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10165\"; a=\"319339528\"", "E=Sophos;i=\"5.87,229,1631602800\"; d=\"scan'208\";a=\"319339528\"", "E=Sophos;i=\"5.87,229,1631602800\"; d=\"scan'208\";a=\"493013357\"" ], "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n longfengx.liang@intel.com, dev@dpdk.org", "Cc": "david.hunt@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n bruce.richardson@intel.com, vladimir.medvedkin@intel.com,\n hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, fiona.trahe@intel.com,\n john.griffin@intel.com, deepak.k.jain@intel.com,\n harry.van.haaren@intel.com, ajit.khaparde@broadcom.com,\n somnath.kotur@broadcom.com, xuanziyang2@huawei.com,\n cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, sthotton@marvell.com,\n srinivasan@marvell.com, heinrich.kuhn@corigine.com, hkalra@marvell.com,\n rmody@marvell.com, dsinghrawat@marvell.com, jiawenwu@trustnetic.com,\n yongwang@vmware.com, john.mcnamara@intel.com, shreyansh.jain@nxp.com,\n santosh.shukla@caviumnetworks.com, gakhil@marvell.com,\n roy.fan.zhang@intel.com, arkadiuszx.kusztal@intel.com,\n michael.baucom@broadcom.com, venkatkumar.duvvuru@broadcom.com,\n lance.richardson@broadcom.com, kishore.padmanabha@broadcom.com,\n jerin.jacob@caviumnetworks.com, derek.chickles@caviumnetworks.com,\n ssrinivasan@caviumnetworks.com, mjatharakonda@oneconvergence.com,\n simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com,\n harish.patil@qlogic.com, stephen@networkplumber.org,\n tomaszx.kulasek@intel.com, ian.betts@intel.com, liang.j.ma@intel.com,\n lei.a.yao@intel.com, Conor Walsh <conor.walsh@intel.com>", "Subject": "[PATCH 1/7] app/test: fix unused but set variables", "Date": "Fri, 12 Nov 2021 14:01:05 +0000", "Message-Id": "<20211112140111.922171-2-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211112140111.922171-1-conor.walsh@intel.com>", "References": "<20211112140111.922171-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes unused but set variables within the following test apps:\n - test distributor perf\n - test thash perf\n\nBugzilla ID: 881\n\nFixes: c0de0eb82e40 (\"distributor: switch over to new API\")\nFixes: 239fffe0402e (\"test/thash: add performance tests for Toeplitz hash\")\n\nSigned-off-by: Conor Walsh <conor.walsh@intel.com>\nReported-by: Liang Longfeng <longfengx.liang@intel.com>\n---\n app/test/test_distributor_perf.c | 3 ---\n app/test/test_thash_perf.c | 2 ++\n 2 files changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c\nindex fdbeae6d2f..92e330f194 100644\n--- a/app/test/test_distributor_perf.c\n+++ b/app/test/test_distributor_perf.c\n@@ -108,7 +108,6 @@ static int\n handle_work(void *arg)\n {\n \tstruct rte_distributor *d = arg;\n-\tunsigned int count = 0;\n \tunsigned int num = 0;\n \tint i;\n \tunsigned int id = __atomic_fetch_add(&worker_idx, 1, __ATOMIC_RELAXED);\n@@ -120,11 +119,9 @@ handle_work(void *arg)\n \tnum = rte_distributor_get_pkt(d, id, buf, buf, num);\n \twhile (!quit) {\n \t\tworker_stats[id].handled_packets += num;\n-\t\tcount += num;\n \t\tnum = rte_distributor_get_pkt(d, id, buf, buf, num);\n \t}\n \tworker_stats[id].handled_packets += num;\n-\tcount += num;\n \trte_distributor_return_pkt(d, id, buf, num);\n \treturn 0;\n }\ndiff --git a/app/test/test_thash_perf.c b/app/test/test_thash_perf.c\nindex 7aa9360120..c95785d8bb 100644\n--- a/app/test/test_thash_perf.c\n+++ b/app/test/test_thash_perf.c\n@@ -61,6 +61,8 @@ run_rss_calc(uint32_t *tuples[BATCH_SZ], enum test_rss_type type, int len,\n \t}\n \tend_tsc = rte_rdtsc_precise();\n \n+\tRTE_SET_USED(hash);\n+\n \treturn end_tsc - start_tsc;\n }\n \n", "prefixes": [ "1/7" ] }