Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104223/?format=api
{ "id": 104223, "url": "https://patches.dpdk.org/api/patches/104223/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211112031635.11400-1-rohit.raj@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211112031635.11400-1-rohit.raj@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211112031635.11400-1-rohit.raj@nxp.com", "date": "2021-11-12T03:16:35", "name": "[v2] examples/l3fwd: fix jumbo packet drop issue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9b1ebcfc8ab43b4c63621b17b14733d2d7bcde3e", "submitter": { "id": 1845, "url": "https://patches.dpdk.org/api/people/1845/?format=api", "name": "Rohit Raj", "email": "rohit.raj@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211112031635.11400-1-rohit.raj@nxp.com/mbox/", "series": [ { "id": 20507, "url": "https://patches.dpdk.org/api/series/20507/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20507", "date": "2021-11-12T03:16:35", "name": "[v2] examples/l3fwd: fix jumbo packet drop issue", "version": 2, "mbox": "https://patches.dpdk.org/series/20507/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/104223/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/104223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A60BBA0548;\n\tFri, 12 Nov 2021 04:16:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DAB440692;\n\tFri, 12 Nov 2021 04:16:39 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by mails.dpdk.org (Postfix) with ESMTP id E308F40687\n for <dev@dpdk.org>; Fri, 12 Nov 2021 04:16:37 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id B119C1A1D45;\n Fri, 12 Nov 2021 04:16:37 +0100 (CET)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 7ACD41A1D3D;\n Fri, 12 Nov 2021 04:16:37 +0100 (CET)", "from lsv03196.swis.in-blr01.nxp.com (lsv03196.swis.in-blr01.nxp.com\n [92.120.146.192])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 878D3183ACDD;\n Fri, 12 Nov 2021 11:16:36 +0800 (+08)" ], "From": "rohit.raj@nxp.com", "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com", "Cc": "nipun.gupta@nxp.com, Rohit Raj <rohit.raj@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Vanshika Shukla <vanshika.shukla@nxp.com>", "Subject": "[PATCH v2] examples/l3fwd: fix jumbo packet drop issue", "Date": "Fri, 12 Nov 2021 08:46:35 +0530", "Message-Id": "<20211112031635.11400-1-rohit.raj@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210727092523.22718-1-rohit.raj@nxp.com>", "References": "<20210727092523.22718-1-rohit.raj@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rohit Raj <rohit.raj@nxp.com>\n\nl3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is\nnot able to store packets with size greater than 2KB, hence these\npackets are dropped.\n\nThis patch fixes this issue by enabling scatter for jumbo packet, if\nit is supported by NIC.\n\nIf scatter is not supported by NIC and max packet length is greater\nthan default mbuf data size, then application exits with proper error\nmessage.\n\nFixes: f68aad7904f (\"examples/l3fwd: update\")\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\nSigned-off-by: Sachin Saxena <sachin.saxena@nxp.com>\nSigned-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>\n---\n\nv2:\n* Improved the check to not enable Rx scatter when packets fits into\n buffer.\n* Check if jumbo packet is enabled using max_rx_pktlen instead of\n jumbo packet flag.\n\n examples/l3fwd/main.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex d69373f881..61448c759c 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -1109,6 +1109,19 @@ l3fwd_poll_resource_setup(void)\n \t\t\t\t\"Invalid max packet length: %u (port %u)\\n\",\n \t\t\t\tmax_pkt_len, portid);\n \n+\t\t/* Enable Receive side SCATTER, if supported by NIC,\n+\t\t * when jumbo packet is enabled.\n+\t\t */\n+\t\tif (dev_info.max_rx_pktlen > RTE_MBUF_DEFAULT_DATAROOM) {\n+\t\t\tif (dev_info.rx_offload_capa &\n+\t\t\t RTE_ETH_RX_OFFLOAD_SCATTER)\n+\t\t\t\tlocal_port_conf.rxmode.offloads |=\n+\t\t\t\t\t\tRTE_ETH_RX_OFFLOAD_SCATTER;\n+\t\t\telse\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t \"Max packet length greater than default MBUF size\\n\");\n+\t\t}\n+\n \t\tif (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)\n \t\t\tlocal_port_conf.txmode.offloads |=\n \t\t\t\tRTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;\n", "prefixes": [ "v2" ] }