Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103761/?format=api
{ "id": 103761, "url": "https://patches.dpdk.org/api/patches/103761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211104123320.1638915-15-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211104123320.1638915-15-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211104123320.1638915-15-xuemingl@nvidia.com", "date": "2021-11-04T12:33:20", "name": "[v4,14/14] net/mlx5: add shared Rx queue port datapath support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bb729055812722f84b34f4b641c6cad46f359d17", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211104123320.1638915-15-xuemingl@nvidia.com/mbox/", "series": [ { "id": 20310, "url": "https://patches.dpdk.org/api/series/20310/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20310", "date": "2021-11-04T12:33:06", "name": "net/mlx5: support shared Rx queue", "version": 4, "mbox": "https://patches.dpdk.org/series/20310/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103761/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/103761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1A7B3A0C41;\n\tThu, 4 Nov 2021 13:36:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F17974272B;\n\tThu, 4 Nov 2021 13:35:28 +0100 (CET)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam07on2088.outbound.protection.outlook.com [40.107.212.88])\n by mails.dpdk.org (Postfix) with ESMTP id D936E42742\n for <dev@dpdk.org>; Thu, 4 Nov 2021 13:35:26 +0100 (CET)", "from DM6PR06CA0101.namprd06.prod.outlook.com (2603:10b6:5:336::34)\n by DM6PR12MB3545.namprd12.prod.outlook.com (2603:10b6:5:18b::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 4 Nov\n 2021 12:35:25 +0000", "from DM6NAM11FT029.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:336:cafe::ee) by DM6PR06CA0101.outlook.office365.com\n (2603:10b6:5:336::34) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend\n Transport; Thu, 4 Nov 2021 12:35:25 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT029.mail.protection.outlook.com (10.13.173.23) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 12:35:24 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 4 Nov\n 2021 12:35:03 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MYqy82wUXzvL6ZvapTQis7jFNxQY4NyGpwG5jJ1dp9q1CI0RMUJ3iYFxzoBWwLGCyVylXKfOtKMFK3P/EESB9uwC0j3YFOGIZD36AkfGc9bxU1GjzrpQUTzKE0su6uwuZR58HZGVCTPzkE7hD/gGw5ycXWxl0jhCY2Au79YxAf/UYJkcxZH8a+2jzlLeqhiewEHoTUX7IzWf9meibGAMambBIRCh3j6jWzHCljk51Jn5JvAx8ulHSNU686840/CpjcnS78oKFSNV7DYZIvllS0woz0sfvJdTErXTt3LFpQsB4E5+ND8JXfUFCVbR4M1ecWrKohXb8QdLDqWRMaGK7A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OBLqD2QAXhn42wICgxJ/LOrXW3QBMnG+PsAy+pKInSs=;\n b=Q9y6uRVVnIkZbzwNBqBOMtxW+x8rtpzPH1/mx8oC/OJXd9YKx3f57UF9JQJwZTIj/fgqs8iCbZzNyaBidJMcWrdyGx6Mx7pKecq7Ct0GsotbdLMpWVQiSwWY+R7dS+R1QgDH1DOjSHQKi/VojlZ+4/baZI+AaQRzIiMBpwzCFiPD6egzeGugy7qX/3eMALUKw6HWsNAFMnMcM9hDrKCA0/Tt5TcCe8+DesM6ptgMGxd3Tk+NZxf2b87Mhe8sfJOHXrnT3M7xXU1VJim9MunT1UPRfKO8nD/t8K0FIqbiupc0TlkVaonL/ETZS+kp8DcViqdQ7HALl/SQQ1fjiCbbcg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OBLqD2QAXhn42wICgxJ/LOrXW3QBMnG+PsAy+pKInSs=;\n b=DFSSmv76liyyinJB7PyZ5tjqb/77Iat+G1O/vGxt3WHCX+/YJm84kj/UgzJELCad39Um/jwcF0oLhPo3+vmYbLu8NxHbgoK2srBJNMjr1ph9sNEq5a4ld7A+DMz9uVkS747rETFrB56Jla7R+UWv3HoQc2xIsP5UHQk/LGjMjFJkmxZm5fE1EzcmhzvvFd9C5Emw5KQ6jGcBXzyfhVf6PPOXLgJhLIC4ugIMRY2fdF0Z4p5/mweb0ZjUg8twjEM9RUiZHC50C/h6BzbgAtFDW9XvACF+oPPM1J+q03jQN1pDx9OhqO4W6wkBDd6+akdmBUlmq+X117Q12rXYGCVkZA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xueming Li <xuemingl@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <xuemingl@nvidia.com>,\n \"Lior Margalit\" <lmargalit@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n \"David Christensen\" <drc@linux.vnet.ibm.com>, Ruifeng Wang\n <ruifeng.wang@arm.com>, Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Thu, 4 Nov 2021 20:33:20 +0800", "Message-ID": "<20211104123320.1638915-15-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211104123320.1638915-1-xuemingl@nvidia.com>", "References": "<20210727034204.20649-1-xuemingl@nvidia.com>\n <20211104123320.1638915-1-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "1928e47d-8db3-4d6b-80da-08d99f8f9329", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3545:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB3545E009650FB6E521BC5DBAA18D9@DM6PR12MB3545.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:312;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n h6Nuh0rjQIj1dxbiGAPu3js4XaaT8A+fbhuZth6sTmqQq/i4Q3+3d6+Ns5vE0BSTphfW7SX3xSYfAkyWU4s/jfSZtMGk9if3x3jie5S5eUbRFvNWRSG+fiy9RC8/+5AB33wAUK7pikBZPXXruTXW84phetgSKDa9T4nIU9bvyWmjEcOoZW8bpKep5VtYDRRQGLjeI63nbtio38pzbpY0pjpBaQtYTV4fb/Ci0ToUwkTBfuX2xK5qKHcMqokVDQ42pYNg5/V8zU8LFw1how8WvRDOq2W9gehgtRuv4Ii5o5Ps+tl6HVaO98S9tGQMU8TubKDR8IaX61DZCyvH0r0uSPkZlH+WVlr9rWuv3+L7tvKhCtgIBCBkN//1PLMxxup9uKZFXTSyvnOz3BZJqvl6Mib7fcfEyU6T8GuFE/Qg8+heyHTrMmZ7R+Mb4EhEQJCViP4J1sItLznnE6WUcjcTYKSwQ1Wzcyu0dgofqLgrIq3k+KE6MD0nhpanU9kpxMsd10WS6C+0ingG/rtPfTkqW5uM869AEsty1/BBzM/QfMUF8ItKAh+QyesOCJX13dDAwrr3zs1CbLoXcsp2GlkODu1+xJw+9jcJ/pKyyCODAaLc07top/z0odzQiFxQtzMPLYLaAJbgAkoNVzj2HJ2Z/YxQlZpr7pYGn0aTuHs7q3IBbbL9h/WesuvMcVlG2uN7CMzI2bAHyaaKtfYpUskuXw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(336012)(4326008)(2906002)(36860700001)(86362001)(8936002)(8676002)(5660300002)(83380400001)(186003)(16526019)(426003)(82310400003)(2616005)(508600001)(36756003)(54906003)(47076005)(316002)(70586007)(1076003)(70206006)(7696005)(6286002)(6916009)(55016002)(26005)(7636003)(356005)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Nov 2021 12:35:24.6187 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1928e47d-8db3-4d6b-80da-08d99f8f9329", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT029.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3545", "Subject": "[dpdk-dev] [PATCH v4 14/14] net/mlx5: add shared Rx queue port\n datapath support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n\nWhen receive packet, mlx5 PMD saves mbuf port number from\nRxQ data.\n\nTo support shared RxQ, save port number into RQ context as user index.\nReceived packet resolve port number from CQE user index which derived\nfrom RQ context.\n\nLegacy Verbs API doesn't support RQ user index setting, still read from\nRxQ port number.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\nAcked-by: Slava Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_devx.c | 1 +\n drivers/net/mlx5/mlx5_rx.c | 1 +\n drivers/net/mlx5/mlx5_rxq.c | 3 ++-\n drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 6 ++++++\n drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 +++++++++++-\n drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 8 +++++++-\n 6 files changed, 28 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c\nindex d3d189ab7f2..a9f9f4af700 100644\n--- a/drivers/net/mlx5/mlx5_devx.c\n+++ b/drivers/net/mlx5/mlx5_devx.c\n@@ -277,6 +277,7 @@ mlx5_rxq_create_devx_rq_resources(struct mlx5_rxq_priv *rxq)\n \t\t\t\t\t\tMLX5_WQ_END_PAD_MODE_NONE;\n \trq_attr.wq_attr.pd = cdev->pdn;\n \trq_attr.counter_set_id = priv->counter_set_id;\n+\trq_attr.user_index = rte_cpu_to_be_16(priv->dev_data->port_id);\n \tif (rxq_data->shared) /* Create RMP based RQ. */\n \t\trxq->devx_rq.rmp = &rxq_ctrl->obj->devx_rmp;\n \t/* Create RQ using DevX API. */\ndiff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c\nindex 1ffa1b95b88..4d85f64accd 100644\n--- a/drivers/net/mlx5/mlx5_rx.c\n+++ b/drivers/net/mlx5/mlx5_rx.c\n@@ -709,6 +709,7 @@ rxq_cq_to_mbuf(struct mlx5_rxq_data *rxq, struct rte_mbuf *pkt,\n {\n \t/* Update packet information. */\n \tpkt->packet_type = rxq_cq_to_pkt_type(rxq, cqe, mcqe);\n+\tpkt->port = unlikely(rxq->shared) ? cqe->user_index_low : rxq->port_id;\n \n \tif (rxq->rss_hash) {\n \t\tuint32_t rss_hash_res = 0;\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 8feb3e2c0fb..4515d531835 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -186,7 +186,8 @@ rxq_alloc_elts_sprq(struct mlx5_rxq_ctrl *rxq_ctrl)\n \t\tmbuf_init->data_off = RTE_PKTMBUF_HEADROOM;\n \t\trte_mbuf_refcnt_set(mbuf_init, 1);\n \t\tmbuf_init->nb_segs = 1;\n-\t\tmbuf_init->port = rxq->port_id;\n+\t\t/* For shared queues port is provided in CQE */\n+\t\tmbuf_init->port = rxq->shared ? 0 : rxq->port_id;\n \t\tif (priv->flags & RTE_PKTMBUF_POOL_F_PINNED_EXT_BUF)\n \t\t\tmbuf_init->ol_flags = RTE_MBUF_F_EXTERNAL;\n \t\t/*\ndiff --git a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h\nindex 1d00c1c43d1..423e229508c 100644\n--- a/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h\n+++ b/drivers/net/mlx5/mlx5_rxtx_vec_altivec.h\n@@ -1189,6 +1189,12 @@ rxq_cq_process_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,\n \n \t\t/* D.5 fill in mbuf - rearm_data and packet_type. */\n \t\trxq_cq_to_ptype_oflags_v(rxq, cqes, opcode, &pkts[pos]);\n+\t\tif (unlikely(rxq->shared)) {\n+\t\t\tpkts[pos]->port = cq[pos].user_index_low;\n+\t\t\tpkts[pos + p1]->port = cq[pos + p1].user_index_low;\n+\t\t\tpkts[pos + p2]->port = cq[pos + p2].user_index_low;\n+\t\t\tpkts[pos + p3]->port = cq[pos + p3].user_index_low;\n+\t\t}\n \t\tif (rxq->hw_timestamp) {\n \t\t\tint offset = rxq->timestamp_offset;\n \t\t\tif (rxq->rt_timestamp) {\ndiff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\nindex aa36df29a09..b1d16baa619 100644\n--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n@@ -787,7 +787,17 @@ rxq_cq_process_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,\n \t\t/* C.4 fill in mbuf - rearm_data and packet_type. */\n \t\trxq_cq_to_ptype_oflags_v(rxq, ptype_info, flow_tag,\n \t\t\t\t\t opcode, &elts[pos]);\n-\t\tif (rxq->hw_timestamp) {\n+\t\tif (unlikely(rxq->shared)) {\n+\t\t\telts[pos]->port = container_of(p0, struct mlx5_cqe,\n+\t\t\t\t\t pkt_info)->user_index_low;\n+\t\t\telts[pos + 1]->port = container_of(p1, struct mlx5_cqe,\n+\t\t\t\t\t pkt_info)->user_index_low;\n+\t\t\telts[pos + 2]->port = container_of(p2, struct mlx5_cqe,\n+\t\t\t\t\t pkt_info)->user_index_low;\n+\t\t\telts[pos + 3]->port = container_of(p3, struct mlx5_cqe,\n+\t\t\t\t\t pkt_info)->user_index_low;\n+\t\t}\n+\t\tif (unlikely(rxq->hw_timestamp)) {\n \t\t\tint offset = rxq->timestamp_offset;\n \t\t\tif (rxq->rt_timestamp) {\n \t\t\t\tstruct mlx5_dev_ctx_shared *sh = rxq->sh;\ndiff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h b/drivers/net/mlx5/mlx5_rxtx_vec_sse.h\nindex b0fc29d7b9e..f3d838389e2 100644\n--- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h\n+++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.h\n@@ -736,7 +736,13 @@ rxq_cq_process_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,\n \t\t*err |= _mm_cvtsi128_si64(opcode);\n \t\t/* D.5 fill in mbuf - rearm_data and packet_type. */\n \t\trxq_cq_to_ptype_oflags_v(rxq, cqes, opcode, &pkts[pos]);\n-\t\tif (rxq->hw_timestamp) {\n+\t\tif (unlikely(rxq->shared)) {\n+\t\t\tpkts[pos]->port = cq[pos].user_index_low;\n+\t\t\tpkts[pos + p1]->port = cq[pos + p1].user_index_low;\n+\t\t\tpkts[pos + p2]->port = cq[pos + p2].user_index_low;\n+\t\t\tpkts[pos + p3]->port = cq[pos + p3].user_index_low;\n+\t\t}\n+\t\tif (unlikely(rxq->hw_timestamp)) {\n \t\t\tint offset = rxq->timestamp_offset;\n \t\t\tif (rxq->rt_timestamp) {\n \t\t\t\tstruct mlx5_dev_ctx_shared *sh = rxq->sh;\n", "prefixes": [ "v4", "14/14" ] }