Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103522/?format=api
{ "id": 103522, "url": "https://patches.dpdk.org/api/patches/103522/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211102170135.959380-3-dkozlyuk@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211102170135.959380-3-dkozlyuk@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211102170135.959380-3-dkozlyuk@nvidia.com", "date": "2021-11-02T17:01:31", "name": "[v6,2/6] ethdev: add capability to keep shared objects on restart", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aae0ed64da984b9dc29f26d6def0a98e9326efb6", "submitter": { "id": 2367, "url": "https://patches.dpdk.org/api/people/2367/?format=api", "name": "Dmitry Kozlyuk", "email": "dkozlyuk@oss.nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211102170135.959380-3-dkozlyuk@nvidia.com/mbox/", "series": [ { "id": 20232, "url": "https://patches.dpdk.org/api/series/20232/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20232", "date": "2021-11-02T17:01:29", "name": "Flow entites behavior on port restart", "version": 6, "mbox": "https://patches.dpdk.org/series/20232/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103522/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/103522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7BFBA0C4E;\n\tTue, 2 Nov 2021 18:02:10 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 267E241104;\n\tTue, 2 Nov 2021 18:02:03 +0100 (CET)", "from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com\n [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id 1DA2841103\n for <dev@dpdk.org>; Tue, 2 Nov 2021 18:02:01 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108)\n by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.858.15; Tue, 2 Nov 2021 10:02:00 -0700", "from BN9PR03CA0971.namprd03.prod.outlook.com (2603:10b6:408:109::16)\n by DM4PR12MB5374.namprd12.prod.outlook.com (2603:10b6:5:39a::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov\n 2021 17:01:58 +0000", "from BN8NAM11FT007.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:109:cafe::bf) by BN9PR03CA0971.outlook.office365.com\n (2603:10b6:408:109::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend\n Transport; Tue, 2 Nov 2021 17:01:58 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT007.mail.protection.outlook.com (10.13.177.109) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4649.14 via Frontend Transport; Tue, 2 Nov 2021 17:01:54 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 2 Nov\n 2021 17:01:52 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FvHK4naJEmrNO0IKkKin50ArPopWExRXxmpLFcDj697YDY6fRbsLJRBh6wSspPRbf0ojKd246NzvFf0Wze1oCz6fsMT4SsCgjb3EvzTYGSEH3nVBZlITLxjSLCAh3+q5BKMesM/cnuGbFrOwRTCj7zQ7ts2S6a1CyU4FtUA+cvJBzBcqT9bV+7Ena/fiaaHeNghctCLU56X3m1/BvSFuaNAQjUoeujCnvw7AbZSxMamhnWQMEc5vYNnf5ntzQm7+UPegIq69bIqEkJ/XgFdZTvxXuFS0Cy9a2JNundTpAlDvl8wfyOefloEkKvlMIZDLHbcnLMAoMP5i36eLAJby8g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RC0ZdV58kGomw7BbLQTMyGI39SX8nUj7DGunP+cx6fw=;\n b=KW2qm6EPHpMx1zmagPnfeLFf7Eh3xEXRPYPcHSPZJpf/wMbmoYdAIJI3av5QM0QmUAApvtAZGw2dbtWPc9NdM4lb05OM9FWWzxRjDTHWikbLTNVnIFf0Pyba6cdo83jpKsujOtAZ5YADAabDKGIVOu3pTSOu58QkiGCr1h3cac8SANKyqnoTmBqSKNGNc43KukEHyQfyifm7Aq8Rby7Z+rmsdHOJU1+iHn/QanXcdLblLXZN+7buU6Y8GyV9J4/H+kMk0giGxdJOE8RwKmuNlX2SgAr7UuHNWQ76VLxUk5IO1jAxmlCsaALfnjqxXvrnDCPt5naqoiIqglWOYHj5KQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RC0ZdV58kGomw7BbLQTMyGI39SX8nUj7DGunP+cx6fw=;\n b=SZRJ0p4nCqjAJc7b4f02PKkndF15l0BIVZ+CLjzOZPbs4ptbjGI6qOhYNVbwG/qQj06peYDWbTQMnig3Yshiau0Go4FDIXb0rTg6GIibSWn4D9HR2JG6+1BPvvUyOjf35++WOlRZ9n8jWO41DOnjdIzA9iGLq9W4N07sz2E0nqeZj/Cqa0oiYjWn7wrZuh7n1OzBN+yx9n+pklNjqx9Mi5ssUOK9RKuRcUqvC+pz1tuaCebESl/cIuGIE9+LdZs9DApl2Dla0/pS7oLx2cQBIlFDiH/Dh/1fkKuthYp0ocL6hedNX1C0SbGrqduSm5JbhjlcJEpv2yfnjRuZOXBIng==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Ori Kam <orika@oss.nvidia.com>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 2 Nov 2021 19:01:31 +0200", "Message-ID": "<20211102170135.959380-3-dkozlyuk@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211102170135.959380-1-dkozlyuk@nvidia.com>", "References": "<20211102135415.944050-1-dkozlyuk@nvidia.com>\n <20211102170135.959380-1-dkozlyuk@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "34d8b294-deba-4a44-9b02-08d99e2278f3", "X-MS-TrafficTypeDiagnostic": "DM4PR12MB5374:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <DM4PR12MB537418D0CFE962F6A45071E5B98B9@DM4PR12MB5374.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7691;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n iHzOw+4DBf4t3bkJ48TZ83kVrK7Lst/Jo5/mSvDYWxOiCjI95ErJ2v0b4NfpkENwuxzJvR02nCSgHyAUFe4vClrpuaGDDHY5uHjpq3M7ODueOojJvTMEVH29XgXnDjgT4K0QbLAAQH4nJXkjeZPGzAMNbZ0uNGoYnMnRM9N51aizdEWw8WNjZDeL6jxglC8CJziYV1vGE+2MzaOXWqUhjgd9BT7/p7Dl/GopZLfJQOLR9itjhw4NPrj/9a+PAx0XNj/qzpxozzpCpFiqCBXo1vhKZbdTxu3lmZyA61Vhjtr5FnU8VscPul0KpugfwR7opl+GIgQb7hac8k/rhwlM6Y56gMbjYbSnvcKM0Iu2TwfAy0fzXXrVC1Qrcs8awpsd0pKzw+5juvRFeI9wXsXWLjTSfzP689ijojayxlCKelx/eha0SjwziMC71GGJix7KZR1uwayggOU57lNstlb94CDk//m0vcq2G7HSXx0szsXMADKzke4rH+1TDWxDGVz9CPu/L549BIX24uDfuwGFJN4z+0iesqHGjJWWvg2204bGMA1pQWkGXKvRIu91VvHf0AMXhWCCwaxrJjIkVKtQNbXi4vqTW6g8CYGsQcZlfBVLecvZUOKm5Lz2rmqXlSSS0M/F7SW9PB9l3EV4pE5Ii7zLMyAgon0kGCe0rCZYYjtFTWFmerkmZBTkzlAHpIN1iWKPQGbbwpQCzx5e2pOv+w==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(4326008)(47076005)(5660300002)(8936002)(2616005)(336012)(55016002)(508600001)(70206006)(6286002)(70586007)(1076003)(86362001)(426003)(54906003)(82310400003)(8676002)(2906002)(6916009)(83380400001)(7636003)(36756003)(107886003)(7696005)(26005)(356005)(36860700001)(6666004)(16526019)(316002)(186003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Nov 2021 17:01:54.2394 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 34d8b294-deba-4a44-9b02-08d99e2278f3", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT007.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB5374", "Subject": "[dpdk-dev] [PATCH v6 2/6] ethdev: add capability to keep shared\n objects on restart", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_flow_action_handle_create() did not mention what happens\nwith an indirect action when a device is stopped and started again.\nIt is natural for some indirect actions, like counter, to be persistent.\nKeeping others at least saves application time and complexity.\nHowever, not all PMDs can support it, or the support may be limited\nby particular action kinds, that is, combinations of action type\nand the value of the transfer bit in its configuration.\n\nAdd a device capability to indicate if at least some indirect actions\nare kept across the above sequence. Without this capability the behavior\nis still unspecified, and application is required to destroy\nthe indirect actions before stopping the device.\nIn the future, indirect actions may not be the only type of objects\nshared between flow rules. The capability bit intends to cover all\npossible types of such objects, hence its name.\n\nDeclare that the application can test for the persistence\nof a particular indirect action kind by attempting to create\nan indirect action of that kind when the device is stopped\nand checking for the specific error type.\nThis is logical because if the PMD can to create an indirect action\nwhen the device is not started and use it after the start happens,\nit is natural that it can move its internal flow shared object\nto the same state when the device is stopped and restore the state\nwhen the device is started.\n\nIndirect action persistence across a reconfigurations is not required.\nIn case a PMD cannot keep the indirect actions across reconfiguration,\nit is allowed just to report an error.\nApplication must then flush the indirect actions before attempting it.\n\nSigned-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\nAcked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n doc/guides/prog_guide/rte_flow.rst | 31 ++++++++++++++++++++++++++++++\n lib/ethdev/rte_ethdev.h | 3 +++\n 2 files changed, 34 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex e01a079230..77de8da973 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -2995,6 +2995,37 @@ updated depend on the type of the ``action`` and different for every type.\n The indirect action specified data (e.g. counter) can be queried by\n ``rte_flow_action_handle_query()``.\n \n+.. warning::\n+\n+ The following description of indirect action persistence\n+ is an experimental behavior that may change without a prior notice.\n+\n+If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised,\n+indirect actions cannot be created until the device is started for the first time\n+and cannot be kept when the device is stopped.\n+However, PMD also does not flush them automatically on stop,\n+so the application must call ``rte_flow_action_handle_destroy()``\n+before stopping the device to ensure no indirect actions remain.\n+\n+If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is advertised,\n+this means that the PMD can keep at least some indirect actions\n+across device stop and start.\n+However, ``rte_eth_dev_configure()`` may fail if any indirect actions remain,\n+so the application must destroy them before attempting a reconfiguration.\n+Keeping may be only supported for certain kinds of indirect actions.\n+A kind is a combination of an action type and a value of its transfer bit.\n+For example: an indirect counter with the transfer bit reset.\n+To test if a particular kind of indirect actions is kept,\n+the application must try to create a valid indirect action of that kind\n+when the device is not started (either before the first start of after a stop).\n+If it fails with an error of type ``RTE_FLOW_ERROR_TYPE_STATE``,\n+application must destroy all indirect actions of this kind\n+before stopping the device.\n+If it succeeds, all indirect actions of the same kind are kept\n+when the device is stopped.\n+Indirect actions of a kept kind that are created when the device is stopped,\n+including the ones created for the test, will be kept after the device start.\n+\n .. _table_rte_flow_action_handle:\n \n .. table:: INDIRECT\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex a18e6ab887..5f803ad1e6 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -94,6 +94,7 @@\n * depending on the device capabilities:\n *\n * - flow rules\n+ * - flow-related shared objects, e.g. indirect actions\n *\n * Any other configuration will not be stored and will need to be re-entered\n * before a call to rte_eth_dev_start().\n@@ -1698,6 +1699,8 @@ struct rte_eth_conf {\n #define RTE_ETH_DEV_CAPA_RXQ_SHARE RTE_BIT64(2)\n /** Device supports keeping flow rules across restart. */\n #define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP RTE_BIT64(3)\n+/** Device supports keeping shared flow objects across restart. */\n+#define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4)\n /**@}*/\n \n /*\n", "prefixes": [ "v6", "2/6" ] }