Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103409/?format=api
{ "id": 103409, "url": "https://patches.dpdk.org/api/patches/103409/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211102040556.7840-11-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211102040556.7840-11-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211102040556.7840-11-venkatkumar.duvvuru@broadcom.com", "date": "2021-11-02T04:05:46", "name": "[v3,10/20] net/bnxt: remove accumulation of stats devargs argument", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "19149da62415d589757e69286ea23dc5a61b2fe5", "submitter": { "id": 1635, "url": "https://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211102040556.7840-11-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 20191, "url": "https://patches.dpdk.org/api/series/20191/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20191", "date": "2021-11-02T04:05:36", "name": "fixes and enhancements to Truflow", "version": 3, "mbox": "https://patches.dpdk.org/series/20191/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103409/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/103409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D56AA0C4D;\n\tTue, 2 Nov 2021 05:07:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C70B24115E;\n\tTue, 2 Nov 2021 05:06:23 +0100 (CET)", "from relay.smtp-ext.broadcom.com (lpdvacalvio01.broadcom.com\n [192.19.166.228])\n by mails.dpdk.org (Postfix) with ESMTP id AAA794115C\n for <dev@dpdk.org>; Tue, 2 Nov 2021 05:06:21 +0100 (CET)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id EEC907A21;\n Mon, 1 Nov 2021 21:06:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com EEC907A21", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1635825981;\n bh=pe2rCkzJEYbRxPlty9xcWi6S7wYfpQ6iuKiHiSgXfAY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gyfl9vhNrFwPuHIE6c39m+4U7G9joVN5RdIw9yGcmD1AoMoXLAbQRNb5TetYYy/ns\n jchQJ9Fsjg4TZmMSmCkcEVyMWq5nFP4pc8I3LQ+lGN3uXvHAKKcwRKl97SM8QqLCNl\n nwh+jsOd3y8eEMi40CHHI6KX5b1Okkk4iMZNJAVY=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Tue, 2 Nov 2021 09:35:46 +0530", "Message-Id": "<20211102040556.7840-11-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211102040556.7840-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20211001055909.27276-1-venkatkumar.duvvuru@broadcom.com>\n <20211102040556.7840-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v3 10/20] net/bnxt: remove accumulation of stats\n devargs argument", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nThe accumulation of flow counters is not determined by the\napplication device arguments instead it is dictated by the platform\ncapabilities whether to do software based accumulation or not.\n\nChange-Id: I7275a0ed6ab089358e0a95f43d6291ec65ebe030\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 3 --\n drivers/net/bnxt/bnxt_ethdev.c | 53 ----------------------------\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 8 -----\n drivers/net/bnxt/tf_ulp/bnxt_ulp.h | 1 -\n drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 12 +++----\n 5 files changed, 4 insertions(+), 73 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 5c064fd119..5cc4a5afae 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -718,11 +718,8 @@ struct bnxt {\n \tuint32_t\t\t\tflags2;\n #define BNXT_FLAGS2_PTP_TIMESYNC_ENABLED\tBIT(0)\n #define BNXT_FLAGS2_PTP_ALARM_SCHEDULED\t\tBIT(1)\n-#define\tBNXT_FLAGS2_ACCUM_STATS_EN\t\tBIT(2)\n #define BNXT_P5_PTP_TIMESYNC_ENABLED(bp)\t\\\n \t((bp)->flags2 & BNXT_FLAGS2_PTP_TIMESYNC_ENABLED)\n-#define\tBNXT_ACCUM_STATS_EN(bp)\t\t\t\\\n-\t((bp)->flags2 & BNXT_FLAGS2_ACCUM_STATS_EN)\n \n \tuint16_t\t\tchip_num;\n #define CHIP_NUM_58818\t\t0xd818\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 8c72ab8fd1..070f69d8e9 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -87,7 +87,6 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n \t{ .vendor_id = 0, /* sentinel */ },\n };\n \n-#define\tBNXT_DEVARG_ACCUM_STATS\t\"accum-stats\"\n #define BNXT_DEVARG_FLOW_XSTAT\t\"flow-xstat\"\n #define BNXT_DEVARG_MAX_NUM_KFLOWS \"max-num-kflows\"\n #define BNXT_DEVARG_REPRESENTOR\t\"representor\"\n@@ -101,7 +100,6 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n \n static const char *const bnxt_dev_args[] = {\n \tBNXT_DEVARG_REPRESENTOR,\n-\tBNXT_DEVARG_ACCUM_STATS,\n \tBNXT_DEVARG_FLOW_XSTAT,\n \tBNXT_DEVARG_MAX_NUM_KFLOWS,\n \tBNXT_DEVARG_REP_BASED_PF,\n@@ -114,12 +112,6 @@ static const char *const bnxt_dev_args[] = {\n \tNULL\n };\n \n-/*\n- * accum-stats == false to disable flow counter accumulation\n- * accum-stats == true to enable flow counter accumulation\n- */\n-#define\tBNXT_DEVARG_ACCUM_STATS_INVALID(accum_stats)\t((accum_stats) > 1)\n-\n /*\n * app-id = an non-negative 8-bit number\n */\n@@ -5299,45 +5291,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)\n \treturn 0;\n }\n \n-static int\n-bnxt_parse_devarg_accum_stats(__rte_unused const char *key,\n-\t\t\t const char *value, void *opaque_arg)\n-{\n-\tstruct bnxt *bp = opaque_arg;\n-\tunsigned long accum_stats;\n-\tchar *end = NULL;\n-\n-\tif (!value || !opaque_arg) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Invalid parameter passed to accum-stats devargs.\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\taccum_stats = strtoul(value, &end, 10);\n-\tif (end == NULL || *end != '\\0' ||\n-\t (accum_stats == ULONG_MAX && errno == ERANGE)) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Invalid parameter passed to accum-stats devargs.\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (BNXT_DEVARG_ACCUM_STATS_INVALID(accum_stats)) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Invalid value passed to accum-stats devargs.\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (accum_stats) {\n-\t\tbp->flags2 |= BNXT_FLAGS2_ACCUM_STATS_EN;\n-\t\tPMD_DRV_LOG(INFO, \"Host-based accum-stats feature enabled.\\n\");\n-\t} else {\n-\t\tbp->flags2 &= ~BNXT_FLAGS2_ACCUM_STATS_EN;\n-\t\tPMD_DRV_LOG(INFO, \"Host-based accum-stats feature disabled.\\n\");\n-\t}\n-\n-\treturn 0;\n-}\n-\n static int\n bnxt_parse_devarg_flow_xstat(__rte_unused const char *key,\n \t\t\t const char *value, void *opaque_arg)\n@@ -5690,12 +5643,6 @@ bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)\n \tif (ret)\n \t\tgoto err;\n \n-\t/*\n-\t * Handler for \"accum-stats\" devarg.\n-\t * Invoked as for ex: \"-a 0000:00:0d.0,accum-stats=1\"\n-\t */\n-\trte_kvargs_process(kvlist, BNXT_DEVARG_ACCUM_STATS,\n-\t\t\t bnxt_parse_devarg_accum_stats, bp);\n \t/*\n \t * Handler for \"max_num_kflows\" devarg.\n \t * Invoked as for ex: \"-a 000:00:0d.0,max_num_kflows=32\"\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 2ac1a8625f..7deacd1f3e 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -1490,14 +1490,6 @@ bnxt_ulp_port_init(struct bnxt *bp)\n \t\tgoto jump_to_error;\n \t}\n \n-\t/* set the accumulation of the stats */\n-\tif (BNXT_ACCUM_STATS_EN(bp))\n-\t\tbp->ulp_ctx->cfg_data->accum_stats = true;\n-\n-\tBNXT_TF_DBG(DEBUG, \"BNXT Port:%d ULP port init, accum_stats:%d\\n\",\n-\t\t bp->eth_dev->data->port_id,\n-\t\t bp->ulp_ctx->cfg_data->accum_stats);\n-\n \t/* set the unicast mode */\n \tif (bnxt_ulp_cntxt_ptr2_ulp_flags_get(bp->ulp_ctx, &ulp_flags)) {\n \t\tBNXT_TF_DBG(ERR, \"Error in getting ULP context flags\\n\");\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.h b/drivers/net/bnxt/tf_ulp/bnxt_ulp.h\nindex 960a5a0c93..17c6898196 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.h\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.h\n@@ -92,7 +92,6 @@ struct bnxt_ulp_data {\n #define\tBNXT_ULP_TUN_ENTRY_INVALID\t-1\n #define\tBNXT_ULP_MAX_TUN_CACHE_ENTRIES\t16\n \tstruct bnxt_tun_cache_entry\ttun_tbl[BNXT_ULP_MAX_TUN_CACHE_ENTRIES];\n-\tbool\t\t\t\taccum_stats;\n \tuint8_t\t\t\t\tapp_id;\n \tuint8_t\t\t\t\tnum_shared_clients;\n \tstruct bnxt_flow_app_tun_ent\tapp_tun[BNXT_ULP_MAX_TUN_CACHE_ENTRIES];\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\nindex d6b4f93d31..92243083b5 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c\n@@ -396,21 +396,17 @@ static int ulp_get_single_flow_stat(struct bnxt_ulp_context *ctxt,\n \t\treturn rc;\n \t}\n \n-\t/* TBD - Get PKT/BYTE COUNT SHIFT/MASK from Template */\n+\t/* PKT/BYTE COUNT SHIFT/MASK are device specific */\n \tsw_cntr_indx = hw_cntr_id - fc_info->shadow_hw_tbl[dir].start_idx;\n \tsw_acc_tbl_entry = &fc_info->sw_acc_tbl[dir][sw_cntr_indx];\n+\n \t/* Some dpdk applications may accumulate the flow counters while some\n \t * may not. In cases where the application is accumulating the counters\n \t * the PMD need not do the accumulation itself and viceversa to report\n \t * the correct flow counters.\n \t */\n-\tif (ctxt->cfg_data->accum_stats) {\n-\t\tsw_acc_tbl_entry->pkt_count += FLOW_CNTR_PKTS(stats, dparms);\n-\t\tsw_acc_tbl_entry->byte_count += FLOW_CNTR_BYTES(stats, dparms);\n-\t} else {\n-\t\tsw_acc_tbl_entry->pkt_count = FLOW_CNTR_PKTS(stats, dparms);\n-\t\tsw_acc_tbl_entry->byte_count = FLOW_CNTR_BYTES(stats, dparms);\n-\t}\n+\tsw_acc_tbl_entry->pkt_count += FLOW_CNTR_PKTS(stats, dparms);\n+\tsw_acc_tbl_entry->byte_count += FLOW_CNTR_BYTES(stats, dparms);\n \n \t/* Update the parent counters if it is child flow */\n \tif (sw_acc_tbl_entry->pc_flow_idx & FLOW_CNTR_PC_FLOW_VALID) {\n", "prefixes": [ "v3", "10/20" ] }