Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103388/?format=api
{ "id": 103388, "url": "https://patches.dpdk.org/api/patches/103388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211102031729.35536-5-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211102031729.35536-5-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211102031729.35536-5-humin29@huawei.com", "date": "2021-11-02T03:17:24", "name": "[4/9] net/hns3: use unsigned integer for bitwise operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "296fa0134bdce64bc77a4d9b0f98bf4cc35a0763", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211102031729.35536-5-humin29@huawei.com/mbox/", "series": [ { "id": 20189, "url": "https://patches.dpdk.org/api/series/20189/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20189", "date": "2021-11-02T03:17:27", "name": "code optimization for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/20189/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103388/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/103388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC6F0A0C4D;\n\tTue, 2 Nov 2021 04:19:52 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D04E4111F;\n\tTue, 2 Nov 2021 04:19:37 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 58F41410FE\n for <dev@dpdk.org>; Tue, 2 Nov 2021 04:19:32 +0100 (CET)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Hjw7S5Pvmz1DHwn;\n Tue, 2 Nov 2021 11:17:24 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.15; Tue, 2 Nov 2021 11:19:27 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Tue, 2 Nov 2021 11:17:24 +0800", "Message-ID": "<20211102031729.35536-5-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211102031729.35536-1-humin29@huawei.com>", "References": "<20211102031729.35536-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 4/9] net/hns3: use unsigned integer for bitwise\n operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nBitwise operations should be used only with unsigned integer. This patch\nmodifies some code that does not meet this rule.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex ccae75baa0..50e73b00b7 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2104,7 +2104,7 @@ hns3_check_mq_mode(struct rte_eth_dev *dev)\n \tint max_tc = 0;\n \tint i;\n \n-\tif ((rx_mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG) ||\n+\tif (((uint32_t)rx_mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG) ||\n \t (tx_mq_mode == RTE_ETH_MQ_TX_VMDQ_DCB ||\n \t tx_mq_mode == RTE_ETH_MQ_TX_VMDQ_ONLY)) {\n \t\thns3_err(hw, \"VMDQ is not supported, rx_mq_mode = %d, tx_mq_mode = %d.\",\n@@ -2114,7 +2114,7 @@ hns3_check_mq_mode(struct rte_eth_dev *dev)\n \n \tdcb_rx_conf = &dev->data->dev_conf.rx_adv_conf.dcb_rx_conf;\n \tdcb_tx_conf = &dev->data->dev_conf.tx_adv_conf.dcb_tx_conf;\n-\tif (rx_mq_mode & RTE_ETH_MQ_RX_DCB_FLAG) {\n+\tif ((uint32_t)rx_mq_mode & RTE_ETH_MQ_RX_DCB_FLAG) {\n \t\tif (dcb_rx_conf->nb_tcs > pf->tc_max) {\n \t\t\thns3_err(hw, \"nb_tcs(%u) > max_tc(%u) driver supported.\",\n \t\t\t\t dcb_rx_conf->nb_tcs, pf->tc_max);\n", "prefixes": [ "4/9" ] }