Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103385/?format=api
{ "id": 103385, "url": "https://patches.dpdk.org/api/patches/103385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211102031729.35536-8-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211102031729.35536-8-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211102031729.35536-8-humin29@huawei.com", "date": "2021-11-02T03:17:27", "name": "[7/9] net/hns3: remove magic numbers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "efae0242a18d1cb722794ccdf6d10c73dba74387", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211102031729.35536-8-humin29@huawei.com/mbox/", "series": [ { "id": 20189, "url": "https://patches.dpdk.org/api/series/20189/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20189", "date": "2021-11-02T03:17:27", "name": "code optimization for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/20189/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103385/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/103385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0D8DFA0C4D;\n\tTue, 2 Nov 2021 04:19:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED2B94069F;\n\tTue, 2 Nov 2021 04:19:33 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 347B44069F\n for <dev@dpdk.org>; Tue, 2 Nov 2021 04:19:32 +0100 (CET)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Hjw4N6yhvzcZxR;\n Tue, 2 Nov 2021 11:14:44 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.15; Tue, 2 Nov 2021 11:19:28 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Tue, 2 Nov 2021 11:17:27 +0800", "Message-ID": "<20211102031729.35536-8-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211102031729.35536-1-humin29@huawei.com>", "References": "<20211102031729.35536-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 7/9] net/hns3: remove magic numbers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nRemoving magic numbers with macros.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_common.c | 4 ++--\n drivers/net/hns3/hns3_common.h | 3 +++\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c\nindex 5fe0ff5ce7..290999f594 100644\n--- a/drivers/net/hns3/hns3_common.c\n+++ b/drivers/net/hns3/hns3_common.c\n@@ -54,7 +54,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args)\n \n \tRTE_SET_USED(key);\n \n-\tval = strtoull(value, NULL, 16);\n+\tval = strtoull(value, NULL, HNS3_CONVERT_TO_HEXADECIMAL);\n \t*(uint64_t *)extra_args = val;\n \n \treturn 0;\n@@ -67,7 +67,7 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args)\n \n \tRTE_SET_USED(key);\n \n-\tval = strtoul(value, NULL, 10);\n+\tval = strtoul(value, NULL, HNS3_CONVERT_TO_DECIMAL);\n \tif (val > HNS3_MBX_DEF_TIME_LIMIT_MS && val <= UINT16_MAX)\n \t\t*(uint16_t *)extra_args = val;\n \ndiff --git a/drivers/net/hns3/hns3_common.h b/drivers/net/hns3/hns3_common.h\nindex 094a0bc5ff..68f9b1b96a 100644\n--- a/drivers/net/hns3/hns3_common.h\n+++ b/drivers/net/hns3/hns3_common.h\n@@ -9,6 +9,9 @@\n \n #include \"hns3_ethdev.h\"\n \n+#define HNS3_CONVERT_TO_DECIMAL 10\n+#define HNS3_CONVERT_TO_HEXADECIMAL 16\n+\n enum {\n \tHNS3_IO_FUNC_HINT_NONE = 0,\n \tHNS3_IO_FUNC_HINT_VEC,\n", "prefixes": [ "7/9" ] }