Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103158/?format=api
{ "id": 103158, "url": "https://patches.dpdk.org/api/patches/103158/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211028120329.44710-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211028120329.44710-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211028120329.44710-1-maxime.coquelin@redhat.com", "date": "2021-10-28T12:03:29", "name": "vhost: mark vDPA driver API as internal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b959755ab16c5e4e38d71ea7916e07e228b8ee2c", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211028120329.44710-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 20098, "url": "https://patches.dpdk.org/api/series/20098/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20098", "date": "2021-10-28T12:03:29", "name": "vhost: mark vDPA driver API as internal", "version": 1, "mbox": "https://patches.dpdk.org/series/20098/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/103158/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/103158/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4978A0547;\n\tThu, 28 Oct 2021 14:03:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4433C41100;\n\tThu, 28 Oct 2021 14:03:49 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 5442E40DF4\n for <dev@dpdk.org>; Thu, 28 Oct 2021 14:03:47 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-589-uVJ_4JnOPFawwEtNTLS-Fg-1; Thu, 28 Oct 2021 08:03:43 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B677910B744E;\n Thu, 28 Oct 2021 12:03:42 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.32])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 98C80604CC;\n Thu, 28 Oct 2021 12:03:33 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1635422626;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=VDzREgTBTnkxI/t/3Qm5ep0enh8DKaBhU5JQKHIBRJ0=;\n b=amLwzvF4XC5a2HaX8RPzePN05MRFMxCGm2yW/7eg/pMSoMWNN9DFSW2q7zriF+9f+Vm6c+\n WfVz2L3kXAE+NMrvwePWzopyeue1CCHgUEKxVTjSKuc9YhLt2TAkTISYC0u0C/v7EJHU8/\n Cw/YSYYWKHvYXwfLFGFwAPNgSBV+XpM=", "X-MC-Unique": "uVJ_4JnOPFawwEtNTLS-Fg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, xuemingl@nvidia.com,\n xiao.w.wang@intel.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 28 Oct 2021 14:03:29 +0200", "Message-Id": "<20211028120329.44710-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH] vhost: mark vDPA driver API as internal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch marks the vDPA driver APIs as internal and\nrename the corresponding header file.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-\n drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +-\n lib/vhost/meson.build | 4 +++-\n lib/vhost/vdpa.c | 2 +-\n lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} | 6 ++++++\n lib/vhost/version.map | 13 +++++++++----\n lib/vhost/vhost.h | 2 +-\n 7 files changed, 22 insertions(+), 9 deletions(-)\n rename lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} (97%)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex dd5251d382..b80825fcd8 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -17,7 +17,7 @@\n #include <rte_bus_pci.h>\n #include <rte_vhost.h>\n #include <rte_vdpa.h>\n-#include <rte_vdpa_dev.h>\n+#include <vdpa_dev.h>\n #include <rte_vfio.h>\n #include <rte_spinlock.h>\n #include <rte_log.h>\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h\nindex cf4f384fa4..e2db6d432f 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.h\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.h\n@@ -12,7 +12,7 @@\n #pragma GCC diagnostic ignored \"-Wpedantic\"\n #endif\n #include <rte_vdpa.h>\n-#include <rte_vdpa_dev.h>\n+#include <vdpa_dev.h>\n #include <rte_vhost.h>\n #ifdef PEDANTIC\n #pragma GCC diagnostic error \"-Wpedantic\"\ndiff --git a/lib/vhost/meson.build b/lib/vhost/meson.build\nindex 2d8fe0239f..6d2d061141 100644\n--- a/lib/vhost/meson.build\n+++ b/lib/vhost/meson.build\n@@ -29,9 +29,11 @@ sources = files(\n )\n headers = files(\n 'rte_vdpa.h',\n- 'rte_vdpa_dev.h',\n 'rte_vhost.h',\n 'rte_vhost_async.h',\n 'rte_vhost_crypto.h',\n )\n+driver_sdk_headers = files(\n+ 'vdpa_dev.h',\n+)\n deps += ['ethdev', 'cryptodev', 'hash', 'pci']\ndiff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c\nindex 6dd91859ac..778835e14e 100644\n--- a/lib/vhost/vdpa.c\n+++ b/lib/vhost/vdpa.c\n@@ -17,7 +17,7 @@\n #include <rte_tailq.h>\n \n #include \"rte_vdpa.h\"\n-#include \"rte_vdpa_dev.h\"\n+#include \"vdpa_dev.h\"\n #include \"vhost.h\"\n \n /** Double linked list of vDPA devices. */\ndiff --git a/lib/vhost/rte_vdpa_dev.h b/lib/vhost/vdpa_dev.h\nsimilarity index 97%\nrename from lib/vhost/rte_vdpa_dev.h\nrename to lib/vhost/vdpa_dev.h\nindex b0f494815f..2bdd12b3e1 100644\n--- a/lib/vhost/rte_vdpa_dev.h\n+++ b/lib/vhost/vdpa_dev.h\n@@ -7,6 +7,8 @@\n \n #include <stdbool.h>\n \n+#include <rte_compat.h>\n+\n #include \"rte_vhost.h\"\n #include \"rte_vdpa.h\"\n \n@@ -88,6 +90,7 @@ struct rte_vdpa_device {\n * @return\n * vDPA device pointer on success, NULL on failure\n */\n+__rte_internal\n struct rte_vdpa_device *\n rte_vdpa_register_device(struct rte_device *rte_dev,\n \t\tstruct rte_vdpa_dev_ops *ops);\n@@ -100,6 +103,7 @@ rte_vdpa_register_device(struct rte_device *rte_dev,\n * @return\n * device id on success, -1 on failure\n */\n+__rte_internal\n int\n rte_vdpa_unregister_device(struct rte_vdpa_device *dev);\n \n@@ -115,6 +119,7 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev);\n * @return\n * 0 on success, -1 on failure\n */\n+__rte_internal\n int\n rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);\n \n@@ -132,6 +137,7 @@ rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);\n * @return\n * number of synced used entries on success, -1 on failure\n */\n+__rte_internal\n int\n rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);\n \ndiff --git a/lib/vhost/version.map b/lib/vhost/version.map\nindex 8ebde3f694..f3f1a3c93b 100644\n--- a/lib/vhost/version.map\n+++ b/lib/vhost/version.map\n@@ -8,10 +8,7 @@ DPDK_22 {\n \trte_vdpa_get_rte_device;\n \trte_vdpa_get_stats;\n \trte_vdpa_get_stats_names;\n-\trte_vdpa_register_device;\n-\trte_vdpa_relay_vring_used;\n \trte_vdpa_reset_stats;\n-\trte_vdpa_unregister_device;\n \trte_vhost_avail_entries;\n \trte_vhost_clr_inflight_desc_packed;\n \trte_vhost_clr_inflight_desc_split;\n@@ -52,7 +49,6 @@ DPDK_22 {\n \trte_vhost_get_vring_base_from_inflight;\n \trte_vhost_get_vring_num;\n \trte_vhost_gpa_to_vva;\n-\trte_vhost_host_notifier_ctrl;\n \trte_vhost_log_used_vring;\n \trte_vhost_log_write;\n \trte_vhost_rx_queue_count;\n@@ -86,3 +82,12 @@ EXPERIMENTAL {\n \trte_vhost_async_channel_unregister_thread_unsafe;\n \trte_vhost_clear_queue_thread_unsafe;\n };\n+\n+INTERNAL {\n+\tglobal;\n+\n+\trte_vdpa_register_device;\n+\trte_vdpa_unregister_device;\n+\trte_vhost_host_notifier_ctrl;\n+\trte_vdpa_relay_vring_used;\n+};\ndiff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 6c6a2da2c9..521a21b5b6 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -22,7 +22,7 @@\n \n #include \"rte_vhost.h\"\n #include \"rte_vdpa.h\"\n-#include \"rte_vdpa_dev.h\"\n+#include \"vdpa_dev.h\"\n \n #include \"rte_vhost_async.h\"\n \n", "prefixes": [] }