Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 103097,
    "url": "https://patches.dpdk.org/api/patches/103097/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211028065546.3006963-2-s.v.naga.harish.k@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211028065546.3006963-2-s.v.naga.harish.k@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211028065546.3006963-2-s.v.naga.harish.k@intel.com",
    "date": "2021-10-28T06:55:45",
    "name": "[v2,2/3] eventdev/eth_rx: support telemetry",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "08c0f9435195cf95e961f16f3bf9a31011f1a5ec",
    "submitter": {
        "id": 2280,
        "url": "https://patches.dpdk.org/api/people/2280/?format=api",
        "name": "Naga Harish K, S V",
        "email": "s.v.naga.harish.k@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211028065546.3006963-2-s.v.naga.harish.k@intel.com/mbox/",
    "series": [
        {
            "id": 20073,
            "url": "https://patches.dpdk.org/api/series/20073/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20073",
            "date": "2021-10-28T06:55:44",
            "name": "[v2,1/3] eventdev/eth_rx: add queue stats get and reset APIs",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/20073/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/103097/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/103097/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B723CA0C45;\n\tThu, 28 Oct 2021 08:56:17 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 54DAB410F6;\n\tThu, 28 Oct 2021 08:56:17 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id E531E410F5\n for <dev@dpdk.org>; Thu, 28 Oct 2021 08:56:15 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Oct 2021 23:56:15 -0700",
            "from txandevlnx322.an.intel.com ([10.123.117.44])\n by orsmga008.jf.intel.com with ESMTP; 27 Oct 2021 23:56:14 -0700"
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10150\"; a=\"229088967\"",
            "E=Sophos;i=\"5.87,189,1631602800\"; d=\"scan'208\";a=\"229088967\"",
            "E=Sophos;i=\"5.87,189,1631602800\"; d=\"scan'208\";a=\"498251294\""
        ],
        "X-ExtLoop1": "1",
        "From": "Naga Harish K S V <s.v.naga.harish.k@intel.com>",
        "To": "jerinj@marvell.com,\n\tjay.jayatheerthan@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Thu, 28 Oct 2021 01:55:45 -0500",
        "Message-Id": "<20211028065546.3006963-2-s.v.naga.harish.k@intel.com>",
        "X-Mailer": "git-send-email 2.23.0",
        "In-Reply-To": "<20211028065546.3006963-1-s.v.naga.harish.k@intel.com>",
        "References": "<20211028045430.2989816-1-s.v.naga.harish.k@intel.com>\n <20211028065546.3006963-1-s.v.naga.harish.k@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 2/3] eventdev/eth_rx: support telemetry",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Added telemetry support for rxa_queue_stats and\nrxa_queue_stats_reset to get and reset rx queue\nstats respectively\n\nSigned-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>\n---\n lib/eventdev/rte_event_eth_rx_adapter.c | 124 ++++++++++++++++++++++++\n 1 file changed, 124 insertions(+)",
    "diff": "diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c\nindex 31bbceb6c8..8cfc10f0c2 100644\n--- a/lib/eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/eventdev/rte_event_eth_rx_adapter.c\n@@ -3345,6 +3345,122 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static int\n+handle_rxa_get_queue_stats(const char *cmd __rte_unused,\n+\t\t\t   const char *params,\n+\t\t\t   struct rte_tel_data *d)\n+{\n+\tuint8_t rx_adapter_id;\n+\tuint16_t rx_queue_id;\n+\tint eth_dev_id;\n+\tchar *token, *l_params;\n+\tstruct rte_event_eth_rx_adapter_queue_stats q_stats;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\t/* Get Rx adapter ID from parameter string */\n+\tl_params = strdup(params);\n+\ttoken = strtok(l_params, \",\");\n+\trx_adapter_id = strtoul(token, NULL, 10);\n+\tRTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);\n+\n+\ttoken = strtok(NULL, \",\");\n+\tif (token == NULL || strlen(token) == 0 || !isdigit(*token))\n+\t\treturn -1;\n+\n+\t/* Get device ID from parameter string */\n+\teth_dev_id = strtoul(token, NULL, 10);\n+\tRTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);\n+\n+\ttoken = strtok(NULL, \",\");\n+\tif (token == NULL || strlen(token) == 0 || !isdigit(*token))\n+\t\treturn -1;\n+\n+\t/* Get Rx queue ID from parameter string */\n+\trx_queue_id = strtoul(token, NULL, 10);\n+\tif (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid rx queue_id %u\", rx_queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttoken = strtok(NULL, \"\\0\");\n+\tif (token != NULL)\n+\t\tRTE_EDEV_LOG_ERR(\"Extra parameters passed to eventdev\"\n+\t\t\t\t \" telemetry command, igrnoring\");\n+\n+\tif (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,\n+\t\t\t\t\t\t    rx_queue_id, &q_stats)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Failed to get Rx adapter queue stats\");\n+\t\treturn -1;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_u64(d, \"rx_adapter_id\", rx_adapter_id);\n+\trte_tel_data_add_dict_u64(d, \"eth_dev_id\", eth_dev_id);\n+\trte_tel_data_add_dict_u64(d, \"rx_queue_id\", rx_queue_id);\n+\tRXA_ADD_DICT(q_stats, rx_event_buf_count);\n+\tRXA_ADD_DICT(q_stats, rx_event_buf_size);\n+\tRXA_ADD_DICT(q_stats, rx_poll_count);\n+\tRXA_ADD_DICT(q_stats, rx_packets);\n+\tRXA_ADD_DICT(q_stats, rx_dropped);\n+\n+\treturn 0;\n+}\n+\n+static int\n+handle_rxa_queue_stats_reset(const char *cmd __rte_unused,\n+\t\t\t     const char *params,\n+\t\t\t     struct rte_tel_data *d __rte_unused)\n+{\n+\tuint8_t rx_adapter_id;\n+\tuint16_t rx_queue_id;\n+\tint eth_dev_id;\n+\tchar *token, *l_params;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\t/* Get Rx adapter ID from parameter string */\n+\tl_params = strdup(params);\n+\ttoken = strtok(l_params, \",\");\n+\trx_adapter_id = strtoul(token, NULL, 10);\n+\tRTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);\n+\n+\ttoken = strtok(NULL, \",\");\n+\tif (token == NULL || strlen(token) == 0 || !isdigit(*token))\n+\t\treturn -1;\n+\n+\t/* Get device ID from parameter string */\n+\teth_dev_id = strtoul(token, NULL, 10);\n+\tRTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);\n+\n+\ttoken = strtok(NULL, \",\");\n+\tif (token == NULL || strlen(token) == 0 || !isdigit(*token))\n+\t\treturn -1;\n+\n+\t/* Get Rx queue ID from parameter string */\n+\trx_queue_id = strtoul(token, NULL, 10);\n+\tif (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {\n+\t\tRTE_EDEV_LOG_ERR(\"Invalid rx queue_id %u\", rx_queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttoken = strtok(NULL, \"\\0\");\n+\tif (token != NULL)\n+\t\tRTE_EDEV_LOG_ERR(\"Extra parameters passed to eventdev\"\n+\t\t\t\t \" telemetry command, igrnoring\");\n+\n+\tif (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,\n+\t\t\t\t\t\t       eth_dev_id,\n+\t\t\t\t\t\t       rx_queue_id)) {\n+\t\tRTE_EDEV_LOG_ERR(\"Failed to reset Rx adapter queue stats\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n RTE_INIT(rxa_init_telemetry)\n {\n \trte_telemetry_register_cmd(\"/eventdev/rxa_stats\",\n@@ -3358,4 +3474,12 @@ RTE_INIT(rxa_init_telemetry)\n \trte_telemetry_register_cmd(\"/eventdev/rxa_queue_conf\",\n \t\thandle_rxa_get_queue_conf,\n \t\t\"Returns Rx queue config. Parameter: rxa_id, dev_id, queue_id\");\n+\n+\trte_telemetry_register_cmd(\"/eventdev/rxa_queue_stats\",\n+\t\thandle_rxa_get_queue_stats,\n+\t\t\"Returns Rx queue stats. Parameter: rxa_id, dev_id, queue_id\");\n+\n+\trte_telemetry_register_cmd(\"/eventdev/rxa_queue_stats_reset\",\n+\t\thandle_rxa_queue_stats_reset,\n+\t\t\"Reset Rx queue stats. Parameter: rxa_id, dev_id, queue_id\");\n }\n",
    "prefixes": [
        "v2",
        "2/3"
    ]
}