Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 103026,
    "url": "https://patches.dpdk.org/api/patches/103026/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211027091429.2996153-1-ferruh.yigit@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211027091429.2996153-1-ferruh.yigit@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211027091429.2996153-1-ferruh.yigit@intel.com",
    "date": "2021-10-27T09:14:28",
    "name": "[v2,1/2] net/af_packet: fix driver init with default MTU",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "57bed558c1361476ba086317c958b5ee082fb884",
    "submitter": {
        "id": 324,
        "url": "https://patches.dpdk.org/api/people/324/?format=api",
        "name": "Ferruh Yigit",
        "email": "ferruh.yigit@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211027091429.2996153-1-ferruh.yigit@intel.com/mbox/",
    "series": [
        {
            "id": 20042,
            "url": "https://patches.dpdk.org/api/series/20042/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=20042",
            "date": "2021-10-27T09:14:28",
            "name": "[v2,1/2] net/af_packet: fix driver init with default MTU",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/20042/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/103026/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/103026/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4EC12A0C47;\n\tWed, 27 Oct 2021 11:14:38 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A85140DDA;\n\tWed, 27 Oct 2021 11:14:38 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 4CB544068C\n for <dev@dpdk.org>; Wed, 27 Oct 2021 11:14:36 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Oct 2021 02:14:35 -0700",
            "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by orsmga008.jf.intel.com with ESMTP; 27 Oct 2021 02:14:31 -0700"
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10149\"; a=\"290953188\"",
            "E=Sophos;i=\"5.87,186,1631602800\"; d=\"scan'208\";a=\"290953188\"",
            "E=Sophos;i=\"5.87,186,1631602800\"; d=\"scan'208\";a=\"497781831\""
        ],
        "X-ExtLoop1": "1",
        "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
        "To": "\"John W. Linville\" <linville@tuxdriver.com>,\n Hyong Youb Kim <hyonkim@cisco.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Huisong Li <lihuisong@huawei.com>",
        "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tdev@dpdk.org",
        "Date": "Wed, 27 Oct 2021 10:14:28 +0100",
        "Message-Id": "<20211027091429.2996153-1-ferruh.yigit@intel.com>",
        "X-Mailer": "git-send-email 2.31.1",
        "In-Reply-To": "<20211026153802.1820636-1-ferruh.yigit@intel.com>",
        "References": "<20211026153802.1820636-1-ferruh.yigit@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 1/2] net/af_packet: fix driver init with\n default MTU",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length,\nwhich doesn't include FCS (4 bytes CRC). But ethdev by default uses\nframe size with FCS when application doesn't define any explicit value.\n\nAs a result device configuration fails because device is tried to be\nconfigured with a frame size length that is bigger than what device\nreported as supported. Device reports as max supported frame size is\n1514 but configured value is 1518.\n\nInstead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the\ndriver to report the max supported frame size, this matches to the\ninitial intention.\n\nFixes: 1bb4a528c41f (\"ethdev: fix max Rx packet length\")\n\nReported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv2:\n* Remove unnecessary cast\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 559f5a03e509..cea7091c0639 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -342,7 +342,7 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \n \tdev_info->if_index = internals->if_index;\n \tdev_info->max_mac_addrs = 1;\n-\tdev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN;\n+\tdev_info->max_rx_pktlen = RTE_ETHER_MAX_LEN;\n \tdev_info->max_rx_queues = (uint16_t)internals->nb_queues;\n \tdev_info->max_tx_queues = (uint16_t)internals->nb_queues;\n \tdev_info->min_rx_bufsize = 0;\n",
    "prefixes": [
        "v2",
        "1/2"
    ]
}