Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102831/?format=api
{ "id": 102831, "url": "https://patches.dpdk.org/api/patches/102831/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211026041300.28924-2-radhac@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211026041300.28924-2-radhac@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211026041300.28924-2-radhac@marvell.com", "date": "2021-10-26T04:12:58", "name": "[2/4] dma/cnxk: create and initialize dmadev on pci probe", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c4691540fd8439a86d842c352ac00c2d5ecd721f", "submitter": { "id": 2007, "url": "https://patches.dpdk.org/api/people/2007/?format=api", "name": "Radha Chintakuntla", "email": "radhac@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211026041300.28924-2-radhac@marvell.com/mbox/", "series": [ { "id": 19972, "url": "https://patches.dpdk.org/api/series/19972/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19972", "date": "2021-10-26T04:12:58", "name": "[1/4] common/cnxk: add DPI DMA support", "version": 1, "mbox": "https://patches.dpdk.org/series/19972/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102831/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/102831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CF4CA0C47;\n\tTue, 26 Oct 2021 06:13:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 153FD40A4B;\n\tTue, 26 Oct 2021 06:13:27 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id D61324003E\n for <dev@dpdk.org>; Tue, 26 Oct 2021 06:13:24 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 19PLKxk2012626;\n Mon, 25 Oct 2021 21:13:24 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3bx4dx196y-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 25 Oct 2021 21:13:23 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 25 Oct 2021 21:13:21 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 25 Oct 2021 21:13:21 -0700", "from rchintakuntla-lnx3.caveonetworks.com (unknown [10.111.140.81])\n by maili.marvell.com (Postfix) with ESMTP id CFDA53F708F;\n Mon, 25 Oct 2021 21:13:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=Fd084egjB+iuMAObW2F8Dl6rpYZXLIVOgUuvCEPmNcM=;\n b=WfFMd3EBGmbM2kLxN5RYfEBKvi501aDbUEOmdhWuMb8u6pIMhm27n+rU3ZEYDyn2MhsK\n KoONP/SUQHZClD5YwQaJ7ROIi33HTPRGQBJiOVMIEYw4kY0rPXxWqkgWQ47SoBCRnzfY\n 5UlS+yqwu4CS6ZpMbncKA4WKBaTPay1dm8Cbw9iBw7jQ+kzGkHXwihQoBNj1yNNBUheL\n NJfGrlN7KYgUoQ4t0bvC7mxTJZuT8ulf3mtRUdVsPtCGAKBO/InZkCbTGm8EngJloFs2\n gw8DfYCIBzvl8l4kkU62T6hNd25Dp5kfeENQD+9Anj+HqzAn/AIwY95sVmj8WqhiDL9B PQ==", "From": "Radha Mohan Chintakuntla <radhac@marvell.com>", "To": "<thomas@monjalon.net>, <fengchengwen@huawei.com>,\n <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,\n <skori@marvell.com>, <skoteshwar@marvell.com>, <jerinj@marvell.com>,\n <sburla@marvell.com>", "CC": "<dev@dpdk.org>, Radha Mohan Chintakuntla <radhac@marvell.com>", "Date": "Mon, 25 Oct 2021 21:12:58 -0700", "Message-ID": "<20211026041300.28924-2-radhac@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211026041300.28924-1-radhac@marvell.com>", "References": "<20211026041300.28924-1-radhac@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "FDFYxveDF_BJWknFxnvr9LA8m2SBp6Sr", "X-Proofpoint-ORIG-GUID": "FDFYxveDF_BJWknFxnvr9LA8m2SBp6Sr", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-25_08,2021-10-25_02,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH 2/4] dma/cnxk: create and initialize dmadev on\n pci probe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch creates and initializes a dmadev device on pci probe.\n\nSigned-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>\n---\n MAINTAINERS | 7 +-\n doc/guides/dmadevs/cnxk.rst | 53 +++++++++++++++\n doc/guides/dmadevs/index.rst | 1 +\n drivers/dma/cnxk/cnxk_dmadev.c | 119 +++++++++++++++++++++++++++++++++\n drivers/dma/cnxk/cnxk_dmadev.h | 11 +++\n drivers/dma/cnxk/meson.build | 7 ++\n drivers/dma/meson.build | 1 +\n 7 files changed, 198 insertions(+), 1 deletion(-)\n create mode 100644 doc/guides/dmadevs/cnxk.rst\n create mode 100644 drivers/dma/cnxk/cnxk_dmadev.c\n create mode 100644 drivers/dma/cnxk/cnxk_dmadev.h\n create mode 100644 drivers/dma/cnxk/meson.build", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex be2c9b6815..cdc2d98a6b 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -1186,7 +1186,6 @@ F: drivers/compress/zlib/\n F: doc/guides/compressdevs/zlib.rst\n F: doc/guides/compressdevs/features/zlib.ini\n \n-\n DMAdev Drivers\n --------------\n \n@@ -1202,6 +1201,12 @@ M: Conor Walsh <conor.walsh@intel.com>\n F: drivers/dma/ioat/\n F: doc/guides/dmadevs/ioat.rst\n \n+Marvell CNXK DPI DMA\n+M: Radha Mohan Chintakuntla <radhac@marvell.com>\n+M: Veerasenareddy Burru <vburru@marvell.com>\n+F: drivers/dma/cnxk/\n+F: doc/guides/dmadevs/cnxk.rst\n+\n \n RegEx Drivers\n -------------\ndiff --git a/doc/guides/dmadevs/cnxk.rst b/doc/guides/dmadevs/cnxk.rst\nnew file mode 100644\nindex 0000000000..8ae7c1f8cd\n--- /dev/null\n+++ b/doc/guides/dmadevs/cnxk.rst\n@@ -0,0 +1,53 @@\n+.. SPDX-License-Identifier: BSD-3-Clause\n+ Copyright(c) 2021 Marvell International Ltd.\n+\n+.. include:: <isonum.txt>\n+\n+CNXK DMA Device Driver\n+======================\n+\n+The ``cnxk`` dmadev driver provides a poll-mode driver (PMD) for Marvell DPI DMA\n+Hardware Accelerator block found in OCTEONTX2 and OCTEONTX3 family of SoCs. Each\n+DMA queue is exposed as a VF function when SRIOV is enabled.\n+\n+The block supports following modes of DMA transfers\n+\n+#. Internal - DMA within SoC DRAM to DRAM\n+\n+#. Inbound - Host DRAM to SoC DRAM when SoC is in PCIe Endpoint\n+\n+#. Outbound - SoC DRAM to Host DRAM when SoC is in PCIe Endpoint\n+\n+Device Setup\n+-------------\n+The ``dpdk-devbind.py`` script, included with DPDK, can be used to show the\n+presence of supported hardware. Running ``dpdk-devbind.py --status-dev dma``\n+will show all the CNXK DMA devices.\n+\n+Devices using VFIO drivers\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+The HW devices to be used will need to be bound to a user-space IO driver for use.\n+The ``dpdk-devbind.py`` script can be used to view the state of the devices\n+and to bind them to a suitable DPDK-supported driver, such as ``vfio-pci``.\n+For example::\n+\n+ $ dpdk-devbind.py -b vfio-pci 0000:05:00.1\n+\n+Device Probing and Initialization\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+To use the devices from an application, the dmadev API can be used.\n+CNXK DMA device configuration requirements:\n+\n+* Only one ``vchan`` is supported per device.\n+* CNXK DMA devices do not support silent mode.\n+\n+Once configured, the device can then be made ready for use by calling the\n+ ``rte_dma_start()`` API.\n+\n+Performing Data Copies\n+~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Refer to the :ref:`Enqueue / Dequeue APIs <dmadev_enqueue_dequeue>` section of the dmadev library\n+documentation for details on operation enqueue and submission API usage.\ndiff --git a/doc/guides/dmadevs/index.rst b/doc/guides/dmadevs/index.rst\nindex 20476039a5..227fa00c68 100644\n--- a/doc/guides/dmadevs/index.rst\n+++ b/doc/guides/dmadevs/index.rst\n@@ -11,5 +11,6 @@ an application through DMA API.\n :maxdepth: 2\n :numbered:\n \n+ cnxk\n idxd\n ioat\ndiff --git a/drivers/dma/cnxk/cnxk_dmadev.c b/drivers/dma/cnxk/cnxk_dmadev.c\nnew file mode 100644\nindex 0000000000..620766743d\n--- /dev/null\n+++ b/drivers/dma/cnxk/cnxk_dmadev.c\n@@ -0,0 +1,119 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) 2021 Marvell International Ltd.\n+ */\n+\n+#include <string.h>\n+#include <unistd.h>\n+\n+#include <rte_bus.h>\n+#include <rte_bus_pci.h>\n+#include <rte_common.h>\n+#include <rte_eal.h>\n+#include <rte_lcore.h>\n+#include <rte_mempool.h>\n+#include <rte_pci.h>\n+#include <rte_dmadev.h>\n+#include <rte_dmadev_pmd.h>\n+\n+#include <roc_api.h>\n+#include <cnxk_dmadev.h>\n+\n+static int\n+cnxk_dmadev_probe(struct rte_pci_driver *pci_drv __rte_unused,\n+\t\t struct rte_pci_device *pci_dev)\n+{\n+\tstruct cnxk_dpi_vf_s *dpivf = NULL;\n+\tchar name[RTE_DEV_NAME_MAX_LEN];\n+\tstruct rte_dma_dev *dmadev;\n+\tstruct roc_dpi *rdpi = NULL;\n+\tint rc;\n+\n+\tif (!pci_dev->mem_resource[0].addr)\n+\t\treturn -ENODEV;\n+\n+\trc = roc_plt_init();\n+\tif (rc) {\n+\t\tplt_err(\"Failed to initialize platform model, rc=%d\", rc);\n+\t\treturn rc;\n+\t}\n+\tmemset(name, 0, sizeof(name));\n+\trte_pci_device_name(&pci_dev->addr, name, sizeof(name));\n+\n+\tdmadev = rte_dma_pmd_allocate(name, pci_dev->device.numa_node,\n+\t\t\t\t sizeof(*dpivf));\n+\tif (dmadev == NULL) {\n+\t\tplt_err(\"dma device allocation failed for %s\", name);\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tdpivf = dmadev->data->dev_private;\n+\n+\tdmadev->device = &pci_dev->device;\n+\tdmadev->fp_obj->dev_private = dpivf;\n+\n+\trdpi = &dpivf->rdpi;\n+\n+\trdpi->pci_dev = pci_dev;\n+\trc = roc_dpi_dev_init(rdpi);\n+\tif (rc < 0)\n+\t\tgoto err_out_free;\n+\n+\treturn 0;\n+\n+err_out_free:\n+\tif (dmadev)\n+\t\trte_dma_pmd_release(name);\n+\n+\treturn rc;\n+}\n+\n+static int\n+cnxk_dmadev_remove(struct rte_pci_device *pci_dev)\n+{\n+\tchar name[RTE_DEV_NAME_MAX_LEN];\n+\tstruct rte_dma_dev *dmadev;\n+\tstruct cnxk_dpi_vf_s *dpivf;\n+\tint dev_id;\n+\n+\tmemset(name, 0, sizeof(name));\n+\trte_pci_device_name(&pci_dev->addr, name, sizeof(name));\n+\n+\tdev_id = rte_dma_get_dev_id_by_name(name);\n+\tif (dev_id < 0) {\n+\t\tplt_err(\"Invalid device ID\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdmadev = &rte_dma_devices[dev_id];\n+\tif (!dmadev) {\n+\t\tplt_err(\"dmadev with name %s not found\\n\", name);\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tdpivf = dmadev->fp_obj->dev_private;\n+\troc_dpi_queue_stop(&dpivf->rdpi);\n+\troc_dpi_dev_fini(&dpivf->rdpi);\n+\n+\treturn rte_dma_pmd_release(name);\n+}\n+\n+static const struct rte_pci_id cnxk_dma_pci_map[] = {\n+\t{\n+\t\tRTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM,\n+\t\t\t PCI_DEVID_CNXK_DPI_VF)\n+\t},\n+\t{\n+\t\t.vendor_id = 0,\n+\t},\n+};\n+\n+static struct rte_pci_driver cnxk_dmadev = {\n+\t.id_table = cnxk_dma_pci_map,\n+\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_NEED_IOVA_AS_VA,\n+\t.probe = cnxk_dmadev_probe,\n+\t.remove = cnxk_dmadev_remove,\n+};\n+\n+RTE_PMD_REGISTER_PCI(cnxk_dmadev_pci_driver, cnxk_dmadev);\n+RTE_PMD_REGISTER_PCI_TABLE(cnxk_dmadev_pci_driver, cnxk_dma_pci_map);\n+RTE_PMD_REGISTER_KMOD_DEP(cnxk_dmadev_pci_driver, \"vfio-pci\");\ndiff --git a/drivers/dma/cnxk/cnxk_dmadev.h b/drivers/dma/cnxk/cnxk_dmadev.h\nnew file mode 100644\nindex 0000000000..9e0bb7b2ce\n--- /dev/null\n+++ b/drivers/dma/cnxk/cnxk_dmadev.h\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2021 Marvell International Ltd.\n+ */\n+#ifndef _CNXK_DMADEV_H_\n+#define _CNXK_DMADEV_H_\n+\n+struct cnxk_dpi_vf_s {\n+\tstruct roc_dpi rdpi;\n+};\n+\n+#endif\ndiff --git a/drivers/dma/cnxk/meson.build b/drivers/dma/cnxk/meson.build\nnew file mode 100644\nindex 0000000000..9489d6e6dc\n--- /dev/null\n+++ b/drivers/dma/cnxk/meson.build\n@@ -0,0 +1,7 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(C) 2021 Marvell International Ltd.\n+#\n+\n+deps += ['bus_pci', 'common_cnxk', 'dmadev']\n+sources = files('cnxk_dmadev.c')\n+headers = files('cnxk_dmadev.h')\ndiff --git a/drivers/dma/meson.build b/drivers/dma/meson.build\nindex a69418ce9b..c562c8b429 100644\n--- a/drivers/dma/meson.build\n+++ b/drivers/dma/meson.build\n@@ -2,6 +2,7 @@\n # Copyright 2021 HiSilicon Limited\n \n drivers = [\n+ 'cnxk',\n 'idxd',\n 'ioat',\n 'skeleton',\n", "prefixes": [ "2/4" ] }