Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102748/?format=api
{ "id": 102748, "url": "https://patches.dpdk.org/api/patches/102748/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1635148553-50086-1-git-send-email-chcchc88@163.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1635148553-50086-1-git-send-email-chcchc88@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1635148553-50086-1-git-send-email-chcchc88@163.com", "date": "2021-10-25T07:55:53", "name": "ip_frag: fix the buf of fragmenting IPv4 fragment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d304f839ae97d5f6c43dd0c7a27c01f7da99d4d1", "submitter": { "id": 2371, "url": "https://patches.dpdk.org/api/people/2371/?format=api", "name": "Huichao Cai", "email": "chcchc88@163.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1635148553-50086-1-git-send-email-chcchc88@163.com/mbox/", "series": [ { "id": 19948, "url": "https://patches.dpdk.org/api/series/19948/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19948", "date": "2021-10-25T07:55:53", "name": "ip_frag: fix the buf of fragmenting IPv4 fragment", "version": 1, "mbox": "https://patches.dpdk.org/series/19948/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102748/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/102748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6BFD4A0C45;\n\tMon, 25 Oct 2021 09:56:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 038DE407FF;\n\tMon, 25 Oct 2021 09:56:27 +0200 (CEST)", "from m12-11.163.com (m12-11.163.com [220.181.12.11])\n by mails.dpdk.org (Postfix) with ESMTP id D0F884003E;\n Mon, 25 Oct 2021 09:56:24 +0200 (CEST)", "from bogon.localdomain (unknown [36.112.33.106])\n by smtp7 (Coremail) with SMTP id C8CowAD3itgVY3ZhoaaBBA--.28938S2;\n Mon, 25 Oct 2021 15:56:19 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id; bh=Zvp56h5hNUA5mUEbsi\n o6R8yBxOTyLP0MWPgMIAuSYi8=; b=DM/TsZC9gsEPYFIoTO3M5yxF8ciT7KzqCN\n 0pXSrWZ5W2XhtoeFt8gpeZuCuc3GqK9cTqehjY9RuHfkrcQPetcOm1Vp0+HTltkK\n xLIUIyzFgY9OoG3XkRSmL/l/KPWgp1kfgXm9q+2sbUZ9hp697TtcVtVxvIc6ADPV\n ccIAiW9MY=", "From": "huichao cai <chcchc88@163.com>", "To": "dev@dpdk.org", "Cc": "konstantin.ananyev@intel.com,\n\tstable@dpdk.org", "Date": "Mon, 25 Oct 2021 15:55:53 +0800", "Message-Id": "<1635148553-50086-1-git-send-email-chcchc88@163.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-CM-TRANSID": "C8CowAD3itgVY3ZhoaaBBA--.28938S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7CFWfGFW7Ar17ZFy8Zr43ZFb_yoW8CF1rpa\n 48Jr9IqF1ftF1kGw4kXrs0qw45JasFgF4jqrn5Gr93tFsF9rykJayakr4Iyr1Ig348A3s3\n AwsIkFyrua1xWw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j-WrXUUUUU=", "X-Originating-IP": "[36.112.33.106]", "X-CM-SenderInfo": "pfkfuxrfyyqiywtou0bp/1tbiJgQ3F1v2kJXenQAAsp", "Subject": "[dpdk-dev] [PATCH] ip_frag: fix the buf of fragmenting IPv4 fragment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch (\"ip_frag: fix fragmenting IPv4 fragment\") introduces\na bug and needs to be rolled back. This is because the patch\nand variables \"flag_offset\" conflict with each other.\n\nBugzilla ID: 835\nFixes: 567473433b7e (\"ip_frag: fix fragmenting IPv4 fragment\")\nCc: stable@dpdk.org\nSigned-off-by: huichao cai <chcchc88@163.com>\n---\n lib/ip_frag/rte_ipv4_fragmentation.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/ip_frag/rte_ipv4_fragmentation.c b/lib/ip_frag/rte_ipv4_fragmentation.c\nindex fead5a9..2e7739d 100644\n--- a/lib/ip_frag/rte_ipv4_fragmentation.c\n+++ b/lib/ip_frag/rte_ipv4_fragmentation.c\n@@ -75,7 +75,7 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)\n \tuint32_t out_pkt_pos, in_seg_data_pos;\n \tuint32_t more_in_segs;\n \tuint16_t fragment_offset, flag_offset, frag_size, header_len;\n-\tuint16_t frag_bytes_remaining, not_last_frag;\n+\tuint16_t frag_bytes_remaining;\n \n \t/*\n \t * Formal parameter checking.\n@@ -116,9 +116,7 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)\n \tin_seg = pkt_in;\n \tin_seg_data_pos = header_len;\n \tout_pkt_pos = 0;\n-\tfragment_offset = (uint16_t)((flag_offset &\n-\t RTE_IPV4_HDR_OFFSET_MASK) << RTE_IPV4_HDR_FO_SHIFT);\n-\tnot_last_frag = (uint16_t)(flag_offset & IPV4_HDR_MF_MASK);\n+\tfragment_offset = 0;\n \n \tmore_in_segs = 1;\n \twhile (likely(more_in_segs)) {\n@@ -188,8 +186,7 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)\n \n \t\t__fill_ipv4hdr_frag(out_hdr, in_hdr, header_len,\n \t\t (uint16_t)out_pkt->pkt_len,\n-\t\t flag_offset, fragment_offset,\n-\t\t not_last_frag || more_in_segs);\n+\t\t flag_offset, fragment_offset, more_in_segs);\n \n \t\tfragment_offset = (uint16_t)(fragment_offset +\n \t\t out_pkt->pkt_len - header_len);\n", "prefixes": [] }