Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102651/?format=api
{ "id": 102651, "url": "https://patches.dpdk.org/api/patches/102651/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211022092006.60959-14-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211022092006.60959-14-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211022092006.60959-14-humin29@huawei.com", "date": "2021-10-22T09:20:04", "name": "[13/14] net/hns3: refactor hns3 set MC MAC addr list API for PF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c62a6f9a53766481bf31012b333e31c7b16aa9c9", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211022092006.60959-14-humin29@huawei.com/mbox/", "series": [ { "id": 19904, "url": "https://patches.dpdk.org/api/series/19904/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19904", "date": "2021-10-22T09:19:54", "name": "refactor MAC handling for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/19904/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102651/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/102651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CDA83A0C43;\n\tFri, 22 Oct 2021 11:23:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A7669411E5;\n\tFri, 22 Oct 2021 11:22:15 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id EAC1541103\n for <dev@dpdk.org>; Fri, 22 Oct 2021 11:21:59 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HbJdv3WdWzbhGT;\n Fri, 22 Oct 2021 17:17:23 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.15; Fri, 22 Oct 2021 17:21:58 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Fri, 22 Oct 2021 17:20:04 +0800", "Message-ID": "<20211022092006.60959-14-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211022092006.60959-1-humin29@huawei.com>", "References": "<20211022092006.60959-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 13/14] net/hns3: refactor hns3 set MC MAC addr\n list API for PF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, when configuring a group of multicast MAC addresses, the PF\ndriver reorder mc_addr array in hw struct to remove multicast MAC addresses\nthat are not in mc_addr_set array from user and then adds new multicast MAC\naddresses. Actually, it can be simplified by removing all previous MAC\naddresses and then adding new MAC addresses.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 112 ++++-----------------------------\n 1 file changed, 11 insertions(+), 101 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex af956854b1..f627f494b6 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2015,94 +2015,15 @@ hns3_set_mc_addr_chk_param(struct hns3_hw *hw,\n \treturn 0;\n }\n \n-static void\n-hns3_set_mc_addr_calc_addr(struct hns3_hw *hw,\n-\t\t\t struct rte_ether_addr *mc_addr_set,\n-\t\t\t int mc_addr_num,\n-\t\t\t struct rte_ether_addr *reserved_addr_list,\n-\t\t\t int *reserved_addr_num,\n-\t\t\t struct rte_ether_addr *add_addr_list,\n-\t\t\t int *add_addr_num,\n-\t\t\t struct rte_ether_addr *rm_addr_list,\n-\t\t\t int *rm_addr_num)\n-{\n-\tstruct rte_ether_addr *addr;\n-\tint current_addr_num;\n-\tint reserved_num = 0;\n-\tint add_num = 0;\n-\tint rm_num = 0;\n-\tint num;\n-\tint i;\n-\tint j;\n-\tbool same_addr;\n-\n-\t/* Calculate the mc mac address list that should be removed */\n-\tcurrent_addr_num = hw->mc_addrs_num;\n-\tfor (i = 0; i < current_addr_num; i++) {\n-\t\taddr = &hw->mc_addrs[i];\n-\t\tsame_addr = false;\n-\t\tfor (j = 0; j < mc_addr_num; j++) {\n-\t\t\tif (rte_is_same_ether_addr(addr, &mc_addr_set[j])) {\n-\t\t\t\tsame_addr = true;\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t}\n-\n-\t\tif (!same_addr) {\n-\t\t\trte_ether_addr_copy(addr, &rm_addr_list[rm_num]);\n-\t\t\trm_num++;\n-\t\t} else {\n-\t\t\trte_ether_addr_copy(addr,\n-\t\t\t\t\t &reserved_addr_list[reserved_num]);\n-\t\t\treserved_num++;\n-\t\t}\n-\t}\n-\n-\t/* Calculate the mc mac address list that should be added */\n-\tfor (i = 0; i < mc_addr_num; i++) {\n-\t\taddr = &mc_addr_set[i];\n-\t\tsame_addr = false;\n-\t\tfor (j = 0; j < current_addr_num; j++) {\n-\t\t\tif (rte_is_same_ether_addr(addr, &hw->mc_addrs[j])) {\n-\t\t\t\tsame_addr = true;\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t}\n-\n-\t\tif (!same_addr) {\n-\t\t\trte_ether_addr_copy(addr, &add_addr_list[add_num]);\n-\t\t\tadd_num++;\n-\t\t}\n-\t}\n-\n-\t/* Reorder the mc mac address list maintained by driver */\n-\tfor (i = 0; i < reserved_num; i++)\n-\t\trte_ether_addr_copy(&reserved_addr_list[i], &hw->mc_addrs[i]);\n-\n-\tfor (i = 0; i < rm_num; i++) {\n-\t\tnum = reserved_num + i;\n-\t\trte_ether_addr_copy(&rm_addr_list[i], &hw->mc_addrs[num]);\n-\t}\n-\n-\t*reserved_addr_num = reserved_num;\n-\t*add_addr_num = add_num;\n-\t*rm_addr_num = rm_num;\n-}\n-\n static int\n hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev,\n \t\t\t struct rte_ether_addr *mc_addr_set,\n \t\t\t uint32_t nb_mc_addr)\n {\n \tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_ether_addr reserved_addr_list[HNS3_MC_MACADDR_NUM];\n-\tstruct rte_ether_addr add_addr_list[HNS3_MC_MACADDR_NUM];\n-\tstruct rte_ether_addr rm_addr_list[HNS3_MC_MACADDR_NUM];\n \tstruct rte_ether_addr *addr;\n-\tint reserved_addr_num;\n-\tint add_addr_num;\n-\tint rm_addr_num;\n-\tint mc_addr_num;\n+\tint cur_addr_num;\n+\tint set_addr_num;\n \tint num;\n \tint ret;\n \tint i;\n@@ -2113,40 +2034,29 @@ hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev,\n \t\treturn ret;\n \n \trte_spinlock_lock(&hw->lock);\n-\n-\t/*\n-\t * Calculate the mc mac address lists those should be removed and be\n-\t * added, Reorder the mc mac address list maintained by driver.\n-\t */\n-\tmc_addr_num = (int)nb_mc_addr;\n-\thns3_set_mc_addr_calc_addr(hw, mc_addr_set, mc_addr_num,\n-\t\t\t\t reserved_addr_list, &reserved_addr_num,\n-\t\t\t\t add_addr_list, &add_addr_num,\n-\t\t\t\t rm_addr_list, &rm_addr_num);\n-\n-\t/* Remove mc mac addresses */\n-\tfor (i = 0; i < rm_addr_num; i++) {\n-\t\tnum = rm_addr_num - i - 1;\n-\t\taddr = &rm_addr_list[num];\n+\tcur_addr_num = hw->mc_addrs_num;\n+\tfor (i = 0; i < cur_addr_num; i++) {\n+\t\tnum = cur_addr_num - i - 1;\n+\t\taddr = &hw->mc_addrs[num];\n \t\tret = hw->ops.del_mc_mac_addr(hw, addr);\n \t\tif (ret) {\n \t\t\trte_spinlock_unlock(&hw->lock);\n \t\t\treturn ret;\n \t\t}\n+\n \t\thw->mc_addrs_num--;\n \t}\n \n-\t/* Add mc mac addresses */\n-\tfor (i = 0; i < add_addr_num; i++) {\n-\t\taddr = &add_addr_list[i];\n+\tset_addr_num = (int)nb_mc_addr;\n+\tfor (i = 0; i < set_addr_num; i++) {\n+\t\taddr = &mc_addr_set[i];\n \t\tret = hw->ops.add_mc_mac_addr(hw, addr);\n \t\tif (ret) {\n \t\t\trte_spinlock_unlock(&hw->lock);\n \t\t\treturn ret;\n \t\t}\n \n-\t\tnum = reserved_addr_num + i;\n-\t\trte_ether_addr_copy(addr, &hw->mc_addrs[num]);\n+\t\trte_ether_addr_copy(addr, &hw->mc_addrs[hw->mc_addrs_num]);\n \t\thw->mc_addrs_num++;\n \t}\n \trte_spinlock_unlock(&hw->lock);\n", "prefixes": [ "13/14" ] }