Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102650/?format=api
{ "id": 102650, "url": "https://patches.dpdk.org/api/patches/102650/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211022092006.60959-15-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211022092006.60959-15-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211022092006.60959-15-humin29@huawei.com", "date": "2021-10-22T09:20:05", "name": "[14/14] net/hns3: replace set MC MAC addr list API in VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a551740b5512ce81aaf92a758feb2a77255b2b1c", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211022092006.60959-15-humin29@huawei.com/mbox/", "series": [ { "id": 19904, "url": "https://patches.dpdk.org/api/series/19904/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19904", "date": "2021-10-22T09:19:54", "name": "refactor MAC handling for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/19904/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102650/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/102650/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E636A0C43;\n\tFri, 22 Oct 2021 11:23:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8FD1E411E0;\n\tFri, 22 Oct 2021 11:22:14 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 0AE4441189\n for <dev@dpdk.org>; Fri, 22 Oct 2021 11:22:00 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HbJdv5XdrzbnMv;\n Fri, 22 Oct 2021 17:17:23 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.15; Fri, 22 Oct 2021 17:21:58 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Fri, 22 Oct 2021 17:20:05 +0800", "Message-ID": "<20211022092006.60959-15-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211022092006.60959-1-humin29@huawei.com>", "References": "<20211022092006.60959-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 14/14] net/hns3: replace set MC MAC addr list API\n in VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThis patch removes hns3vf_set_mc_mac_addr_list() and uses\nhns3_set_mc_mac_addr_list() to do this.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 4 +--\n drivers/net/hns3/hns3_ethdev.h | 7 ++---\n drivers/net/hns3/hns3_ethdev_vf.c | 50 +------------------------------\n 3 files changed, 6 insertions(+), 55 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex f627f494b6..96b559fc1f 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -1947,7 +1947,7 @@ hns3_remove_mc_mac_addr(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)\n \treturn ret;\n }\n \n-int\n+static int\n hns3_set_mc_addr_chk_param(struct hns3_hw *hw,\n \t\t\t struct rte_ether_addr *mc_addr_set,\n \t\t\t uint32_t nb_mc_addr)\n@@ -2015,7 +2015,7 @@ hns3_set_mc_addr_chk_param(struct hns3_hw *hw,\n \treturn 0;\n }\n \n-static int\n+int\n hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev,\n \t\t\t struct rte_ether_addr *mc_addr_set,\n \t\t\t uint32_t nb_mc_addr)\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 762f03124f..d3b97bfe28 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -1061,15 +1061,14 @@ void hns3vf_update_link_status(struct hns3_hw *hw, uint8_t link_status,\n \t\t\t uint32_t link_speed, uint8_t link_duplex);\n void hns3_parse_devargs(struct rte_eth_dev *dev);\n void hns3vf_update_push_lsc_cap(struct hns3_hw *hw, bool supported);\n-int hns3_set_mc_addr_chk_param(struct hns3_hw *hw,\n-\t\t\tstruct rte_ether_addr *mc_addr_set,\n-\t\t\tuint32_t nb_mc_addr);\n int hns3_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del);\n int hns3_configure_all_mac_addr(struct hns3_adapter *hns, bool del);\n int hns3_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n \t\t__rte_unused uint32_t idx, __rte_unused uint32_t pool);\n void hns3_remove_mac_addr(struct rte_eth_dev *dev, uint32_t idx);\n-\n+int hns3_set_mc_mac_addr_list(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_ether_addr *mc_addr_set,\n+\t\t\t\t\t\t\tuint32_t nb_mc_addr);\n int hns3_restore_ptp(struct hns3_adapter *hns);\n int hns3_mbuf_dyn_rx_timestamp_register(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_conf *conf);\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 484ff24145..ab92c4f88f 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -299,54 +299,6 @@ hns3vf_remove_mc_mac_addr(struct hns3_hw *hw,\n \treturn ret;\n }\n \n-static int\n-hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev,\n-\t\t\t struct rte_ether_addr *mc_addr_set,\n-\t\t\t uint32_t nb_mc_addr)\n-{\n-\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_ether_addr *addr;\n-\tint cur_addr_num;\n-\tint set_addr_num;\n-\tint num;\n-\tint ret;\n-\tint i;\n-\n-\tret = hns3_set_mc_addr_chk_param(hw, mc_addr_set, nb_mc_addr);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\trte_spinlock_lock(&hw->lock);\n-\tcur_addr_num = hw->mc_addrs_num;\n-\tfor (i = 0; i < cur_addr_num; i++) {\n-\t\tnum = cur_addr_num - i - 1;\n-\t\taddr = &hw->mc_addrs[num];\n-\t\tret = hw->ops.del_mc_mac_addr(hw, addr);\n-\t\tif (ret) {\n-\t\t\trte_spinlock_unlock(&hw->lock);\n-\t\t\treturn ret;\n-\t\t}\n-\n-\t\thw->mc_addrs_num--;\n-\t}\n-\n-\tset_addr_num = (int)nb_mc_addr;\n-\tfor (i = 0; i < set_addr_num; i++) {\n-\t\taddr = &mc_addr_set[i];\n-\t\tret = hw->ops.add_mc_mac_addr(hw, addr);\n-\t\tif (ret) {\n-\t\t\trte_spinlock_unlock(&hw->lock);\n-\t\t\treturn ret;\n-\t\t}\n-\n-\t\trte_ether_addr_copy(addr, &hw->mc_addrs[hw->mc_addrs_num]);\n-\t\thw->mc_addrs_num++;\n-\t}\n-\trte_spinlock_unlock(&hw->lock);\n-\n-\treturn 0;\n-}\n-\n static int\n hns3vf_set_promisc_mode(struct hns3_hw *hw, bool en_bc_pmc,\n \t\t\tbool en_uc_pmc, bool en_mc_pmc)\n@@ -2678,7 +2630,7 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = {\n \t.mac_addr_add = hns3_add_mac_addr,\n \t.mac_addr_remove = hns3_remove_mac_addr,\n \t.mac_addr_set = hns3vf_set_default_mac_addr,\n-\t.set_mc_addr_list = hns3vf_set_mc_mac_addr_list,\n+\t.set_mc_addr_list = hns3_set_mc_mac_addr_list,\n \t.link_update = hns3vf_dev_link_update,\n \t.rss_hash_update = hns3_dev_rss_hash_update,\n \t.rss_hash_conf_get = hns3_dev_rss_hash_conf_get,\n", "prefixes": [ "14/14" ] }