Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102565/?format=api
{ "id": 102565, "url": "https://patches.dpdk.org/api/patches/102565/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-23-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211021095023.18288-23-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211021095023.18288-23-jiawenwu@trustnetic.com", "date": "2021-10-21T09:50:19", "name": "[v2,22/26] net/ngbe: support register dump", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ecf4e68968db2d5a33f5d1416137ced6ca60e7c7", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-23-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 19874, "url": "https://patches.dpdk.org/api/series/19874/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19874", "date": "2021-10-21T09:49:58", "name": "net/ngbe: add many features", "version": 2, "mbox": "https://patches.dpdk.org/series/19874/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102565/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/102565/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7ADFBA0547;\n\tThu, 21 Oct 2021 11:54:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E9CEF4127C;\n\tThu, 21 Oct 2021 11:51:19 +0200 (CEST)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id C271641250\n for <dev@dpdk.org>; Thu, 21 Oct 2021 11:51:15 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 21 Oct 2021 17:51:10 +0800 (CST)" ], "X-QQ-mid": "bizesmtp38t1634809870t1ikw2s8", "X-QQ-SSF": "01400000000000E0I000000A0000000", "X-QQ-FEAT": "OhFpIYkBcd1dW2JkYXWGynRwnMd8xK9/3b02oAxygcf0BowCQGo/TsSALp05D\n +tCmdo+hLMJ8pM4ofhgzall+gr8xqCOq5+Dbss/PVxwPpzu+NhoKDq8Kbc7mW389u/GFyoZ\n sce322zv6iSzvNlN+UAeMgmEkOA/I/GyuLDQUBiRr9NVkMWq/1sc0QLKWrbxSw2PyTekZnK\n JDisPmzoSj2CnhR6Z5imnfCO2KxxGCaEEIofcl+VKH5CAIK22wBsbrWtUHuhR5pelkLUJJH\n cb7QqSIGfct/+FbY/guQRx0UZPAtkZ+D6uO3ozsn4AAIA2ZRy/d6sx4fgkk+8QzXo5VdojP\n HjhsDOhJbhS7dDDsYp71zgjO/tUTpZtPqFtqWwkSaut7h45UhY=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Thu, 21 Oct 2021 17:50:19 +0800", "Message-Id": "<20211021095023.18288-23-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "References": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 22/26] net/ngbe: support register dump", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to dump registers.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/ngbe.ini | 1 +\n drivers/net/ngbe/base/ngbe_type.h | 1 +\n drivers/net/ngbe/ngbe_ethdev.c | 108 +++++++++++++++++++++++++++++\n drivers/net/ngbe/ngbe_regs_group.h | 54 +++++++++++++++\n 4 files changed, 164 insertions(+)\n create mode 100644 drivers/net/ngbe/ngbe_regs_group.h", "diff": "diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini\nindex 8cc556aea0..9bb10c744e 100644\n--- a/doc/guides/nics/features/ngbe.ini\n+++ b/doc/guides/nics/features/ngbe.ini\n@@ -36,6 +36,7 @@ Extended stats = Y\n Stats per queue = Y\n FW version = Y\n EEPROM dump = Y\n+Registers dump = Y\n Multiprocess aware = Y\n Linux = Y\n ARMv8 = Y\ndiff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h\nindex 32d3ab5d03..12847b7272 100644\n--- a/drivers/net/ngbe/base/ngbe_type.h\n+++ b/drivers/net/ngbe/base/ngbe_type.h\n@@ -398,6 +398,7 @@ struct ngbe_hw {\n \tu16 sub_device_id;\n \tu16 sub_system_id;\n \tu32 eeprom_id;\n+\tu8 revision_id;\n \tbool adapter_stopped;\n \n \tuint64_t isb_dma;\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 9838e2966e..4c839afe85 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -13,6 +13,67 @@\n #include \"ngbe.h\"\n #include \"ngbe_ethdev.h\"\n #include \"ngbe_rxtx.h\"\n+#include \"ngbe_regs_group.h\"\n+\n+static const struct reg_info ngbe_regs_general[] = {\n+\t{NGBE_RST, 1, 1, \"NGBE_RST\"},\n+\t{NGBE_STAT, 1, 1, \"NGBE_STAT\"},\n+\t{NGBE_PORTCTL, 1, 1, \"NGBE_PORTCTL\"},\n+\t{NGBE_GPIODATA, 1, 1, \"NGBE_GPIODATA\"},\n+\t{NGBE_GPIOCTL, 1, 1, \"NGBE_GPIOCTL\"},\n+\t{NGBE_LEDCTL, 1, 1, \"NGBE_LEDCTL\"},\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_nvm[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_interrupt[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_fctl_others[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_rxdma[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_rx[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static struct reg_info ngbe_regs_tx[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_wakeup[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_mac[] = {\n+\t{0, 0, 0, \"\"}\n+};\n+\n+static const struct reg_info ngbe_regs_diagnostic[] = {\n+\t{0, 0, 0, \"\"},\n+};\n+\n+/* PF registers */\n+static const struct reg_info *ngbe_regs_others[] = {\n+\t\t\t\tngbe_regs_general,\n+\t\t\t\tngbe_regs_nvm,\n+\t\t\t\tngbe_regs_interrupt,\n+\t\t\t\tngbe_regs_fctl_others,\n+\t\t\t\tngbe_regs_rxdma,\n+\t\t\t\tngbe_regs_rx,\n+\t\t\t\tngbe_regs_tx,\n+\t\t\t\tngbe_regs_wakeup,\n+\t\t\t\tngbe_regs_mac,\n+\t\t\t\tngbe_regs_diagnostic,\n+\t\t\t\tNULL};\n \n static int ngbe_dev_close(struct rte_eth_dev *dev);\n static int ngbe_dev_link_update(struct rte_eth_dev *dev,\n@@ -2672,6 +2733,52 @@ ngbe_dev_set_mc_addr_list(struct rte_eth_dev *dev,\n \t\t\t\t\t ngbe_dev_addr_list_itr, TRUE);\n }\n \n+static int\n+ngbe_get_reg_length(struct rte_eth_dev *dev __rte_unused)\n+{\n+\tint count = 0;\n+\tint g_ind = 0;\n+\tconst struct reg_info *reg_group;\n+\tconst struct reg_info **reg_set = ngbe_regs_others;\n+\n+\twhile ((reg_group = reg_set[g_ind++]))\n+\t\tcount += ngbe_regs_group_count(reg_group);\n+\n+\treturn count;\n+}\n+\n+static int\n+ngbe_get_regs(struct rte_eth_dev *dev,\n+\t struct rte_dev_reg_info *regs)\n+{\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\tuint32_t *data = regs->data;\n+\tint g_ind = 0;\n+\tint count = 0;\n+\tconst struct reg_info *reg_group;\n+\tconst struct reg_info **reg_set = ngbe_regs_others;\n+\n+\tif (data == NULL) {\n+\t\tregs->length = ngbe_get_reg_length(dev);\n+\t\tregs->width = sizeof(uint32_t);\n+\t\treturn 0;\n+\t}\n+\n+\t/* Support only full register dump */\n+\tif (regs->length == 0 ||\n+\t regs->length == (uint32_t)ngbe_get_reg_length(dev)) {\n+\t\tregs->version = hw->mac.type << 24 |\n+\t\t\t\thw->revision_id << 16 |\n+\t\t\t\thw->device_id;\n+\t\twhile ((reg_group = reg_set[g_ind++]))\n+\t\t\tcount += ngbe_read_regs_group(dev, &data[count],\n+\t\t\t\t\t\t reg_group);\n+\t\treturn 0;\n+\t}\n+\n+\treturn -ENOTSUP;\n+}\n+\n static int\n ngbe_get_eeprom_length(struct rte_eth_dev *dev)\n {\n@@ -2769,6 +2876,7 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.rss_hash_update = ngbe_dev_rss_hash_update,\n \t.rss_hash_conf_get = ngbe_dev_rss_hash_conf_get,\n \t.set_mc_addr_list = ngbe_dev_set_mc_addr_list,\n+\t.get_reg = ngbe_get_regs,\n \t.rx_burst_mode_get = ngbe_rx_burst_mode_get,\n \t.tx_burst_mode_get = ngbe_tx_burst_mode_get,\n \t.get_eeprom_length = ngbe_get_eeprom_length,\ndiff --git a/drivers/net/ngbe/ngbe_regs_group.h b/drivers/net/ngbe/ngbe_regs_group.h\nnew file mode 100644\nindex 0000000000..cc4b69fd54\n--- /dev/null\n+++ b/drivers/net/ngbe/ngbe_regs_group.h\n@@ -0,0 +1,54 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018-2021 Beijing WangXun Technology Co., Ltd.\n+ * Copyright(c) 2010-2017 Intel Corporation\n+ */\n+\n+#ifndef _NGBE_REGS_GROUP_H_\n+#define _NGBE_REGS_GROUP_H_\n+\n+#include \"ngbe_ethdev.h\"\n+\n+struct ngbe_hw;\n+struct reg_info {\n+\tuint32_t base_addr;\n+\tuint32_t count;\n+\tuint32_t stride;\n+\tconst char *name;\n+};\n+\n+static inline int\n+ngbe_read_regs(struct ngbe_hw *hw, const struct reg_info *reg,\n+\tuint32_t *reg_buf)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < reg->count; i++)\n+\t\treg_buf[i] = rd32(hw, reg->base_addr + i * reg->stride);\n+\treturn reg->count;\n+};\n+\n+static inline int\n+ngbe_regs_group_count(const struct reg_info *regs)\n+{\n+\tint count = 0;\n+\tint i = 0;\n+\n+\twhile (regs[i].count)\n+\t\tcount += regs[i++].count;\n+\treturn count;\n+};\n+\n+static inline int\n+ngbe_read_regs_group(struct rte_eth_dev *dev, uint32_t *reg_buf,\n+\t\t\t\t\t const struct reg_info *regs)\n+{\n+\tint count = 0;\n+\tint i = 0;\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\n+\twhile (regs[i].count)\n+\t\tcount += ngbe_read_regs(hw, ®s[i++], ®_buf[count]);\n+\treturn count;\n+};\n+\n+#endif /* _NGBE_REGS_GROUP_H_ */\n", "prefixes": [ "v2", "22/26" ] }