Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102296/?format=api
{ "id": 102296, "url": "https://patches.dpdk.org/api/patches/102296/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211019183543.132084-8-hkalra@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211019183543.132084-8-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211019183543.132084-8-hkalra@marvell.com", "date": "2021-10-19T18:35:42", "name": "[v4,7/7] eal/alarm: introduce alarm fini routine", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "840b19886be3a11d85949582e562eef7c3aa97f3", "submitter": { "id": 1182, "url": "https://patches.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211019183543.132084-8-hkalra@marvell.com/mbox/", "series": [ { "id": 19805, "url": "https://patches.dpdk.org/api/series/19805/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19805", "date": "2021-10-19T18:35:35", "name": "make rte_intr_handle internal", "version": 4, "mbox": "https://patches.dpdk.org/series/19805/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/102296/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/102296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 571F0A0547;\n\tTue, 19 Oct 2021 20:37:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F163410EF;\n\tTue, 19 Oct 2021 20:36:59 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id B254A410EF\n for <dev@dpdk.org>; Tue, 19 Oct 2021 20:36:56 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 19JFURtm021040;\n Tue, 19 Oct 2021 11:36:54 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3bt05g115f-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 19 Oct 2021 11:36:54 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 19 Oct 2021 11:36:52 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 19 Oct 2021 11:36:52 -0700", "from localhost.localdomain (unknown [10.29.52.211])\n by maili.marvell.com (Postfix) with ESMTP id 6DA933F7043;\n Tue, 19 Oct 2021 11:36:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=jvdbQ2muAn2Si/wnJv0HrwTlxlMhbI28R670UxlcsXI=;\n b=XlA3Ws3BWqWT7DnOCpMvvbpryr0Fyl6x4SxIQngmJMAgd9zbFw9Q20ihBdJKCh1bCvYH\n qLWG7OP6DUG0W12xvkApjRukbclOHT+ePQ678/6WcJEB0YbSz18vi+5R+h/nvSBm3RJ8\n +VKPRPiu1cqc1B2LBOAnBnrZeUb8+yDDt3EDSk7u3LG1yO11i65NQDymL8iyqpJ9ixh9\n 1Nr+kszac6djry9AEH6RUlQ3UqARc0NLX20/qThdISdSo5j/Bv2yf0HTIZbVbdC5T/48\n MH4W3DeqKjv5Mus+h0FNJ5bKxiqYGsjnWQONb1gumhe8p2ZycmLcrfqH/mILAV09Q/zP Lg==", "From": "Harman Kalra <hkalra@marvell.com>", "To": "<dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>", "CC": "<david.marchand@redhat.com>, <dmitry.kozliuk@gmail.com>, <mdr@ashroe.eu>,\n <thomas@monjalon.net>, Harman Kalra <hkalra@marvell.com>", "Date": "Wed, 20 Oct 2021 00:05:42 +0530", "Message-ID": "<20211019183543.132084-8-hkalra@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20211019183543.132084-1-hkalra@marvell.com>", "References": "<20210826145726.102081-1-hkalra@marvell.com>\n <20211019183543.132084-1-hkalra@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "0h5rx-lPn4JOCdNTd7qZ1A_3SdL4ObzY", "X-Proofpoint-ORIG-GUID": "0h5rx-lPn4JOCdNTd7qZ1A_3SdL4ObzY", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-19_02,2021-10-19_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v4 7/7] eal/alarm: introduce alarm fini routine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implementing alarm cleanup routine, where the memory allocated\nfor interrupt instance can be freed.\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n lib/eal/common/eal_private.h | 11 +++++++++++\n lib/eal/freebsd/eal.c | 1 +\n lib/eal/freebsd/eal_alarm.c | 7 +++++++\n lib/eal/linux/eal.c | 1 +\n lib/eal/linux/eal_alarm.c | 10 +++++++++-\n 5 files changed, 29 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h\nindex 86dab1f057..7fb9bc1324 100644\n--- a/lib/eal/common/eal_private.h\n+++ b/lib/eal/common/eal_private.h\n@@ -163,6 +163,17 @@ int rte_eal_intr_init(void);\n */\n int rte_eal_alarm_init(void);\n \n+/**\n+ * Init alarm mechanism. This is to allow a callback be called after\n+ * specific time.\n+ *\n+ * This function is private to EAL.\n+ *\n+ * @return\n+ * 0 on success, negative on error\n+ */\n+void rte_eal_alarm_fini(void);\n+\n /**\n * Function is to check if the kernel module(like, vfio, vfio_iommu_type1,\n * etc.) loaded.\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 56a60f13e9..535ea687ca 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -977,6 +977,7 @@ rte_eal_cleanup(void)\n \trte_eal_memory_detach();\n \trte_trace_save();\n \teal_trace_fini();\n+\trte_eal_alarm_fini();\n \teal_cleanup_config(internal_conf);\n \treturn 0;\n }\ndiff --git a/lib/eal/freebsd/eal_alarm.c b/lib/eal/freebsd/eal_alarm.c\nindex cd971036cd..167384e79a 100644\n--- a/lib/eal/freebsd/eal_alarm.c\n+++ b/lib/eal/freebsd/eal_alarm.c\n@@ -46,6 +46,13 @@ static rte_spinlock_t alarm_list_lk = RTE_SPINLOCK_INITIALIZER;\n static struct rte_intr_handle *intr_handle;\n static void eal_alarm_callback(void *arg);\n \n+void\n+rte_eal_alarm_fini(void)\n+{\n+\tif (intr_handle)\n+\t\trte_intr_instance_free(intr_handle);\n+}\n+\n int\n rte_eal_alarm_init(void)\n {\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 0d0fc66668..806158f297 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -1370,6 +1370,7 @@ rte_eal_cleanup(void)\n \trte_eal_memory_detach();\n \trte_trace_save();\n \teal_trace_fini();\n+\trte_eal_alarm_fini();\n \teal_cleanup_config(internal_conf);\n \treturn 0;\n }\ndiff --git a/lib/eal/linux/eal_alarm.c b/lib/eal/linux/eal_alarm.c\nindex cf8e2f2066..56f69d8e6d 100644\n--- a/lib/eal/linux/eal_alarm.c\n+++ b/lib/eal/linux/eal_alarm.c\n@@ -58,6 +58,13 @@ static struct rte_intr_handle *intr_handle;\n static int handler_registered = 0;\n static void eal_alarm_callback(void *arg);\n \n+void\n+rte_eal_alarm_fini(void)\n+{\n+\tif (intr_handle)\n+\t\trte_intr_instance_free(intr_handle);\n+}\n+\n int\n rte_eal_alarm_init(void)\n {\n@@ -68,7 +75,8 @@ rte_eal_alarm_init(void)\n \t\tgoto error;\n \t}\n \n-\trte_intr_type_set(intr_handle, RTE_INTR_HANDLE_ALARM);\n+\tif (rte_intr_type_set(intr_handle, RTE_INTR_HANDLE_ALARM))\n+\t\tgoto error;\n \n \t/* create a timerfd file descriptor */\n \tif (rte_intr_fd_set(intr_handle,\n", "prefixes": [ "v4", "7/7" ] }