Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10221/?format=api
https://patches.dpdk.org/api/patches/10221/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1454046700-20843-1-git-send-email-michael.qiu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1454046700-20843-1-git-send-email-michael.qiu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1454046700-20843-1-git-send-email-michael.qiu@intel.com", "date": "2016-01-29T05:51:40", "name": "[dpdk-dev] ixgbe: Fix disable interrupt twice", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e42a80f614caf1b4ce6e5842f77d6fbf8d178f5e", "submitter": { "id": 101, "url": "https://patches.dpdk.org/api/people/101/?format=api", "name": "Michael Qiu", "email": "michael.qiu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1454046700-20843-1-git-send-email-michael.qiu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10221/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 88FEDC54A;\n\tFri, 29 Jan 2016 06:51:50 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 71118C548\n\tfor <dev@dpdk.org>; Fri, 29 Jan 2016 06:51:49 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 28 Jan 2016 21:51:48 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 28 Jan 2016 21:51:48 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u0T5pjJ3014787;\n\tFri, 29 Jan 2016 13:51:45 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u0T5pfkP020877; Fri, 29 Jan 2016 13:51:43 +0800", "(from dayuqiu@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u0T5pfU3020873; \n\tFri, 29 Jan 2016 13:51:41 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,362,1449561600\"; d=\"scan'208\";a=\"903618890\"", "From": "Michael Qiu <michael.qiu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 29 Jan 2016 13:51:40 +0800", "Message-Id": "<1454046700-20843-1-git-send-email-michael.qiu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] ixgbe: Fix disable interrupt twice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, ixgbe vf and pf will disable interrupte twice in\nstop stage and uninit stage. It will cause an error:\n\n testpmd> quit\n\n Shutting down port 0...\n Stopping ports...\n Done\n Closing ports...\n EAL: Error disabling MSI-X interrupts for fd 26\n Done\n\nBecasue the interrupt already been disabled in stop stage.\nSince it is enabled in init stage, better remove from\nstop stage.\n\nFixes: 0eb609239efd (\"ixgbe: enable Rx queue interrupts for PF and VF\")\n\nSigned-off-by: Michael Qiu <michael.qiu@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 4c4c6df..a561f8d 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2192,9 +2192,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)\n \t/* disable interrupts */\n \tixgbe_disable_intr(hw);\n \n-\t/* disable intr eventfd mapping */\n-\trte_intr_disable(intr_handle);\n-\n \t/* reset the NIC */\n \tixgbe_pf_reset_hw(hw);\n \thw->adapter_stopped = 0;\n@@ -3898,9 +3895,6 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev)\n \n \tixgbe_dev_clear_queues(dev);\n \n-\t/* disable intr eventfd mapping */\n-\trte_intr_disable(intr_handle);\n-\n \t/* Clean datapath event and queue/vec mapping */\n \trte_intr_efd_disable(intr_handle);\n \tif (intr_handle->intr_vec != NULL) {\n", "prefixes": [ "dpdk-dev" ] }{ "id": 10221, "url": "