Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1018,
    "url": "https://patches.dpdk.org/api/patches/1018/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1414572576-21371-19-git-send-email-mukawa@igel.co.jp/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1414572576-21371-19-git-send-email-mukawa@igel.co.jp>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1414572576-21371-19-git-send-email-mukawa@igel.co.jp",
    "date": "2014-10-29T08:49:29",
    "name": "[dpdk-dev,RFC,18/25] eal/pci: Prevent double registrations for pci_device_list",
    "commit_ref": null,
    "pull_url": null,
    "state": "rfc",
    "archived": true,
    "hash": "1833b0a2a04b7b6b8a93fbdbf8aa529c24047e23",
    "submitter": {
        "id": 64,
        "url": "https://patches.dpdk.org/api/people/64/?format=api",
        "name": "Tetsuya Mukawa",
        "email": "mukawa@igel.co.jp"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1414572576-21371-19-git-send-email-mukawa@igel.co.jp/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1018/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1018/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6BE1A805D;\n\tWed, 29 Oct 2014 09:41:57 +0100 (CET)",
            "from mail-pa0-f44.google.com (mail-pa0-f44.google.com\n\t[209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 169F17FCC\n\tfor <dev@dpdk.org>; Wed, 29 Oct 2014 09:41:46 +0100 (CET)",
            "by mail-pa0-f44.google.com with SMTP id bj1so2737446pad.31\n\tfor <dev@dpdk.org>; Wed, 29 Oct 2014 01:50:37 -0700 (PDT)",
            "from eris.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132])\n\tby mx.google.com with ESMTPSA id\n\tky4sm3686872pbc.55.2014.10.29.01.50.35 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 29 Oct 2014 01:50:36 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=fzagOiS8r6RFnDGv3SV8LFnU8IeQyOodTOuNlmdHac0=;\n\tb=LNdxiDbmuFrBW+EBcJaBgR/R6fYIcw9kEKRQuaz3fs8tjE7uqHrqXOFs+VCftDyau/\n\tZfpojx59awtguJsGh6/6nX6Y96SQWAvb/5N9b/9ShIVW/md6Vvj+vaDobNFTmB6ZWPD5\n\tbljcZ7Z6JyJ9bJr2pt68OevEmz9/uiQkSesuiVMLtzUkqJp4CFHF/+y1MSwReadpXbwI\n\txefdF8Mds+AdP+reXRTRvWVeXFQE7nIztgbZvtKrYtrENyX/757qpgPWUv5bO+ZVjpn/\n\tcILQsjB2Sh4ip2/Ta0mZjwimBkttMEkpm6baErn+AonpJrF69yiy1wl71yRh6RkAsGQ3\n\tNfLg==",
        "X-Gm-Message-State": "ALoCoQnEvVAHpv6hjumWczd7tiJEAQw8n3sU+RdIjpL3sgrJFAzAVoR1QlgRbH9jyHV/FM3OeoN1",
        "X-Received": "by 10.68.216.70 with SMTP id oo6mr9181070pbc.124.1414572637407; \n\tWed, 29 Oct 2014 01:50:37 -0700 (PDT)",
        "From": "Tetsuya Mukawa <mukawa@igel.co.jp>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 29 Oct 2014 17:49:29 +0900",
        "Message-Id": "<1414572576-21371-19-git-send-email-mukawa@igel.co.jp>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1414572576-21371-1-git-send-email-mukawa@igel.co.jp>",
        "References": "<1414572576-21371-1-git-send-email-mukawa@igel.co.jp>",
        "Cc": "nakajima.yoshihiro@lab.ntt.co.jp, masutani.hitoshi@lab.ntt.co.jp",
        "Subject": "[dpdk-dev] [RFC PATCH 18/25] eal/pci: Prevent double registrations\n\tfor pci_device_list",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The patch fixes pci_scan_one() not to register same pci devices twice.\n\nSigned-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>\n---\n lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex 57a5887..c70e8ea 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -292,14 +292,17 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,\n \t}\n \telse {\n \t\tstruct rte_pci_device *dev2 = NULL;\n+\t\tint ret;\n \n \t\tTAILQ_FOREACH(dev2, &pci_device_list, next) {\n-\t\t\tif (eal_compare_pci_addr(&dev->addr, &dev2->addr) != 0)\n+\t\t\tret = eal_compare_pci_addr(&dev->addr, &dev2->addr);\n+\t\t\tif (ret > 0)\n \t\t\t\tcontinue;\n-\t\t\telse {\n+\t\t\telse if (ret < 0) {\n \t\t\t\tTAILQ_INSERT_BEFORE(dev2, dev, next);\n \t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\t} else\t/* already registered */\n+\t\t\t\treturn 0;\n \t\t}\n \t\tTAILQ_INSERT_TAIL(&pci_device_list, dev, next);\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "RFC",
        "18/25"
    ]
}