Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101251/?format=api
{ "id": 101251, "url": "https://patches.dpdk.org/api/patches/101251/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211012193829.24782-1-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211012193829.24782-1-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211012193829.24782-1-ivan.malov@oktetlabs.ru", "date": "2021-10-12T19:38:24", "name": "[v6,0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 869, "url": "https://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211012193829.24782-1-ivan.malov@oktetlabs.ru/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/101251/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/101251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59107A0C4C;\n\tTue, 12 Oct 2021 21:38:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 14EA2410E7;\n\tTue, 12 Oct 2021 21:38:36 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 2AE6B40142\n for <dev@dpdk.org>; Tue, 12 Oct 2021 21:38:35 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.123.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7813C7F567;\n Tue, 12 Oct 2021 22:38:34 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7813C7F567", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1634067514;\n bh=rt/5yjhkIqzoQcUGeYTsy5dE5b67lSkSrFiamdNt9lk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=KxkhRAzDHfOSaf6k7Ptp16CM1BgWVkUvvd61O0Vi+p6V9FJqHfGY0CCo9apZHSTT2\n iSg+0MKsVl770Al0rtbSazi4Mj26bHVMR63cJko9nhBGqbiWbmQxRPxBhs7gBgq9fU\n 6WQn6/vO/H8PLh6AlHWi03K/OoxHOB/RPpVqn27A=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 12 Oct 2021 22:38:24 +0300", "Message-Id": "<20211012193829.24782-1-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210923112012.14595-1-ivan.malov@oktetlabs.ru>", "References": "<20210923112012.14595-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 0/5] ethdev: negotiate the NIC's ability to\n deliver Rx metadata to the PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace\nintending to add new flags, RSS_HASH and FLOW_MARK. Since then,\nonly the former has been added. The issue has not been solved.\nApplications still assume that metadata features always work\nand do not need to be configured in advance.\n\nThe team behind net/sfc driver has given this problem more thought.\nConclusions that have been reached are as follows.\n\n1. Not all kinds of metadata can be represented by device offload flags.\n For instance, having flag RSS_HASH is legitimate because the NIC is\n supposed to actually compute something when this feature is active.\n However, if similar flag existed for Rx mark, requesting it would\n not make the NIC actually compute anything. The HW needs external\n stimuli (flow rules) in order to set the mark in the first place.\n\n2. As a consequence of (1), it is apparent that the user's ability to\n use Rx metadata features is complex and consists of multiple parts:\n a) the NIC's ability to conduct the flow actions (set metadata);\n b) the NIC's ability to deliver metadata (if set) to the PMD;\n c) the PMD's ability to provide metadata received from the\n NIC to the user by virtue of filling out mbuf fields.\n\n3. Aspects (2-a) and (2-c) are already addressed by flow validate API\n and the procedure of dynamic mbuf field registration respectively,\n hence, the only problem which really needs a solution is (2-b).\n \nPatch [1/5] of this series adds a generic API to let the application\nnegotiate the NIC's ability to deliver specific kinds of metadata to\nthe PMD. This API is supposed to be invoked during initialisation\nperiod in order to let the PMD configure HW resources which might\nbe hard to (re-)configure in the adapter's started state without\ncausing traffic disruption and other unwanted consequences.\n\n[1] c5b2e78d1172 (\"doc: announce ethdev API changes in offload flags\")\n\nChanges in v2:\n* [1/5] has review notes from Jerin Jacob applied and the ack from Ray Kinsella added\n* [2/5] has minor adjustments incorporated to follow changes in [1/5]\n\nChanges in v3:\n* [1/5] through [5/5] have review notes from Andy Moreton applied (mostly rewording)\n* [1/5] has the ack from Jerin Jacob added\n\nChanges in v4:\n* [1/5] has the API contract clarified to address concerns raised by Ori Kam\n* [1/5] has the API name fixed to use term \"metadata\" instead of \"meta\"\n* [1/5] has testpmd loglevel changed as per the note by Ajit Khaparde\n* [1/5] has testpmd code revisited to take multi-process into account\n* [2/5] through [5/5] have the corresponding adjustments incorporated\n\nChanges in v5:\n* [1/5] has the API comment improved as per the note by Ori Kam\n\nChanges in v6:\n* Rebase as per request by Ferruh Yigit\n\nIvan Malov (5):\n ethdev: negotiate delivery of packet metadata from HW to PMD\n net/sfc: support API to negotiate delivery of Rx metadata\n net/sfc: support flow mark delivery on EF100 native datapath\n common/sfc_efx/base: add RxQ flag to use Rx prefix user flag\n net/sfc: report user flag on EF100 native datapath\n\n app/test-flow-perf/main.c | 21 ++++++++++\n app/test-pmd/testpmd.c | 37 ++++++++++++++++++\n doc/guides/rel_notes/release_21_11.rst | 9 +++++\n drivers/common/sfc_efx/base/ef10_rx.c | 54 ++++++++++++++++----------\n drivers/common/sfc_efx/base/efx.h | 4 ++\n drivers/common/sfc_efx/base/rhead_rx.c | 3 ++\n drivers/net/sfc/sfc.h | 2 +\n drivers/net/sfc/sfc_ef100_rx.c | 19 +++++++++\n drivers/net/sfc/sfc_ethdev.c | 29 ++++++++++++++\n drivers/net/sfc/sfc_flow.c | 13 +++++++\n drivers/net/sfc/sfc_mae.c | 22 ++++++++++-\n drivers/net/sfc/sfc_rx.c | 6 +++\n lib/ethdev/ethdev_driver.h | 22 +++++++++++\n lib/ethdev/rte_ethdev.c | 25 ++++++++++++\n lib/ethdev/rte_ethdev.h | 54 ++++++++++++++++++++++++++\n lib/ethdev/rte_flow.h | 12 ++++++\n lib/ethdev/version.map | 3 ++\n 17 files changed, 312 insertions(+), 23 deletions(-)", "diff": null, "prefixes": [ "v6", "0/5" ] }