Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101099/?format=api
{ "id": 101099, "url": "https://patches.dpdk.org/api/patches/101099/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20211011155057.302142-21-skori@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211011155057.302142-21-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211011155057.302142-21-skori@marvell.com", "date": "2021-10-11T15:50:48", "name": "[v4,20/28] net/cnxk: support ops to create meter policy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd7f5e4e1639c7bc52ab8e1007873e7515a74407", "submitter": { "id": 1318, "url": "https://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20211011155057.302142-21-skori@marvell.com/mbox/", "series": [ { "id": 19528, "url": "https://patches.dpdk.org/api/series/19528/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19528", "date": "2021-10-11T15:50:28", "name": "Support ingress policer", "version": 4, "mbox": "https://patches.dpdk.org/series/19528/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/101099/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/101099/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF4DFA034F;\n\tMon, 11 Oct 2021 17:53:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2706941175;\n\tMon, 11 Oct 2021 17:51:54 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 9C6A44115A\n for <dev@dpdk.org>; Mon, 11 Oct 2021 17:51:52 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BEHcPv030591\n for <dev@dpdk.org>; Mon, 11 Oct 2021 08:51:51 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3bmpv4rc3x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 11 Oct 2021 08:51:51 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 11 Oct 2021 08:51:49 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 11 Oct 2021 08:51:49 -0700", "from localhost.localdomain (unknown [10.28.34.25])\n by maili.marvell.com (Postfix) with ESMTP id 89AEE3F705B;\n Mon, 11 Oct 2021 08:51:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=vpI3k8nnJM+uQAdeVgLfYIq5pQ0CnA5fBqA8EtN2YkU=;\n b=OZvr5V0M7x6MFt+mQdy+wo8cmEn0XOQwYtAhvdvW+VPB6IuP/Bbi3HnA7DakT7xRDbEB\n YZPJgi1YreNYQlsiFWfvRGMHIQ26pPSPUEZbEm2xqfWU0N0xUQTo7IxFb/sxoir1cmfl\n mVCqp/2H93lWljEYcKcaOFrrPKr/CehRPNTK3vA/3Oxdhjy2jcPtW/EDEqJha/yRmeA/\n WQMflIRd+mxtaZG/7MO2BUCxc7Ys9GIIu4KzLWK6kXeI+wQDyrP3VxJ8cY39RI7jrBcB\n 87ApuwHPLXgqFYb9tPcU8wSjmjheGG+Ij96q8LJ1h59Quwvra4VP1KkatEK0/e7JXG/5 DA==", "From": "<skori@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Rakesh Kudurumalla <rkudurumalla@marvell.com>", "Date": "Mon, 11 Oct 2021 21:20:48 +0530", "Message-ID": "<20211011155057.302142-21-skori@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211011155057.302142-1-skori@marvell.com>", "References": "<20210930090844.1059326-1-skori@marvell.com>\n <20211011155057.302142-1-skori@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Kl70R2J2I4nblf1_UILwGygUS4slKcQj", "X-Proofpoint-GUID": "Kl70R2J2I4nblf1_UILwGygUS4slKcQj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-11_05,2021-10-11_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v4 20/28] net/cnxk: support ops to create meter\n policy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nImplement API to add meter policy for CNXK platform.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nSigned-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>\n---\nv4:\n - Rebase support on dpdk-next-net-mrvl branch\n - Handled meter action during flow destroy\n - Handled meter cleanup during port shutdown\n \nv3:\n - Rebase support on latest DPDK\n - Handled multilevel chaining for tree hierarchy\n - Fix naming convention\nv2:\n - Rebase support on latest DPDK\n - Handled multilevel chaining for linear hierarchy\n - Review comments incorporated\n\n drivers/net/cnxk/cnxk_ethdev.c | 1 +\n drivers/net/cnxk/cnxk_ethdev.h | 31 +++++++++++\n drivers/net/cnxk/cnxk_ethdev_mtr.c | 84 ++++++++++++++++++++++++++++++\n 3 files changed, 116 insertions(+)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex d748d5da04..6295fa0557 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -705,6 +705,7 @@ static int\n nix_ingress_policer_setup(struct cnxk_eth_dev *dev)\n {\n \tTAILQ_INIT(&dev->mtr_profiles);\n+\tTAILQ_INIT(&dev->mtr_policy);\n \n \treturn 0;\n }\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h\nindex c076208d77..4cdce5dfd0 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.h\n+++ b/drivers/net/cnxk/cnxk_ethdev.h\n@@ -159,6 +159,35 @@ struct cnxk_timesync_info {\n \tuint64_t *tx_tstamp;\n } __plt_cache_aligned;\n \n+struct action_rss {\n+\tenum rte_eth_hash_function func;\n+\tuint32_t level;\n+\tuint64_t types;\n+\tuint32_t key_len;\n+\tuint32_t queue_num;\n+\tuint8_t *key;\n+\tuint16_t *queue;\n+};\n+\n+struct policy_actions {\n+\tuint32_t action_fate;\n+\tunion {\n+\t\tuint16_t queue;\n+\t\tuint32_t mtr_id;\n+\t\tstruct action_rss *rss_desc;\n+\t};\n+};\n+\n+struct cnxk_mtr_policy_node {\n+\tTAILQ_ENTRY(cnxk_mtr_policy_node) next;\n+\t/**< Pointer to the next flow meter structure. */\n+\tuint32_t id;\t /**< Policy id */\n+\tuint32_t mtr_id; /** Meter id */\n+\tstruct rte_mtr_meter_policy_params policy;\n+\tstruct policy_actions actions[RTE_COLORS];\n+\tuint32_t ref_cnt;\n+};\n+\n struct cnxk_mtr_profile_node {\n \tTAILQ_ENTRY(cnxk_mtr_profile_node) next;\n \tstruct rte_mtr_meter_profile profile; /**< Profile detail. */\n@@ -167,6 +196,7 @@ struct cnxk_mtr_profile_node {\n };\n \n TAILQ_HEAD(cnxk_mtr_profiles, cnxk_mtr_profile_node);\n+TAILQ_HEAD(cnxk_mtr_policy, cnxk_mtr_policy_node);\n \n /* Security session private data */\n struct cnxk_eth_sec_sess {\n@@ -315,6 +345,7 @@ struct cnxk_eth_dev {\n \n \t/* Ingress policer */\n \tstruct cnxk_mtr_profiles mtr_profiles;\n+\tstruct cnxk_mtr_policy mtr_policy;\n \n \t/* Rx burst for cleanup(Only Primary) */\n \teth_rx_burst_t rx_pkt_burst_no_offload;\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_mtr.c b/drivers/net/cnxk/cnxk_ethdev_mtr.c\nindex ec34327756..187a0b90b2 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_mtr.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_mtr.c\n@@ -50,6 +50,18 @@ nix_mtr_profile_find(struct cnxk_eth_dev *dev, uint32_t profile_id)\n \treturn NULL;\n }\n \n+static struct cnxk_mtr_policy_node *\n+nix_mtr_policy_find(struct cnxk_eth_dev *dev, uint32_t meter_policy_id)\n+{\n+\tstruct cnxk_mtr_policy *fmps = &dev->mtr_policy;\n+\tstruct cnxk_mtr_policy_node *fmp;\n+\n+\tTAILQ_FOREACH(fmp, fmps, next)\n+\t\tif (meter_policy_id == fmp->id)\n+\t\t\treturn fmp;\n+\treturn NULL;\n+}\n+\n static int\n nix_mtr_profile_validate(struct cnxk_eth_dev *dev, uint32_t profile_id,\n \t\t\t struct rte_mtr_meter_profile *profile,\n@@ -266,11 +278,83 @@ cnxk_nix_mtr_policy_validate(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static void\n+cnxk_fill_policy_actions(struct cnxk_mtr_policy_node *fmp,\n+\t\t\t struct rte_mtr_meter_policy_params *policy)\n+\n+{\n+\tconst struct rte_flow_action_meter *mtr;\n+\tconst struct rte_flow_action *action;\n+\tint i;\n+\n+\tfor (i = 0; i < RTE_COLORS; i++) {\n+\t\tif (policy->actions[i]) {\n+\t\t\tfor (action = policy->actions[i];\n+\t\t\t action->type != RTE_FLOW_ACTION_TYPE_END;\n+\t\t\t action++) {\n+\t\t\t\tif (action->type ==\n+\t\t\t\t RTE_FLOW_ACTION_TYPE_METER) {\n+\t\t\t\t\tfmp->actions[i].action_fate =\n+\t\t\t\t\t\taction->type;\n+\t\t\t\t\tmtr = (const struct\n+\t\t\t\t\t rte_flow_action_meter *)\n+\t\t\t\t\t\t action->conf;\n+\t\t\t\t\tfmp->actions[i].mtr_id = mtr->mtr_id;\n+\t\t\t\t}\n+\n+\t\t\t\tif (action->type == RTE_FLOW_ACTION_TYPE_DROP) {\n+\t\t\t\t\tfmp->actions[i].action_fate =\n+\t\t\t\t\t\taction->type;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\t}\n+}\n+\n+static int\n+cnxk_nix_mtr_policy_add(struct rte_eth_dev *eth_dev, uint32_t policy_id,\n+\t\t\t struct rte_mtr_meter_policy_params *policy,\n+\t\t\t struct rte_mtr_error *error)\n+{\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct cnxk_mtr_policy *fmps = &dev->mtr_policy;\n+\tstruct cnxk_mtr_policy_node *fmp;\n+\tint rc;\n+\n+\tfmp = nix_mtr_policy_find(dev, policy_id);\n+\tif (fmp) {\n+\t\treturn -rte_mtr_error_set(error, EEXIST,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_METER_POLICY_ID,\n+\t\t\t\t\t NULL, \"Policy already exist\");\n+\t}\n+\n+\tfmp = plt_zmalloc(sizeof(struct cnxk_mtr_policy_node), ROC_ALIGN);\n+\tif (fmp == NULL) {\n+\t\treturn -rte_mtr_error_set(error, ENOMEM,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t \"Memory allocation failure\");\n+\t} else {\n+\t\trc = cnxk_nix_mtr_policy_validate(eth_dev, policy, error);\n+\t\tif (rc)\n+\t\t\tgoto exit;\n+\t}\n+\n+\tfmp->id = policy_id;\n+\tcnxk_fill_policy_actions(fmp, policy);\n+\tTAILQ_INSERT_TAIL(fmps, fmp, next);\n+\treturn 0;\n+\n+exit:\n+\tplt_free(fmp);\n+\treturn rc;\n+}\n+\n const struct rte_mtr_ops nix_mtr_ops = {\n \t.capabilities_get = cnxk_nix_mtr_capabilities_get,\n \t.meter_profile_add = cnxk_nix_mtr_profile_add,\n \t.meter_profile_delete = cnxk_nix_mtr_profile_delete,\n \t.meter_policy_validate = cnxk_nix_mtr_policy_validate,\n+\t.meter_policy_add = cnxk_nix_mtr_policy_add,\n };\n \n int\n", "prefixes": [ "v4", "20/28" ] }